PaperSpigot/TacoSpigot 1.8.8 issue with protocolsupport and 1.7 clients

[fuzzybot]

latest reflection helper, latest holoapi, latest packetlibapi, works fine on the last build of spigot-1.8.8. get the below error on the latest TacoSpigot 1.8.8 server:

[01:19:34] [Server thread/INFO]: [testholo] Enabling testholo v1.0 [01:19:34] [Server thread/INFO]: Server permissions file permissions.yml is empty, ignoring it [01:19:34] [Server thread/INFO]: Done (0.563s)! For help, type "help" or "?" [01:19:34] [Server thread/INFO]: Timings Reset [01:20:01] [LoginProcessingThread/INFO]: UUID of player fuzzy_bot is a9bba817-6a10-4b65-8cd2-ee2f88e66990 [01:20:01] [Server thread/WARN]: java.lang.IllegalArgumentException: object is not an instance of declaring class [01:20:01] [Server thread/WARN]: at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [01:20:01] [Server thread/WARN]: at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) [01:20:01] [Server thread/WARN]: at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [01:20:01] [Server thread/WARN]: at java.lang.reflect.Method.invoke(Method.java:498) [01:20:01] [Server thread/WARN]: at org.inventivetalent.reflection.minecraft.DataWatcher$V1_8.setValue(DataWatcher.java:398) [01:20:01] [Server thread/WARN]: at org.inventivetalent.reflection.minecraft.DataWatcher.setValue(DataWatcher.java:67) [01:20:01] [Server thread/WARN]: at org.inventivetalent.reflection.minecraft.DataWatcher.setValue(DataWatcher.java:74) [01:20:01] [Server thread/WARN]: at de.inventivegames.hologram.reflection.ClassBuilder.buildEntityHorse_1_7(ClassBuilder.java:81) [01:20:01] [Server thread/WARN]: at de.inventivegames.hologram.CraftHologram.buildPackets(CraftHologram.java:131) [01:20:01] [Server thread/WARN]: at de.inventivegames.hologram.DefaultHologram.spawn(DefaultHologram.java:90) [01:20:01] [Server thread/WARN]: at me.fuzzy.holo.Main.onJoinGame(Main.java:45) [01:20:01] [Server thread/WARN]: at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [01:20:01] [Server thread/WARN]: at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) [01:20:01] [Server thread/WARN]: at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [01:20:01] [Server thread/WARN]: at java.lang.reflect.Method.invoke(Method.java:498) [01:20:01] [Server thread/WARN]: at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:300) [01:20:01] [Server thread/WARN]: at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:78) [01:20:01] [Server thread/WARN]: at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) [01:20:01] [Server thread/WARN]: at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:501) [01:20:01] [Server thread/WARN]: at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:486) [01:20:01] [Server thread/WARN]: at net.minecraft.server.v1_8_R3.PlayerList.onPlayerJoin(PlayerList.java:314) [01:20:01] [Server thread/WARN]: at net.minecraft.server.v1_8_R3.PlayerList.a(PlayerList.java:173) [01:20:01] [Server thread/WARN]: at protocolsupport.protocol.transformer.handlers.AbstractLoginListener.b(AbstractLoginListener.java:145) [01:20:01] [Server thread/WARN]: at protocolsupport.protocol.transformer.handlers.AbstractLoginListener.c(AbstractLoginListener.java:91) [01:20:01] [Server thread/WARN]: at net.minecraft.server.v1_8_R3.NetworkManager.a(NetworkManager.java:231) [01:20:01] [Server thread/WARN]: at net.minecraft.server.v1_8_R3.ServerConnection.c(ServerConnection.java:148) [01:20:01] [Server thread/WARN]: at net.minecraft.server.v1_8_R3.MinecraftServer.B(MinecraftServer.java:875) [01:20:01] [Server thread/WARN]: at net.minecraft.server.v1_8_R3.DedicatedServer.B(DedicatedServer.java:378) [01:20:01] [Server thread/WARN]: at net.minecraft.server.v1_8_R3.MinecraftServer.A(MinecraftServer.java:713) [01:20:01] [Server thread/WARN]: at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:616) [01:20:01] [Server thread/WARN]: at java.lang.Thread.run(Thread.java:745) [01:20:01] [Netty Epoll Server IO #1/INFO]: MINECRAFT_1_7_10 [01:20:01] [Server thread/WARN]: java.lang.IllegalArgumentException: player and packet cannot be null [01:20:01] [Server thread/WARN]: at de.inventivegames.hologram.HologramAPI.sendPacket(HologramAPI.java:126) [01:20:01] [Server thread/WARN]: at de.inventivegames.hologram.CraftHologram.sendSpawnPackets(CraftHologram.java:286) [01:20:01] [Server thread/WARN]: at de.inventivegames.hologram.HologramAPI.spawn(HologramAPI.java:109) [01:20:01] [Server thread/WARN]: at de.inventivegames.hologram.HologramListeners.onTeleport(HologramListeners.java:51) [01:20:01] [Server thread/WARN]: at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [01:20:01] [Server thread/WARN]: at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) [01:20:01] [Server thread/WARN]: at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [01:20:01] [Server thread/WARN]: at java.lang.reflect.Method.invoke(Method.java:498) [01:20:01] [Server thread/WARN]: at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:300) [01:20:01] [Server thread/WARN]: at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:78) [01:20:01] [Server thread/WARN]: at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) [01:20:01] [Server thread/WARN]: at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:501) [01:20:01] [Server thread/WARN]: at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:486) [01:20:01] [Server thread/WARN]: at net.minecraft.server.v1_8_R3.PlayerConnection.a(PlayerConnection.java:501) [01:20:01] [Server thread/WARN]: at net.minecraft.server.v1_8_R3.PlayerConnection.a(PlayerConnection.java:469) [01:20:01] [Server thread/WARN]: at net.minecraft.server.v1_8_R3.PlayerList.a(PlayerList.java:176) [01:20:01] [Server thread/WARN]: at protocolsupport.protocol.transformer.handlers.AbstractLoginListener.b(AbstractLoginListener.java:145) [01:20:01] [Server thread/WARN]: at protocolsupport.protocol.transformer.handlers.AbstractLoginListener.c(AbstractLoginListener.java:91) [01:20:01] [Server thread/WARN]: at net.minecraft.server.v1_8_R3.NetworkManager.a(NetworkManager.java:231) [01:20:01] [Server thread/WARN]: at net.minecraft.server.v1_8_R3.ServerConnection.c(ServerConnection.java:148) [01:20:01] [Server thread/WARN]: at net.minecraft.server.v1_8_R3.MinecraftServer.B(MinecraftServer.java:875) [01:20:01] [Server thread/WARN]: at net.minecraft.server.v1_8_R3.DedicatedServer.B(DedicatedServer.java:378) [01:20:01] [Server thread/WARN]: at net.minecraft.server.v1_8_R3.MinecraftServer.A(MinecraftServer.java:713) [01:20:01] [Server thread/WARN]: at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:616) [01:20:01] [Server thread/WARN]: at java.lang.Thread.run(Thread.java:745) [01:20:01] [Server thread/INFO]: fuzzy_bot[/108.31.26.114:50409] logged in with entity id 0 at ([world]-5.999774690460013, 69.65470483645477, 15.928165525336158) [01:20:01] [Netty Epoll Server IO #1/WARN]: java.lang.IllegalArgumentException: player and packet cannot be null [01:20:01] [Netty Epoll Server IO #1/WARN]: at de.inventivegames.hologram.HologramAPI.sendPacket(HologramAPI.java:126) [01:20:01] [Netty Epoll Server IO #1/WARN]: at de.inventivegames.hologram.CraftHologram.sendSpawnPackets(CraftHologram.java:286) [01:20:01] [Netty Epoll Server IO #1/WARN]: at de.inventivegames.hologram.HologramAPI.spawn(HologramAPI.java:109) [01:20:01] [Netty Epoll Server IO #1/WARN]: at de.inventivegames.hologram.PacketListener.onSend(PacketListener.java:195) [01:20:01] [Netty Epoll Server IO #1/WARN]: at org.inventivetalent.packetlistener.handler.PacketHandler.notifyHandlers(PacketHandler.java:109) [01:20:01] [Netty Epoll Server IO #1/WARN]: at org.inventivetalent.packetlistener.PacketListenerAPI.onPacketSend(PacketListenerAPI.java:146) [01:20:01] [Netty Epoll Server IO #1/WARN]: at org.inventivetalent.packetlistener.channel.ChannelAbstract.onPacketSend(ChannelAbstract.java:113) [01:20:01] [Netty Epoll Server IO #1/WARN]: at org.inventivetalent.packetlistener.channel.INCChannel$ChannelHandler.write(INCChannel.java:168) [01:20:01] [Netty Epoll Server IO #1/WARN]: at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:658) [01:20:01] [Netty Epoll Server IO #1/WARN]: at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:716) [01:20:01] [Netty Epoll Server IO #1/WARN]: at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:706) [01:20:01] [Netty Epoll Server IO #1/WARN]: at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:741) [01:20:01] [Netty Epoll Server IO #1/WARN]: at io.netty.channel.DefaultChannelPipeline.writeAndFlush(DefaultChannelPipeline.java:895) [01:20:01] [Netty Epoll Server IO #1/WARN]: at io.netty.channel.AbstractChannel.writeAndFlush(AbstractChannel.java:240) [01:20:01] [Netty Epoll Server IO #1/WARN]: at com.comphenix.protocol.compat.netty.independent.NettyChannelProxy.writeAndFlush(NettyChannelProxy.java:327) [01:20:01] [Netty Epoll Server IO #1/WARN]: at net.minecraft.server.v1_8_R3.NetworkManager$4.run(NetworkManager.java:198) [01:20:01] [Netty Epoll Server IO #1/WARN]: at com.comphenix.protocol.compat.netty.independent.NettyChannelInjector$5$3.run(NettyChannelInjector.java:345) [01:20:01] [Netty Epoll Server IO #1/WARN]: at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:380) [01:20:01] [Netty Epoll Server IO #1/WARN]: at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:268) [01:20:01] [Netty Epoll Server IO #1/WARN]: at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:116) [01:20:01] [Netty Epoll Server IO #1/WARN]: at java.lang.Thread.run(Thread.java:745) [01:28:09] [Thread-4/INFO]: Stopping server

Willing to donate for a fix if needed.

[fuzzybot]

testholo is a simple plugin that makes a hologram for a player when they log in as a test case.

[InventivetalentDev]

Please upload your whole server log to pastebin.

[fuzzybot]

http://paste.ubuntu.com/18996726/

[fuzzybot]

Tested your latest commit,

http://paste.ubuntu.com/18997712/

[InventivetalentDev]

Have you tried normal spigot? This is pretty likely an incompatibility with TacoSpigot/PaperSpigot.

[fuzzybot]

Yes it works fine in normal spigot. It is specifically the changes paper did to mob entities, protocollib has a specific build for paper 1.8 servers because of this.

[InventivetalentDev]

Please try the latest snapshot (1.10.4).

[fuzzybot]

alright, in hologramapi we have an issue with buildHorseSpawnPacket_1_8 now

Object map_1_8 = AccessUtil.setAccessible(NMSClass.DataWatcher.getDeclaredField("dataValues")).get(dataWatcher_1_8);

NMUClass.gnu_trove_map_hash_TIntObjectHashMap.getDeclaredMethod("put", int.class, Object.class).invoke(map_1_8, 10, NMSClass.WatchableObject.getConstructor(int.class, int.class, Object.class).newInstance(0, 10, (byte) 1));

[fuzzybot]

http://pastebin.com/tHjAc3ct