Fixed warning conditions. Improvements, stability updates.

Author: IvanMurzak

Assets/_PackageRoot/Runtime/Future/CancelComponent/ComponentCancelOn.cs

@@ -0,0 +1,72 @@
+using System;
+using UnityEngine;
+
+namespace Extensions.Unity.ImageLoader
+{
+    public abstract class ComponentTrigger : MonoBehaviour
+    {
+        // protected WeakAction onTrigger = new WeakAction();
+        protected event Action onTrigger;
+        protected bool isTriggered;
+
+        protected void Trigger()
+        {
+            isTriggered = true;
+            onTrigger?.Invoke();
+            onTrigger = null;
+        }
+        public void RegisterCancel<T>(IFuture<T> future)
+        {
+            if (future.Status == FutureStatus.Disposed || future.IsCompleted)
+                return; // ignore completed futures
+
+            if (isTriggered)
+            {
+                future.Cancel();
+                return;
+            }
+
+            // TODO: check if future is completed during the onTrigger event
+            // onTrigger += future.Cancel;
+            // -------------------------------------------------------------
+            var weakFuture = new WeakReference<IFuture<T>>(future);
+            onTrigger += () =>
+            {
+                if (weakFuture.TryGetTarget(out var target))
+                {
+                    if (future.Status == FutureStatus.Disposed || target.IsCompleted)
+                        return; // ignore completed futures
+
+                    target.Cancel();
+                }
+            };
+        }
+
+        public void RegisterDispose<T>(Reference<T> reference)
+        {
+            if (reference.IsDisposed)
+                return; // ignore disposed references
+
+            if (isTriggered)
+            {
+                reference.Dispose();
+                return;
+            }
+
+            // TODO: check if reference is disposed during the onTrigger event
+            // onTrigger += reference.Dispose;
+            // -------------------------------------------------------------
+            var weakReference = new WeakReference<Reference<T>>(reference);
+            onTrigger += () =>
+            {
+                if (weakReference.TryGetTarget(out var target))
+                {
+                    if (target.IsDisposed)
+                        return; // ignore disposed references
+
+                    target.Dispose();
+                }
+            };
+        }
+    }
+}

Assets/_PackageRoot/Runtime/Future/CancelComponent/ComponentTrigger.cs

@@ -1,6 +1,6 @@
 namespace Extensions.Unity.ImageLoader
 {
-    internal class ComponentCancelOnDestroy : ComponentCancelOn
+    internal class ComponentTriggerOnDestroy : ComponentTrigger
     {
         private void OnDestroy() => Trigger();
     }

…ancelComponent/ComponentCancelOn.cs.meta …CancelComponent/ComponentTrigger.cs.metaAssets/_PackageRoot/Runtime/Future/CancelComponent/ComponentCancelOn.cs.meta renamed to Assets/_PackageRoot/Runtime/Future/CancelComponent/ComponentTrigger.cs.meta Assets/_PackageRoot/Runtime/Future/CancelComponent/ComponentCancelOn.cs.meta renamed to Assets/_PackageRoot/Runtime/Future/CancelComponent/ComponentTrigger.cs.meta

@@ -1,6 +1,6 @@
 namespace Extensions.Unity.ImageLoader
 {
-    internal class ComponentCancelOnDisable : ComponentCancelOn
+    internal class ComponentTriggerOnDisable : ComponentTrigger
     {
         private void OnDisable() => Trigger();
     }

…celComponent/ComponentCancelOnDestroy.cs …elComponent/ComponentTriggerOnDestroy.csAssets/_PackageRoot/Runtime/Future/CancelComponent/ComponentCancelOnDestroy.cs renamed to Assets/_PackageRoot/Runtime/Future/CancelComponent/ComponentTriggerOnDestroy.cs Assets/_PackageRoot/Runtime/Future/CancelComponent/ComponentCancelOnDestroy.cs renamed to Assets/_PackageRoot/Runtime/Future/CancelComponent/ComponentTriggerOnDestroy.cs

@@ -1,6 +1,6 @@
 namespace Extensions.Unity.ImageLoader
 {
-    internal class ComponentCancelOnEnable : ComponentCancelOn
+    internal class ComponentTriggerOnEnable : ComponentTrigger
     {
         private void OnEnable() => Trigger();
     }

…mponent/ComponentCancelOnDestroy.cs.meta …ponent/ComponentTriggerOnDestroy.cs.metaAssets/_PackageRoot/Runtime/Future/CancelComponent/ComponentCancelOnDestroy.cs.meta renamed to Assets/_PackageRoot/Runtime/Future/CancelComponent/ComponentTriggerOnDestroy.cs.meta Assets/_PackageRoot/Runtime/Future/CancelComponent/ComponentCancelOnDestroy.cs.meta renamed to Assets/_PackageRoot/Runtime/Future/CancelComponent/ComponentTriggerOnDestroy.cs.meta

@@ -164,14 +164,14 @@ public IFuture<T> Canceled(Action action)
             if (IsCancelled)
             {
                 if (LogLevel.IsActive(DebugLevel.Log))
-                    Debug.Log($"[ImageLoader] Future[id={Id}] Canceled\n{Url}");
+                    Debug.Log($"[ImageLoader] Future[id={Id}] Canceled. Status={Status}\n{Url}");
                 Safe.Run(action, LogLevel);
                 return this;
             }
             if (cleared)
             {
                 if (LogLevel.IsActive(DebugLevel.Warning))
-                    Debug.LogWarning($"[ImageLoader] Future[id={Id}] Canceled event is not set because Future is cleared\n{Url}");
+                    Debug.LogWarning($"[ImageLoader] Future[id={Id}] Canceled event is not set because Future is cleared. Status={Status}\n{Url}");
                 return this;
             }
             OnCanceled += action;
@@ -186,19 +186,19 @@ public virtual void Cancel()
             if (IsLoaded)
             {
                 if (LogLevel.IsActive(DebugLevel.Warning))
-                    Debug.LogWarning($"[ImageLoader] Future[id={Id}] Can't cancel. Task is already loaded\n{Url}");
+                    Debug.LogWarning($"[ImageLoader] Future[id={Id}] Can't cancel. Task is already loaded. Status={Status}\n{Url}");
                 return;
             }
             if (IsCancelled)
             {
                 if (LogLevel.IsActive(DebugLevel.Warning))
-                    Debug.LogWarning($"[ImageLoader] Future[id={Id}] Can't cancel. Task is already canceled\n{Url}");
+                    Debug.LogWarning($"[ImageLoader] Future[id={Id}] Can't cancel. Task is already canceled. Status={Status}\n{Url}");
                 return;
             }
             if (cleared)
             {
                 if (LogLevel.IsActive(DebugLevel.Warning))
-                    Debug.LogWarning($"[ImageLoader] Future[id={Id}] Can't cancel. Task is already cleared\n{Url}");
+                    Debug.LogWarning($"[ImageLoader] Future[id={Id}] Can't cancel. Task is already cleared. Status={Status}\n{Url}");
                 return;
             }
             if (LogLevel.IsActive(DebugLevel.Log))
@@ -224,18 +224,18 @@ public IFuture<Reference<T>> AsReference(DebugLevel logLevel = DebugLevel.Trace)
 
             LoadedFromMemoryCache(obj =>
             {
-                if (weakReference.TryGetTarget(out var reference))
-                    reference.Loaded(new Reference<T>(url, obj), FutureLoadedFrom.MemoryCache);
+                if (weakReference.TryGetTarget(out var future))
+                    future.Loaded(new Reference<T>(url, obj), FutureLoadedFrom.MemoryCache);
             });
             LoadingFromDiskCache(() =>
             {
-                if (weakReference.TryGetTarget(out var reference))
-                    reference.Loading(FutureLoadingFrom.DiskCache);
+                if (weakReference.TryGetTarget(out var future))
+                    future.Loading(FutureLoadingFrom.DiskCache);
             });
             LoadedFromDiskCache(obj =>
             {
-                if (weakReference.TryGetTarget(out var reference))
-                    reference.Loaded(new Reference<T>(url, obj), FutureLoadedFrom.DiskCache);
+                if (weakReference.TryGetTarget(out var future))
+                    future.Loaded(new Reference<T>(url, obj), FutureLoadedFrom.DiskCache);
             });
             LoadingFromSource(() =>
             {
@@ -244,18 +244,21 @@ public IFuture<Reference<T>> AsReference(DebugLevel logLevel = DebugLevel.Trace)
             });
             LoadedFromSource(obj =>
             {
-                if (weakReference.TryGetTarget(out var reference))
-                    reference.Loaded(new Reference<T>(url, obj), FutureLoadedFrom.Source);
+                if (weakReference.TryGetTarget(out var future))
+                    future.Loaded(new Reference<T>(url, obj), FutureLoadedFrom.Source);
             });
             Failed(e =>
             {
-                if (weakReference.TryGetTarget(out var reference))
-                    reference.FailToLoad(e);
+                if (weakReference.TryGetTarget(out var future))
+                    future.FailToLoad(e);
             });
             Canceled(() =>
             {
-                if (weakReference.TryGetTarget(out var reference))
-                    reference.Cancel();
+                if (weakReference.TryGetTarget(out var future))
+                {
+                    if (future.Status != FutureStatus.Disposed && !future.IsCompleted && !future.IsCancelled)
+                        future.Cancel();
+                }
             });
 
             // ┌─────────┬────────────────────────────────────────────────────────────────────────┐