(WIP) Native iOS text input #2602
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed lack of items in the context menu with NITI - Forwarded cursor / selection colors in TF1 / TF2 - Disabled Compose cursor in NITI mode in both TFs - Created expect / actual for the Compose text selection highlight in TF1, hidden it under NITI flag in uikit sourceset - Renamed UIKitTextContextMenuHandler.kt into more appropriate UIKitNativeTextInputContext - Created expect / actual for altering drawing selection rect on different platforms - fixed incorrect positioning of context menu - disabled back newContextMenu flag, rewrote showEditMenu logic in UIKitTextInputService.uikit.kt with using NITI toggle, created a signle entry point for context menu, removed some comments - context menu without NITI fixes + added existing obj-c files to the project which were forgotten to add during the merge - merge fixes after commit with refactoring InputViews.uikit.kt - Reverted pointerInput handling in TF1,2, reverted view hierarchy, hidden almost everything related to the NITI under the flag, added some TODOs with bad fixes - Added feature flag for NITI to platform ime options - added NITI tests screens to the example app - Forwarded custom actions to the IntermediateTextInputUIView.uikit.kt - Enabled native context menu, added public API for updating context menu state (foundation -> ui), extracted all UITextInput methods from objc file to separate class, temporarily disabled current context menu - Extracted UITextInput methods from CMPEditMenuView to CMPTextInputView, fixed NewContextMenuApi menu - (wip) commented CMPEditMenu methods calls after rebase with new context menu api on ios - (wip) turned on native selection rects (LTR only!) + fixed appearing of the text editing menu by tapping on the selection rects + more appropriate naming + fixed imports - (wip) disabled custom iOS tap handlers in TF1,2 - (wip) fixed native text views positioning in TF1 - (wip) disabled compose selection handles - (wip) fixed scroll positioning in BTF2 - (wip) fixed touch forwarding - (wip) fixed positioning of ScrollView and TextView issue - (wip) removed unnecessary comments - (wip) fixed sizing of TextScrollView and TextView - (wip) transfered changes from previous niti branch - (wip) rebase fixes
mazunin-v-jb
force-pushed
the
v.mazunin/native-ios-text-input
branch
from
dd397ec to
c0251cd
Compare
…, removed unnecessary method from IOSSkikoInput.uikit.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP