Add support for OffsetDateTime and fix tests.

Author: alshan

plot-api/src/commonTest/kotlin/org/jetbrains/letsPlot/intern/standardizing/StandardizingTest.kt

@@ -57,7 +57,7 @@ class StandardizingTest {
         val kLocalTime = KLocalTime(12, 30, 45)
         val kLocalDateTime = KLocalDateTime(2023, 1, 1, 12, 30, 45)
 
-        val values = listOf(
+        val values = listOf<Any>(
             kInstant,
             kLocalDate,
             kLocalTime,
@@ -66,16 +66,17 @@ class StandardizingTest {
 
         val expectedValues = values.map {
             when (it) {
-                is KLocalDate -> expectedLocalDateTimestamp.toDouble() // Same as ZonedDateTime because here we use UTC
-                is KLocalTime -> expectedLocalTimeTimestamp.toDouble() // Same as ZonedDateTime because here we use UTC
-                is KLocalDateTime -> expectedTimestamp.toDouble() // Same as ZonedDateTime because here we use UTC
-                else -> expectedTimestamp.toDouble()
-            }
+                is KLocalDate -> expectedLocalDateTimestamp
+                is KLocalTime -> expectedLocalTimeTimestamp
+                is KLocalDateTime -> expectedTimestamp      // Same as ZonedDateTime because here we use UTC
+                else -> expectedTimestamp
+            }.toDouble()
         } + StandardizingTestJvmValues.getExpectedValues()
 
 
-        val standardizedValues = SeriesStandardizing.toList(values + StandardizingTestJvmValues.getTestValues())
-        values.zip(expectedValues).zip(standardizedValues) { (a, b), c ->
+        val inputValues = values + StandardizingTestJvmValues.getTestValues()
+        val standardizedValues = SeriesStandardizing.toList(inputValues)
+        inputValues.zip(expectedValues).zip(standardizedValues) { (a, b), c ->
             Triple(a, b, c)
         }
             .forEach { (input, expected, result) ->
@@ -149,4 +150,5 @@ class StandardizingTest {
     }
 }
 
+@Suppress("unused")
 private enum class State { Idle, Working }

plot-api/src/commonTest/kotlin/org/jetbrains/letsPlot/intern/standardizing/StandardizingTestJvmValues.kt

@@ -6,7 +6,6 @@
 package org.jetbrains.letsPlot.intern.standardizing
 
 expect object StandardizingTestJvmValues {
-    fun getTestValues(): List<Any?>
-    fun getExpectedValues(): List<Any?>
-
+    fun getTestValues(): List<Any>
+    fun getExpectedValues(): List<Any>
 }

plot-api/src/jsTest/kotlin/org/jetbrains/letsPlot/intern/standardizing/StandardizingTestJvmValues.kt

@@ -6,7 +6,6 @@
 package org.jetbrains.letsPlot.intern.standardizing
 
 actual object StandardizingTestJvmValues {
-    actual fun getTestValues(): List<Any?> = emptyList()
-    actual fun getExpectedValues(): List<Any?> = emptyList()
-
+    actual fun getTestValues(): List<Any> = emptyList()
+    actual fun getExpectedValues(): List<Any> = emptyList()
 }

plot-api/src/jvmMain/kotlin/org/jetbrains/letsPlot/intern/standardizing/JvmStandardizing.kt

@@ -21,6 +21,7 @@ actual object JvmStandardizing {
             is Date -> true
             is Instant -> true
             is ZonedDateTime -> true
+            is OffsetDateTime -> true
             is LocalDate -> true
             is LocalTime -> true
             is LocalDateTime -> true
@@ -47,6 +48,7 @@ actual object JvmStandardizing {
             is Date -> o.time.toDouble()
             is Instant -> o.toEpochMilli().toDouble()
             is ZonedDateTime -> o.toInstant().toEpochMilli().toDouble()
+            is OffsetDateTime -> o.toInstant().toEpochMilli().toDouble()
             is LocalDate -> o.atStartOfDay(ZoneOffset.UTC).toInstant().toEpochMilli().toDouble()
             is LocalTime -> LocalDateTime.of(LocalDate.EPOCH, o).toInstant(ZoneOffset.UTC).toEpochMilli().toDouble()
             is LocalDateTime -> o.toInstant(ZoneOffset.UTC).toEpochMilli().toDouble()

plot-api/src/jvmTest/kotlin/org/jetbrains/letsPlot/intern/standardizing/StandardizingTestJvmValues.kt

@@ -9,13 +9,14 @@ import java.time.*
 import java.util.*
 
 actual object StandardizingTestJvmValues {
-    actual fun getTestValues(): List<Any?> {
+    actual fun getTestValues(): List<Any> {
         val zonedDateTime = ZonedDateTime.of(2023, 1, 1, 12, 30, 45, 0, ZoneId.of("UTC"))
         val instant = zonedDateTime.toInstant()
         val localDate = zonedDateTime.toLocalDate()
         val localTime = zonedDateTime.toLocalTime()
         val localDateTime = zonedDateTime.toLocalDateTime()
         val date = Date.from(instant)
+        val offsetDateTime: OffsetDateTime = zonedDateTime.toOffsetDateTime()
 
         return listOf(
             zonedDateTime,
@@ -24,10 +25,11 @@ actual object StandardizingTestJvmValues {
             localTime,
             localDateTime,
             date,
+            offsetDateTime,
         )
     }
 
-    actual fun getExpectedValues(): List<Any?> {
+    actual fun getExpectedValues(): List<Any> {
         // Expected timestamp for 2023-01-01T12:30:45Z
         val expectedTimestamp = 1672576245000L
 
@@ -43,7 +45,7 @@ actual object StandardizingTestJvmValues {
                 is LocalTime -> expectedLocalTimeTimestamp
                 is LocalDateTime -> expectedTimestamp // Same as ZonedDateTime because here we use UTC
                 else -> expectedTimestamp
-            }
+            }.toDouble()
         }
     }
 }