refactor: added tour & bookmark exception (#53)

Author: 2SEONGA

tour/src/main/java/com/jocketdan/tour/exception/CommonExceptionHandler.java

@@ -0,0 +1,45 @@
+package com.jocketdan.tour.exception;
+
+import jakarta.servlet.http.HttpServletRequest;
+import java.time.LocalDateTime;
+import lombok.extern.slf4j.Slf4j;
+import org.springframework.http.HttpStatus;
+import org.springframework.http.ResponseEntity;
+import org.springframework.web.bind.annotation.ExceptionHandler;
+import org.springframework.web.bind.annotation.RestControllerAdvice;
+
+@Slf4j
+@RestControllerAdvice
+public class CommonExceptionHandler {
+
+    @ExceptionHandler(CustomException.class)
+    public ResponseEntity<ErrorDetail> handler(HttpServletRequest request, CustomException e) {
+        ExceptionType type = e.getType();
+        HttpStatus status = type.getStatus();
+
+        ErrorDetail detail = ErrorDetail.builder()
+                .errorCode(type.getCustomCode())
+                .errorMessage(e.getMessage())
+                .path(request.getRequestURI())
+                .status(status.value())
+                .timestamp(LocalDateTime.now())
+                .build();
+
+        return ResponseEntity.status(status).body(detail);
+    }
+
+    @ExceptionHandler(Exception.class)
+    public ResponseEntity<ErrorDetail> handler(HttpServletRequest request, Exception e) {
+        HttpStatus status = HttpStatus.INTERNAL_SERVER_ERROR;
+
+        ErrorDetail detail = ErrorDetail.builder()
+                .errorCode("999")
+                .errorMessage(e.getMessage())
+                .path(request.getRequestURI())
+                .status(status.value())
+                .timestamp(LocalDateTime.now())
+                .build();
+
+        return ResponseEntity.status(status).body(detail);
+    }
+}

tour/src/main/java/com/jocketdan/tour/exception/CustomException.java

@@ -0,0 +1,13 @@
+package com.jocketdan.tour.exception;
+
+import lombok.Getter;
+
+@Getter
+public class CustomException extends RuntimeException {
+    private final ExceptionType type;
+
+    public CustomException(ExceptionType type) {
+        super(type.getMessage());
+        this.type = type;
+    }
+}

tour/src/main/java/com/jocketdan/tour/exception/ErrorDetail.java

@@ -0,0 +1,21 @@
+package com.jocketdan.tour.exception;
+
+import java.time.LocalDateTime;
+import lombok.AccessLevel;
+import lombok.Builder;
+import lombok.Getter;
+import lombok.RequiredArgsConstructor;
+import lombok.experimental.FieldDefaults;
+
+@Builder
+@Getter
+@RequiredArgsConstructor
+@FieldDefaults(makeFinal = true, level = AccessLevel.PRIVATE)
+public class ErrorDetail {
+
+    String errorCode;
+    String errorMessage;
+    String path;
+    Integer status;
+    LocalDateTime timestamp;
+}

tour/src/main/java/com/jocketdan/tour/exception/ExceptionType.java

@@ -0,0 +1,23 @@
+package com.jocketdan.tour.exception;
+
+import lombok.AccessLevel;
+import lombok.Getter;
+import lombok.RequiredArgsConstructor;
+import lombok.experimental.FieldDefaults;
+import org.springframework.http.HttpStatus;
+
+@FieldDefaults(makeFinal = true, level = AccessLevel.PRIVATE)
+@Getter
+@RequiredArgsConstructor
+public enum ExceptionType {
+
+    ALREADY_EXITED_BOOKMARK(HttpStatus.CONFLICT, "300", "이미 북마크에 추가된 장소입니다."),
+    BOOKMARK_NOT_FOUND(HttpStatus.NOT_FOUND, "301", "삭제할 북마크가 없습니다."),
+    CANNOT_PARSE_ID(HttpStatus.INTERNAL_SERVER_ERROR, "303", "컨텐츠 타입 형변환 실패입니다."),
+
+    PLACE_NOT_FOUND(HttpStatus.CONFLICT, "351", "존재하지 않는 장소입니다.");
+
+    HttpStatus status;
+    String customCode;
+    String message;
+}

tour/src/main/java/com/jocketdan/tour/service/BookmarkService.java

@@ -4,17 +4,21 @@
 import com.jocketdan.tour.entity.Bookmark;
 import com.jocketdan.tour.entity.BookmarkType;
 import com.jocketdan.tour.entity.OpenApiPlaceDetail;
+import com.jocketdan.tour.exception.CustomException;
+import com.jocketdan.tour.exception.ExceptionType;
 import com.jocketdan.tour.repository.BookmarkRepository;
 import lombok.AccessLevel;
 import lombok.RequiredArgsConstructor;
 import lombok.experimental.FieldDefaults;
+import lombok.extern.slf4j.Slf4j;
 import org.springframework.data.domain.Page;
 import org.springframework.data.domain.Pageable;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 
 import java.util.List;
 
+@Slf4j
 @Service
 @RequiredArgsConstructor
 @FieldDefaults(makeFinal = true, level = AccessLevel.PRIVATE)
@@ -28,7 +32,7 @@ public void addBookmark(String contentId, String userEmail) {
         OpenApiPlaceDetail place = tourOpenApiService.getOrFetchPlaceDetail(contentId);
 
         if (bookmarkRepository.existsByUserEmailAndContentId(userEmail, place)) {
-            throw new IllegalStateException("이미 북마크에 추가된 장소입니다.");
+            throw new CustomException(ExceptionType.ALREADY_EXITED_BOOKMARK);
         }
 
         Integer contentTypeId = parseContentTypeId(place.getContentTypeId());
@@ -40,7 +44,7 @@ public void addBookmark(String contentId, String userEmail) {
     public void removeBookmark(List<String> contentIds, String userEmail) {
         List<Bookmark> bookmarks = bookmarkRepository.findByUserEmailAndContentId_ContentIdIn(userEmail, contentIds);
         if (bookmarks.isEmpty()) {
-            throw new IllegalArgumentException("삭제할 북마크가 없습니다.");
+            throw new CustomException(ExceptionType.BOOKMARK_NOT_FOUND);
         }
         bookmarkRepository.deleteAllInBatch(bookmarks);
     }
@@ -60,8 +64,8 @@ private Integer parseContentTypeId(String contentTypeId) {
         try {
             return Integer.parseInt(contentTypeId);
         } catch (NumberFormatException e) {
-            throw new IllegalStateException(
-                    "유효하지 않은 contentTypeId: " + contentTypeId, e);
+            log.warn("parseContentTypeId ContentTypeId = {}", contentTypeId);
+            throw new CustomException(ExceptionType.CANNOT_PARSE_ID);
         }
     }
 }

tour/src/main/java/com/jocketdan/tour/service/TourOpenApiService.java

@@ -2,17 +2,21 @@
 
 import com.jocketdan.tour.dto.openApi.*;
 import com.jocketdan.tour.entity.OpenApiPlaceDetail;
+import com.jocketdan.tour.exception.CustomException;
+import com.jocketdan.tour.exception.ExceptionType;
 import com.jocketdan.tour.repository.OpenApiPlaceDetailRepository;
 import jakarta.persistence.EntityNotFoundException;
 import lombok.AccessLevel;
 import lombok.RequiredArgsConstructor;
 import lombok.experimental.FieldDefaults;
+import lombok.extern.slf4j.Slf4j;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 
 import java.util.Map;
 import java.util.Objects;
 
+@Slf4j
 @Service
 @RequiredArgsConstructor
 @FieldDefaults(makeFinal = true, level = AccessLevel.PRIVATE)
@@ -146,7 +150,8 @@ private void validateApiResponse(DetailsResponseDTO response, String contentId)
                 || response.getResponse().getBody() == null
                 || response.getResponse().getBody().getItems() == null
                 || response.getResponse().getBody().getItems().getItem().isEmpty()) {
-            throw new EntityNotFoundException("존재하지 않는 장소입니다: " + contentId);
+            log.warn("validateApiResponse ContentId = {}", contentId);
+            throw new CustomException(ExceptionType.PLACE_NOT_FOUND);
         }
     }