Use Aqua to ensure project quality (#812)

Author: jishnub

Project.toml

@@ -24,6 +24,7 @@ ApproxFunBase = "0.6"
 ApproxFunFourier = "0.3"
 ApproxFunOrthogonalPolynomials = "0.5"
 ApproxFunSingularities = "0.3"
+Aqua = "0.5"
 Calculus = "0.5"
 DomainSets = "0.3, 0.4, 0.5"
 DualNumbers = "0.6.2"
@@ -35,9 +36,10 @@ SpecialFunctions = "1.1, 2"
 julia = "1.6"
 
 [extras]
+Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4"
 Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [targets]
-test = ["Documenter", "Test", "Random"]
+test = ["Aqua", "Documenter", "Test", "Random"]

README.md

@@ -7,6 +7,7 @@
 [![codecov](https://codecov.io/gh/JuliaApproximation/ApproxFun.jl/branch/master/graph/badge.svg)](https://codecov.io/gh/JuliaApproximation/ApproxFun.jl)
 [![deps](https://juliahub.com/docs/ApproxFun/deps.svg)](https://juliahub.com/ui/Packages/ApproxFun/jGqLz?t=2)
 [![version](https://juliahub.com/docs/ApproxFun/version.svg)](https://juliahub.com/ui/Packages/ApproxFun/jGqLz)
+[![Aqua QA](https://raw.githubusercontent.com/JuliaTesting/Aqua.jl/master/badge.svg)](https://github.com/JuliaTesting/Aqua.jl)
 [![Join the chat at https://gitter.im/JuliaApproximation/ApproxFun.jl](https://badges.gitter.im/JuliaApproximation/ApproxFun.jl.svg)](https://gitter.im/JuliaApproximation/ApproxFun.jl?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 
 

src/Extras/dualnumbers.jl

@@ -36,7 +36,7 @@ plan_ichebyshevtransform(v::AbstractVector{D}, ::Val{kind}) where {D<:Dual,kind}
 
 
 
-*(P::ChebyshevTransformPlan,v::AbstractVector{D}) where {k,D<:Dual} = dual.(P*realpart.(v),P*dualpart.(v))
+*(P::ChebyshevTransformPlan,v::AbstractVector{<:Dual}) = dual.(P*realpart.(v),P*dualpart.(v))
 
 #TODO: Hardy{false}
 for (OP,TransPlan) in ((:plan_transform,:TransformPlan),(:plan_itransform,:ITransformPlan)),

test/runtests.jl

@@ -1,17 +1,22 @@
 using ApproxFun, Random, Test
 import ApproxFunBase: testbandedblockbandedoperator, blocklengths, ∞
 
+using Aqua
+@testset "Project quality" begin
+    Aqua.test_all(ApproxFun, ambiguities=false, undefined_exports=false)
+end
+
 using Documenter
 DocMeta.setdocmeta!(ApproxFun, :DocTestSetup, :(using ApproxFun); recursive=true)
 
 @testset "doctests" begin
     doctest(ApproxFun, manual = false)
 end
 
-@time include("ReadmeTest.jl")
-@time include("ExtrasTest.jl")
-@time include("NumberTypeTest.jl")
-@time include("FractionalTest.jl")
+include("ReadmeTest.jl")
+include("ExtrasTest.jl")
+include("NumberTypeTest.jl")
+include("FractionalTest.jl")
 
 @testset "Chebyshev and Fourier" begin
     @test norm(Fun(x->Fun(cos,Fourier(-π .. π),20)(x),20)-Fun(cos,20)) <100eps()