LowRankOperator: change vector convert to map over eltype (#438)

* LowRankOperator: change vector convert to map over eltype

* remove unused constructor

Author: jishnub

src/Operators/almostbanded/LowRankOperator.jl

@@ -32,15 +32,14 @@ function LowRankOperator(U::Vector{VFun{S,T1}}, V::Vector{<:Operator}) where {S,
     LowRankOperator(strictconvert(Vector{VFun{S,T}},U), map(Operator{T}, V))
 end
 
+LowRankOperator(A::Fun, B::Operator) = LowRankOperator([A], [B])
 
-LowRankOperator(B::AbstractVector,S...) = LowRankOperator(strictconvert(Vector{Operator{Float64}},B),S...)
 
-LowRankOperator(A::Fun,B::Operator) = LowRankOperator([A],[B])
-
-
-convert(::Type{Operator{T}},L::LowRankOperator{S}) where {S,T} =
+function convert(::Type{Operator{T}},L::LowRankOperator{S}) where {S,T}
+    L isa Operator{T} && return L
     LowRankOperator{S,T}(strictconvert(Vector{VFun{S,T}},L.U),
-                         strictconvert(Vector{Operator{T}},L.V))
+                         map(Operator{T}, L.V))
+end
 
 
 datasize(L::LowRankOperator,k) =
@@ -55,9 +54,9 @@ promotedomainspace(L::LowRankOperator,sp::Space) = LowRankOperator(L.U,map(v->pr
 
 function Base.getindex(L::LowRankOperator, k::Integer,j::Integer)
     ret=zero(eltype(L))
-    for p in eachindex(L.U)
-        if k ≤ ncoefficients(L.U[p])
-            ret += coefficient(L.U[p], k) * L.V[p][j]
+    for (p, LUp) in enumerate(L.U)
+        if k ≤ ncoefficients(LUp)
+            ret += coefficient(LUp, k) * L.V[p][j]
         end
     end
     ret