fix incorrect transpose

Author: MikaelSlevinsky

src/SphericalHarmonics/vectorfield.jl

@@ -106,8 +106,8 @@ if VERSION < v"0.7-"
 
     Base.Ac_mul_B!(Y1::Matrix, Y2::Matrix, SP::SlowSphericalHarmonicPlan, X1::Matrix, X2::Matrix) = At_mul_B!(Y1, Y2, SP, X1, X2)
 else
-    function LinearAlgebra.mul!(Y1::Matrix, Y2t::Transpose{T,Matrix{T}}, SP::SlowSphericalHarmonicPlan, X1::Matrix, X2::Matrix) where T
-        Y2 = parent(Y2t)
+    function LinearAlgebra.mul!(Y1::Matrix, Y2::Matrix, SPt::Transpose{Any,SlowSphericalHarmonicPlan{T}}, X1::Matrix, X2::Matrix) where T
+        SP = parent(SPt)
         RP, p1inv, p2inv, B = SP.RP, SP.p1inv, SP.p2inv, SP.B
         copyto!(B, X1)
         M, N = size(X1)
@@ -136,8 +136,8 @@ else
         Y1
     end
 
-    LinearAlgebra.mul!(Y1::Matrix, Y2::Adjoint{T,Matrix{T}}, SP::SlowSphericalHarmonicPlan, X1::Matrix, X2::Matrix) where T =
-        At_mul_B!(Y1, Y2, SP, X1, X2)
+    LinearAlgebra.mul!(Y1::Matrix, Y2::Matrix, SP::Adjoint{Any,SlowSphericalHarmonicPlan{T}}, X1::Matrix, X2::Matrix) where T =
+        At_mul_B!(Y1, Y2, transpose(parent(SP)), X1, X2)
 end
 
 

test/sphericalharmonics/vectorfieldtests.jl

@@ -36,7 +36,7 @@ if VERSION < v"0.7-"
 
         @test vecnorm(∇θF - G1)/vecnorm(∇θF) < n*eps()
         @test vecnorm(∇φF - G2)/vecnorm(∇φF) < n*eps()
-        
+
         y = (1.0, 2.0, 3.0)
         for k in (10, 20, 40)
             ∇θf = (θ,φ) -> -2k*sin(k*((sinpi(θ)*cospi(φ) - y[1])^2 + (sinpi(θ)*sinpi(φ) - y[2])^2 + (cospi(θ) - y[3])^2))*( (sinpi(θ)*cospi(φ) - y[1])*(cospi(θ)*cospi(φ)) + (sinpi(θ)*sinpi(φ) - y[2])*(cospi(θ)*sinpi(φ)) - (cospi(θ) - y[3])*sinpi(θ) )
@@ -92,7 +92,7 @@ else
 
         U1 = zero(V1)
         U2 = zero(V2)
-        mul!(U1, transpose(U2), P, V1, V2)
+        mul!(U1, U2, transpose(P), V1, V2)
 
         W1 = zero(U1)
         W2 = zero(U2)
@@ -127,7 +127,7 @@ else
 
             U1 = zero(V1)
             U2 = zero(V2)
-            FastTransforms.mul!(U1, transpose(U2), P, V1, V2)
+            FastTransforms.mul!(U1, U2, transpose(P), V1, V2)
 
             W1 = zero(U1)
             W2 = zero(U2)