Skip to content

Commit 32c261d

Browse files
committed
cleanup
1 parent f70453c commit 32c261d

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

src/regularized/abstract_regularized.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ Return the associated optimizer.
5151
function get_maximizer end
5252

5353
@required AbstractRegularized begin
54-
#(regularized::AbstractRegularized)(θ::AbstractArray; kwargs...)
54+
# (regularized::AbstractRegularized)(θ::AbstractArray; kwargs...) # waiting for RequiredInterfaces to support this (see https://github.com/Seelengrab/RequiredInterfaces.jl/issues/11)
5555
compute_regularization(::AbstractRegularized, ::AbstractArray)
5656
end
5757

src/utils/generalized_maximizer.jl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ It is compatible with the following layers
77
- [`PerturbedMultiplicative`](@ref) (with or without [`FenchelYoungLoss`](@ref))
88
- [`SPOPlusLoss`](@ref)
99
"""
10-
# TODO: find better names for GeneralizedMaximizer, g, and h ?
1110
struct GeneralizedMaximizer{F,G,H}
1211
maximizer::F
1312
g::G
@@ -31,7 +30,6 @@ end
3130
3231
Computes the objective value of given GeneralizedMaximizer `f`, knowing weights `θ` and solution `y`.
3332
"""
34-
# TODO: maybe find a better function name
3533
function objective_value(f::GeneralizedMaximizer, θ, y; kwargs...)
3634
return dot(θ, f.g(y; kwargs...)) .+ f.h(y; kwargs...)
3735
end

0 commit comments

Comments
 (0)