Add Neighbor Discovery Protocol ICMPv6 packets

[Dominaezzz]

I want to extend the Icmpv6Type with NDP packets like so:

pub enum Icmpv6Type {
    // ...

    RouterSolicitation,
    RouterAdvertisement(...),
    NeighborSolicitation,
    NeighborAdvertisement(...),
    Redirect,
}

Is this something you'd be interested in or would you rather Icmpv6Type::Unknown be used for this?
This would be a breaking change too, might be worth considering using #[non_exhaustive].

Assuming yes, do you any preferences for how this is done? A struct for every type perhaps? Or add any extra data to the enum entry itself?

[JulianSchmid]

Hi @Dominaezzz ,

The extension of the Icmpv6Type was just implemented & released as part of https://github.com/JulianSchmid/etherparse/releases/tag/v0.19.0 . I decided against marking the enum with #[non_exhaustive] and instead released a new major version.

Have a look if this is what you had in mind. If not please open a new issue.

@thomaseizinger added NeighborSolicitation & NeighborAdvertisement with #129 and I added RouterSolicitation, RouterAdvertisement & Redirect with #130 .

It does currently not contain the complete parsing & writing of the complete packets (everything after the header bytes is missing, see https://docs.rs/etherparse/0.19.0/etherparse/enum.Icmpv6Type.html#variant.RouterSolicitation ). I think it would be worth to add that in the future. But I did not have the time for that & would have to spend some time thinking about how to do that best. Maybe in the future.

Greets
Julian

[Dominaezzz]

Awesome, thanks! It's exactly what I had in mind