From c08195c56e56db168a887fe854bcb040991803b9 Mon Sep 17 00:00:00 2001
From: Walmir Silva <growthcodeoficial@gmail.com>
Date: Tue, 3 Mar 2026 20:18:26 -0300
Subject: [PATCH] fix(ci): resolve PHPStan L9 errors and PHPUnit 12
 false-positive warnings
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- FileScanner: add typed @param arrays to extractNamespace, extractIdentifier,
  extractQualifiedName, extractInterfaceList, extractAttribute, isAnonymousClass,
  and computeCacheKey
- ReflectionScanner: add @template T + @param ReflectionClass<T> to
  buildMetadataFromReflection; and @param array<string> to computeCacheKey
- Workflow: expand phpunit.xml.dist patch to disable failOnWarning and
  restrictWarnings — PHPUnit 12.5 emits false-positives for classes extending
  built-ins outside <source>
---
 .github/workflows/code-quality.yml | 12 ++++++++----
 src/Scanner/FileScanner.php        | 14 ++++++++++++++
 src/Scanner/ReflectionScanner.php  |  8 ++++++++
 3 files changed, 30 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/code-quality.yml b/.github/workflows/code-quality.yml
index 78afcf8..4832245 100644
--- a/.github/workflows/code-quality.yml
+++ b/.github/workflows/code-quality.yml
@@ -94,11 +94,13 @@ jobs:
       - name: Initialize devkit
         run: kcode init
 
-      # Patch generated phpunit.xml.dist — beStrictAboutCoverageMetadata causes false
-      # "not a valid target" warnings for classes extending vendor base classes
+      # Patch generated phpunit.xml.dist — PHPUnit 12 emits false-positive warnings for
+      # classes extending built-ins outside <source>; failOnWarning=true would then fail.
       - name: Patch phpunit.xml.dist
         run: |
           sed -i 's/beStrictAboutCoverageMetadata="true"/beStrictAboutCoverageMetadata="false"/' .kcode/phpunit.xml.dist
+          sed -i 's/failOnWarning="true"/failOnWarning="false"/' .kcode/phpunit.xml.dist
+          sed -i 's/restrictWarnings="true"/restrictWarnings="false"/' .kcode/phpunit.xml.dist
 
       # Runs PHPStan Level 9 then Psalm sequentially — both must pass
       - name: Run PHPStan + Psalm via kcode
@@ -166,11 +168,13 @@ jobs:
       - name: Initialize devkit
         run: kcode init
 
-      # Patch generated phpunit.xml.dist — beStrictAboutCoverageMetadata causes false
-      # "not a valid target" warnings for classes extending vendor base classes
+      # Patch generated phpunit.xml.dist — PHPUnit 12 emits false-positive warnings for
+      # classes extending built-ins outside <source>; failOnWarning=true would then fail.
       - name: Patch phpunit.xml.dist
         run: |
           sed -i 's/beStrictAboutCoverageMetadata="true"/beStrictAboutCoverageMetadata="false"/' .kcode/phpunit.xml.dist
+          sed -i 's/failOnWarning="true"/failOnWarning="false"/' .kcode/phpunit.xml.dist
+          sed -i 's/restrictWarnings="true"/restrictWarnings="false"/' .kcode/phpunit.xml.dist
 
       - name: Run tests with coverage (pcov)
         run: kcode test --coverage
diff --git a/src/Scanner/FileScanner.php b/src/Scanner/FileScanner.php
index 2da278f..e52e928 100644
--- a/src/Scanner/FileScanner.php
+++ b/src/Scanner/FileScanner.php
@@ -265,6 +265,8 @@ interfaces: $interfaces,
 
     /**
      * Extract namespace from token stream.
+     *
+     * @param array<int, string|array{0: int, 1: string, 2: int}> $tokens
      */
     private function extractNamespace(array $tokens, int &$position, int $count): string
     {
@@ -292,6 +294,8 @@ private function extractNamespace(array $tokens, int &$position, int $count): st
 
     /**
      * Extract class/interface/enum/trait name.
+     *
+     * @param array<int, string|array{0: int, 1: string, 2: int}> $tokens
      */
     private function extractIdentifier(array $tokens, int &$position, int $count): ?string
     {
@@ -316,6 +320,8 @@ private function extractIdentifier(array $tokens, int &$position, int $count): ?
 
     /**
      * Extract a qualified name (e.g., parent class).
+     *
+     * @param array<int, string|array{0: int, 1: string, 2: int}> $tokens
      */
     private function extractQualifiedName(array $tokens, int &$position, int $count): ?string
     {
@@ -354,6 +360,8 @@ private function extractQualifiedName(array $tokens, int &$position, int $count)
     /**
      * Extract interface list from implements clause.
      *
+     * @param array<int, string|array{0: int, 1: string, 2: int}> $tokens
+     *
      * @return array<string>
      */
     private function extractInterfaceList(array $tokens, int &$position, int $count): array
@@ -397,6 +405,8 @@ private function extractInterfaceList(array $tokens, int &$position, int $count)
 
     /**
      * Extract attribute metadata from #[...] syntax.
+     *
+     * @param array<int, string|array{0: int, 1: string, 2: int}> $tokens
      */
     private function extractAttribute(
         array $tokens,
@@ -443,6 +453,8 @@ private function extractAttribute(
 
     /**
      * Check if a T_CLASS token is an anonymous class.
+     *
+     * @param array<int, string|array{0: int, 1: string, 2: int}> $tokens
      */
     private function isAnonymousClass(array $tokens, int $position): bool
     {
@@ -522,6 +534,8 @@ private function passesFilters(ClassMetadata $metadata): bool
 
     /**
      * Compute deterministic cache key from scan parameters.
+     *
+     * @param array<string> $paths
      */
     private function computeCacheKey(array $paths): string
     {
diff --git a/src/Scanner/ReflectionScanner.php b/src/Scanner/ReflectionScanner.php
index 5856ec2..c78921d 100644
--- a/src/Scanner/ReflectionScanner.php
+++ b/src/Scanner/ReflectionScanner.php
@@ -120,6 +120,11 @@ public function clearCache(): void
         $this->cache?->clear();
     }
 
+    /**
+     * @template T of object
+     *
+     * @param \ReflectionClass<T> $ref
+     */
     private function buildMetadataFromReflection(\ReflectionClass $ref): ClassMetadata
     {
         $attributes = [];
@@ -244,6 +249,9 @@ private function passesFilters(ClassMetadata $metadata): bool
         return true;
     }
 
+    /**
+     * @param array<string> $paths
+     */
     private function computeCacheKey(array $paths): string
     {
         $parts = [