fixes, close off leaks, tests

all tests except file, server, and exchange

Author: Katsute

src/main/java/dev/katsute/simplehttpserver/HttpSessionHandler.java

@@ -77,7 +77,7 @@ private String getSetSession(final Headers headers){ // get session that will be
         if(headers.containsKey("Set-Cookie"))
            for(final String value : headers.get("Set-Cookie"))
                if(value.startsWith(cookie + "="))
-                   return value.substring(cookie.length() + 1, value.indexOf(";"));
+                   return value.substring(cookie.length() + 1, value.contains(";") ? value.indexOf(";") : value.length());
        return null;
     }
 
@@ -147,7 +147,6 @@ public synchronized final void update(){
                 };
 
                 final HttpCookie OUT = new HttpCookie(cookie, session.getSessionID());
-                OUT.setPath("/");
                 OUT.setHttpOnly(true);
 
                 exchange.getResponseHeaders().add("Set-Cookie", OUT.toString());

src/main/java/dev/katsute/simplehttpserver/SimpleHttpExchangeImpl.java

@@ -79,9 +79,11 @@ private static Map<String,String> parseWwwFormEnc(final String s){
         getMap = rawGet == null ? new HashMap<>() : parseWwwFormEnc(rawGet);
 
         String OUT;
-        try(final Stream<String> lns = new BufferedReader(new InputStreamReader(exchange.getRequestBody(), StandardCharsets.UTF_8)).lines()){
-            OUT = lns.collect(Collectors.joining("\n"));
-        }catch(Throwable e){
+        try(final InputStreamReader IN = new InputStreamReader(exchange.getRequestBody(), StandardCharsets.UTF_8)){
+            try(final Stream<String> lns = new BufferedReader(IN).lines()){
+                OUT = lns.collect(Collectors.joining("\n"));
+            }
+        }catch(final Throwable e){
             OUT = null;
         }
 

src/test/java/dev/katsute/simplehttpserver/Requests.java

@@ -1,12 +1,15 @@
 package dev.katsute.simplehttpserver;
 
 import java.io.*;
-import java.net.HttpURLConnection;
-import java.net.URL;
+import java.net.*;
 import java.nio.charset.StandardCharsets;
 
 public class Requests {
 
+    static{
+        CookieHandler.setDefault(new CookieManager());
+    }
+
     public static HttpURLConnection openConn(final String URL){
         try{
             final HttpURLConnection conn = (HttpURLConnection) new URL(URL).openConnection();
@@ -27,19 +30,28 @@ public static int getCode(final String URL){
     }
 
     public static String getBody(final String URL){
-        return getBody(openConn(URL));
+        return getBody(openConn(URL), false);
+    }
+
+    public static String getBody(final String URL, final boolean ignoreError){
+        return getBody(openConn(URL), ignoreError);
     }
 
     public static String getBody(final HttpURLConnection conn){
+        return getBody(conn, false);
+    }
+
+    public static String getBody(final HttpURLConnection conn, final boolean ignoreError){
+        final StringBuilder OUT = new StringBuilder();
         try(final BufferedReader IN = new BufferedReader(new InputStreamReader(conn.getInputStream(), StandardCharsets.UTF_8))){
             String buffer;
-            final StringBuilder OUT = new StringBuilder();
             while((buffer = IN.readLine()) != null)
-                OUT.append(buffer);
-            return OUT.toString();
+                OUT.append(buffer).append('\n');
         }catch(final IOException e){
-            throw new UncheckedIOException(e);
+            if(!ignoreError)
+                throw new UncheckedIOException(e);
         }
+        return OUT.toString().trim();
     }
 
 }

src/test/java/dev/katsute/simplehttpserver/handler/SSETests.java

@@ -0,0 +1,44 @@
+package dev.katsute.simplehttpserver.handler;
+
+import dev.katsute.simplehttpserver.Requests;
+import dev.katsute.simplehttpserver.SimpleHttpServer;
+import org.junit.jupiter.api.*;
+
+import java.io.IOException;
+import java.util.concurrent.atomic.AtomicReference;
+
+final  class SSETests {
+
+    private static SimpleHttpServer server;
+
+    @BeforeAll
+    static void beforeAll() throws IOException{
+        server = SimpleHttpServer.create(8080);
+        server.start();
+    }
+
+    @AfterAll
+    static void afterAll(){
+        server.stop();
+    }
+
+    @Test
+    final void testSSE() throws InterruptedException{
+        final SSEHandler handler = new SSEHandler();
+        server.createContext("sse", handler);
+
+        handler.push("event1");
+
+        final AtomicReference<String> data = new AtomicReference<>();
+
+        new Thread(() -> data.set(Requests.getBody("http://localhost:8080/sse", true))).start();
+
+        handler.push("event2");
+        handler.push("event3");
+
+        Thread.sleep(6000);
+
+        Assertions.assertEquals("id: 2\ndata: event1\n\nid: 2\ndata: event2\n\nid: 2\ndata: event3", data.get());
+    }
+
+}