bugfix get_objective_defaults, issue #204

Author: benvanwerkhoven

kernel_tuner/integration.py

@@ -24,10 +24,11 @@
 def get_objective_defaults(objective, objective_higher_is_better):
     """ Uses time as default objective and attempts to lookup objective_higher_is_better for known objectives """
     objective = objective or "time"
-    if objective_higher_is_better is None and objective in objective_default_map:
-        objective_higher_is_better = objective_default_map[objective]
-    else:
-        raise ValueError(f"Please specify objective_higher_is_better for objective {objective}")
+    if objective_higher_is_better is None:
+        if objective in objective_default_map:
+            objective_higher_is_better = objective_default_map[objective]
+        else:
+            raise ValueError(f"Please specify objective_higher_is_better for objective {objective}")
     return objective, objective_higher_is_better
 
 schema_v1_0 = {

test/test_runners.py

@@ -67,7 +67,7 @@ def test_sequential_runner_alt_block_size_names(env):
     result, _ = tune_kernel(*env,
                             grid_div_x=["block_dim_x"],
                             answer=answer,
-                            block_size_names=block_size_names)
+                            block_size_names=block_size_names, objective='time', objective_higher_is_better=False)
 
     assert len(result) == len(tune_params["block_dim_x"])