fixes #548 better

Author: KevinVandy

packages/material-react-table/src/components/body/MRT_TableBodyCell.tsx

@@ -311,10 +311,7 @@ export const MRT_TableBodyCell = <TData extends MRT_RowData>({
               table,
             })
           ) : isCreating || isEditing ? (
-            <MRT_EditCellTextField
-              cell={cell}
-              table={table}
-            />
+            <MRT_EditCellTextField cell={cell} table={table} />
           ) : showClickToCopyButton && columnDef.enableClickToCopy !== false ? (
             <MRT_CopyButton cell={cell} table={table}>
               <MRT_TableBodyCellValue {...cellValueProps} />

packages/material-react-table/src/components/buttons/MRT_ToggleRowActionMenuButton.tsx

@@ -94,7 +94,11 @@ export const MRT_ToggleRowActionMenuButton = <TData extends MRT_RowData>({
             <EditIcon />
           </IconButton>
         </Tooltip>
-      ) : renderRowActionMenuItems ? (
+      ) : renderRowActionMenuItems?.({
+          row,
+          staticRowIndex,
+          table,
+        } as any)?.length ? (
         <>
           <Tooltip {...getCommonTooltipProps()} title={localization.rowActions}>
             <IconButton

packages/material-react-table/src/types.ts

@@ -1239,7 +1239,7 @@ export interface MRT_TableOptions<TData extends MRT_RowData>
     row: MRT_Row<TData>;
     staticRowIndex?: number;
     table: MRT_TableInstance<TData>;
-  }) => ReactNode[];
+  }) => ReactNode[] | undefined;
   renderRowActions?: (props: {
     cell: MRT_Cell<TData>;
     row: MRT_Row<TData>;

packages/material-react-table/stories/features/RowActions.stories.tsx

@@ -128,15 +128,14 @@ export const RowActionsEnabledConditionally = () => {
 };
 
 export const RowActionsEnabledConditionallyPerRow = () => {
-  const [enabled, setEnabled] = useState(false);
   return (
     <MaterialReactTable
       columns={columns}
       data={data}
-      enableRowActions={enabled}
+      enableRowActions
       renderRowActionMenuItems={({ closeMenu, row }) =>
         row.index % 2 === 0
-          ? []
+          ? undefined
           : [
               <MenuItem
                 key={1}
@@ -167,9 +166,6 @@ export const RowActionsEnabledConditionallyPerRow = () => {
               </MenuItem>,
             ]
       }
-      renderTopToolbarCustomActions={() => (
-        <Button onClick={() => setEnabled(!enabled)}>Toggle Row Actions</Button>
-      )}
     />
   );
 };