Skip to content

Commit 64dd481

Browse files
alexzrpKevinVandy
andauthored
Fixed Show clear filter menu if emptyModes filter fns is selected (#914)
* Hide clear filter menu If a filter fns empty or notEmpty is used, the option clear filter in menu dont need show. The bug founded if select empty, because filter value is a space char * sort * fix clear menu item instead of remove --------- Co-authored-by: Kevin Van Cott <kevinvandy656@gmail.com>
1 parent e9a3dd7 commit 64dd481

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

packages/material-react-table/src/menus/MRT_ColumnActionMenu.tsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ export const MRT_ColumnActionMenu = <TData extends MRT_RowData>({
6767
renderColumnActionsMenuItems,
6868
},
6969
refs: { filterInputRefs },
70+
setColumnFilterFns,
7071
setColumnOrder,
7172
setColumnSizingInfo,
7273
setShowColumnFilters,
@@ -119,8 +120,14 @@ export const MRT_ColumnActionMenu = <TData extends MRT_RowData>({
119120
};
120121

121122
const handleClearFilter = () => {
122-
column.setFilterValue('');
123+
column.setFilterValue(undefined);
123124
setAnchorEl(null);
125+
if (['empty', 'notEmpty'].includes(columnDef._filterFn)) {
126+
setColumnFilterFns((prev) => ({
127+
...prev,
128+
[header.id]: allowedColumnFilterOptions?.[0] ?? 'fuzzy',
129+
}));
130+
}
124131
};
125132

126133
const handleFilterByColumn = () => {

packages/material-react-table/src/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,12 +105,12 @@ export type MRT_RowSelectionState = RowSelectionState;
105105
export type MRT_SortingState = SortingState;
106106
export type MRT_Updater<T> = Updater<T>;
107107
export type MRT_VirtualItem = VirtualItem;
108+
export type MRT_VisibilityState = VisibilityState;
108109

109110
export type MRT_VirtualizerOptions<
110111
TScrollElement extends Element | Window = Element | Window,
111112
TItemElement extends Element = Element,
112113
> = VirtualizerOptions<TScrollElement, TItemElement>;
113-
export type MRT_VisibilityState = VisibilityState;
114114

115115
export type MRT_ColumnVirtualizer<
116116
TScrollElement extends Element | Window = HTMLDivElement,

0 commit comments

Comments
 (0)