make sure all filterFns return boolean

Author: KevinVandy

packages/material-react-table/src/fns/filterFns.ts

@@ -11,7 +11,7 @@ const fuzzy = <TData extends MRT_RowData>(
   columnId: string,
   filterValue: number | string,
   addMeta: (item: RankingInfo) => void,
-) => {
+): boolean => {
   const itemRank = rankItem(
     row.getValue<string | number | null>(columnId),
     filterValue as string,
@@ -29,8 +29,8 @@ const contains = <TData extends MRT_RowData>(
   row: Row<TData>,
   id: string,
   filterValue: number | string,
-) =>
-  row
+): boolean =>
+  !!row
     .getValue<number | string | null>(id)
     ?.toString()
     .toLowerCase()
@@ -43,8 +43,8 @@ const startsWith = <TData extends MRT_RowData>(
   row: Row<TData>,
   id: string,
   filterValue: number | string,
-) =>
-  row
+): boolean =>
+  !!row
     .getValue<number | string | null>(id)
     ?.toString()
     .toLowerCase()
@@ -57,8 +57,8 @@ const endsWith = <TData extends MRT_RowData>(
   row: Row<TData>,
   id: string,
   filterValue: number | string,
-) =>
-  row
+): boolean =>
+  !!row
     .getValue<number | string | null>(id)
     ?.toString()
     .toLowerCase()
@@ -71,7 +71,7 @@ const equals = <TData extends MRT_RowData>(
   row: Row<TData>,
   id: string,
   filterValue: number | string,
-) =>
+): boolean =>
   row.getValue<number | string | null>(id)?.toString().toLowerCase().trim() ===
   filterValue.toString().toLowerCase().trim();
 
@@ -81,7 +81,7 @@ const notEquals = <TData extends MRT_RowData>(
   row: Row<TData>,
   id: string,
   filterValue: number | string,
-) =>
+): boolean =>
   row.getValue<number | string | null>(id)?.toString().toLowerCase().trim() !==
   filterValue.toString().toLowerCase().trim();
 
@@ -91,7 +91,7 @@ const greaterThan = <TData extends MRT_RowData>(
   row: Row<TData>,
   id: string,
   filterValue: number | string,
-) =>
+): boolean =>
   !isNaN(+filterValue) && !isNaN(+row.getValue<number | string>(id))
     ? +(row.getValue<number | string | null>(id) ?? 0) > +filterValue
     : (row.getValue<number | string | null>(id) ?? '')
@@ -105,15 +105,15 @@ const greaterThanOrEqualTo = <TData extends MRT_RowData>(
   row: Row<TData>,
   id: string,
   filterValue: number | string,
-) => equals(row, id, filterValue) || greaterThan(row, id, filterValue);
+): boolean => equals(row, id, filterValue) || greaterThan(row, id, filterValue);
 
 greaterThanOrEqualTo.autoRemove = (val: any) => !val;
 
 const lessThan = <TData extends MRT_RowData>(
   row: Row<TData>,
   id: string,
   filterValue: number | string,
-) =>
+): boolean =>
   !isNaN(+filterValue) && !isNaN(+row.getValue<number | string>(id))
     ? +(row.getValue<number | string | null>(id) ?? 0) < +filterValue
     : (row.getValue<number | string | null>(id) ?? '')
@@ -127,15 +127,15 @@ const lessThanOrEqualTo = <TData extends MRT_RowData>(
   row: Row<TData>,
   id: string,
   filterValue: number | string,
-) => equals(row, id, filterValue) || lessThan(row, id, filterValue);
+): boolean => equals(row, id, filterValue) || lessThan(row, id, filterValue);
 
 lessThanOrEqualTo.autoRemove = (val: any) => !val;
 
 const between = <TData extends MRT_RowData>(
   row: Row<TData>,
   id: string,
   filterValues: [number | string, number | string],
-) =>
+): boolean =>
   ((['', undefined] as any[]).includes(filterValues[0]) ||
     greaterThan(row, id, filterValues[0])) &&
   ((!isNaN(+filterValues[0]) &&
@@ -150,7 +150,7 @@ const betweenInclusive = <TData extends MRT_RowData>(
   row: Row<TData>,
   id: string,
   filterValues: [number | string, number | string],
-) =>
+): boolean =>
   ((['', undefined] as any[]).includes(filterValues[0]) ||
     greaterThanOrEqualTo(row, id, filterValues[0])) &&
   ((!isNaN(+filterValues[0]) &&
@@ -165,15 +165,15 @@ const empty = <TData extends MRT_RowData>(
   row: Row<TData>,
   id: string,
   _filterValue: number | string,
-) => !row.getValue<number | string | null>(id)?.toString().trim();
+): boolean => !row.getValue<number | string | null>(id)?.toString().trim();
 
 empty.autoRemove = (val: any) => !val;
 
 const notEmpty = <TData extends MRT_RowData>(
   row: Row<TData>,
   id: string,
   _filterValue: number | string,
-) => !!row.getValue<number | string | null>(id)?.toString().trim();
+): boolean => !!row.getValue<number | string | null>(id)?.toString().trim();
 
 notEmpty.autoRemove = (val: any) => !val;