[Contracts] RemittanceNFT update_score has an unreachable points_i128==0 early-return after the MIN_SCORE_UPDATE_REPAYMENT guard

[grantfox-oss]

Telegram (ask questions / claim the issue here first): https://t.me/+DOylgFv1jyJlNzM0

Why this matters

remittance_nft/src/lib.rs:656-669: update_score rejects repayment_amount < MIN_SCORE_UPDATE_REPAYMENT (100) at line 656, then computes points_i128 = repayment_amount/100 (line 666) and does if points_i128 == 0 { return Ok(()) } (667-669). Once the 100-floor passes, repayment_amount>=100 so points_i128>=1, making the zero-branch dead code that can never execute.

Acceptance criteria

• Remove the unreachable points_i128==0 branch (or add a comment/debug_assert documenting why it is retained)
• Confirm existing update_score tests still pass

Files to touch

• contracts/remittance_nft/src/lib.rs

Out of scope

• Changing the MIN_SCORE_UPDATE_REPAYMENT value or scoring formula

[anidroid1184]

Hi! I would like to apply for this issue. I've analyzed the update_score function in contracts/remittance_nft/src/lib.rs and confirmed that since the MIN_SCORE_UPDATE_REPAYMENT guard enforces an initial floor of 100, the downstream points_i128 == 0 check behaves as unreachable dead code.

My technical approach will be:

1. Create a dedicated branch: refactor/remove-unreachable-score-guard.
2. Clean up the redundant points_i128 == 0 early return block inside src/lib.rs.
3. Verify that the entire existing test suite for update_score continues to compile and pass successfully by running cargo test locally.
4. Format and lint the contract scope via cargo fmt --check and cargo clippy.

I am ready to submit the fix as soon as I'm assigned!