style(cnpj-fmt): improve source code quality

Author: juliolmuller

src/CnpjFormatter.php

@@ -247,13 +247,17 @@ private function toStringInput(mixed $cnpjInput): string
         }
 
         if (is_array($cnpjInput)) {
+            $joined = '';
+
             foreach ($cnpjInput as $item) {
                 if (!is_string($item)) {
                     throw new CnpjFormatterInputTypeError($cnpjInput, 'string or string[]');
                 }
+
+                $joined .= $item;
             }
 
-            return implode('', $cnpjInput);
+            return $joined;
         }
 
         throw new CnpjFormatterInputTypeError($cnpjInput, 'string or string[]');

src/CnpjFormatterOptions.php

@@ -249,17 +249,17 @@ public function __construct(
     public function __get(string $name): mixed
     {
         return match ($name) {
-            'hidden' => $this->getHidden(),
-            'hiddenKey' => $this->getHiddenKey(),
+            'hidden'      => $this->getHidden(),
+            'hiddenKey'   => $this->getHiddenKey(),
             'hiddenStart' => $this->getHiddenStart(),
-            'hiddenEnd' => $this->getHiddenEnd(),
-            'dotKey' => $this->getDotKey(),
-            'slashKey' => $this->getSlashKey(),
-            'dashKey' => $this->getDashKey(),
-            'escape' => $this->getEscape(),
-            'encode' => $this->getEncode(),
-            'onFail' => $this->getOnFail(),
-            default => throw new InvalidArgumentException("Unknown property: {$name}"),
+            'hiddenEnd'   => $this->getHiddenEnd(),
+            'dotKey'      => $this->getDotKey(),
+            'slashKey'    => $this->getSlashKey(),
+            'dashKey'     => $this->getDashKey(),
+            'escape'      => $this->getEscape(),
+            'encode'      => $this->getEncode(),
+            'onFail'      => $this->getOnFail(),
+            default       => throw new InvalidArgumentException("Unknown property: {$name}"),
         };
     }
 
@@ -269,17 +269,17 @@ public function __get(string $name): mixed
     public function __set(string $name, mixed $value): void
     {
         match ($name) {
-            'hidden' => $this->setHidden($value),           // @phpstan-ignore-line argument.type
-            'hiddenKey' => $this->setHiddenKey($value),     // @phpstan-ignore-line method.notFound
+            'hidden'      => $this->setHidden($value),      // @phpstan-ignore-line argument.type
+            'hiddenKey'   => $this->setHiddenKey($value),   // @phpstan-ignore-line method.notFound
             'hiddenStart' => $this->setHiddenStart($value), // @phpstan-ignore-line method.notFound
-            'hiddenEnd' => $this->setHiddenEnd($value),     // @phpstan-ignore-line method.notFound
-            'dotKey' => $this->setDotKey($value),           // @phpstan-ignore-line method.notFound
-            'slashKey' => $this->setSlashKey($value),       // @phpstan-ignore-line method.notFound
-            'dashKey' => $this->setDashKey($value),         // @phpstan-ignore-line method.notFound
-            'escape' => $this->setEscape($value),           // @phpstan-ignore-line argument.type
-            'encode' => $this->setEncode($value),           // @phpstan-ignore-line argument.type
-            'onFail' => $this->setOnFail($value),           // @phpstan-ignore-line argument.type
-            default => throw new InvalidArgumentException("Unknown property: {$name}"),
+            'hiddenEnd'   => $this->setHiddenEnd($value),   // @phpstan-ignore-line method.notFound
+            'dotKey'      => $this->setDotKey($value),      // @phpstan-ignore-line method.notFound
+            'slashKey'    => $this->setSlashKey($value),    // @phpstan-ignore-line method.notFound
+            'dashKey'     => $this->setDashKey($value),     // @phpstan-ignore-line method.notFound
+            'escape'      => $this->setEscape($value),      // @phpstan-ignore-line argument.type
+            'encode'      => $this->setEncode($value),      // @phpstan-ignore-line argument.type
+            'onFail'      => $this->setOnFail($value),      // @phpstan-ignore-line argument.type
+            default       => throw new InvalidArgumentException("Unknown property: {$name}"),
         };
     }
 

tests/Specs/CnpjFormatterOptions.spec.php

@@ -65,7 +65,7 @@
                     'escape' => true,
                     'encode' => true,
                     'onFail' => function (mixed $value): string {
-                        return "ERROR: {$value}";
+                        return 'ERROR: ' . strval($value);
                     },
                 ];
 
@@ -758,7 +758,7 @@
         describe('when setting to a callable value', function () {
             it('sets `onFail` to the provided callback', function () {
                 $callback = function (mixed $value, CnpjFormatterException $e): string {
-                    return "ERROR: {$value}";
+                    return 'ERROR: ' . strval($value);
                 };
                 $options = new CnpjFormatterOptions();
 
@@ -771,7 +771,7 @@
         describe('when setting to a nullish value', function () use ($defaultParameters) {
             it('sets default callback for `null`', function () use ($defaultParameters) {
                 $callback = function (mixed $value, CnpjFormatterException $e): string {
-                    return "ERROR: {$value}";
+                    return 'ERROR: ' . strval($value);
                 };
                 $options = new CnpjFormatterOptions(onFail: $callback);