Skip to content

Commit c45c6e5

Browse files
committed
Fix react typescript 01 sample
1 parent f3f376d commit c45c6e5

File tree

3 files changed

+7
-10
lines changed

3 files changed

+7
-10
lines changed

samples/react/typescript/01 SignupForm/src/components/sampleSignupForm/validations/signupFormValidation.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@ function passwordAndConfirmPasswordValidationHandler(value: any, vm: any): Field
2121

2222
function loginExistOnGitHubValidationHandler(value: any, vm: any): Promise<FieldValidationResult> {
2323
return gitHub.doesLoginExists(value)
24-
.then((loginExists) => resolveLoginExists(loginExists))
25-
.catch(error => console.log('ERROR', error));
24+
.then((loginExists) => resolveLoginExists(loginExists));
2625
}
2726

2827
function resolveLoginExists(loginExists: boolean): Promise<FieldValidationResult> {

samples/react/typescript/01 SignupForm/src/reducers/signup.ts

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,11 @@ function signupProcessCompleted(state: SignupState, action: ISignupUIOnInteracti
4848
}
4949

5050
function performSignupCompleted(state: SignupState, action: ISignupRequestCompletedAction): SignupState {
51-
const newSignupErrors: SignupErrors = { ...state.signupErrors };
52-
53-
action.formValidationResult.fieldErrors.forEach(fieldValidationResult => {
54-
newSignupErrors[fieldValidationResult.key] = fieldValidationResult;
55-
});
56-
5751
return {
5852
...state,
59-
signupErrors: newSignupErrors
53+
signupErrors: {
54+
...state.signupErrors,
55+
...action.formValidationResult.fieldErrors,
56+
}
6057
};
6158
}

samples/react/typescript/01 SignupForm/tsconfig.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010
"experimentalDecorators": true,
1111
"emitDecoratorMetadata": true,
1212
"preserveConstEnums": true,
13-
"suppressImplicitAnyIndexErrors": true
13+
"suppressImplicitAnyIndexErrors": true,
14+
"skipLibCheck": true
1415
},
1516
"compileOnSave": false,
1617
"exclude": [

0 commit comments

Comments
 (0)