ConsentPopup fails to pop up

[robertjamison]

Hi, thanks again for this great library!

I did try your method after the latest changes from v1.1.0-beta01 and no luck. The ConsentPopup still fails to show. I live in the EEA region, and the setForceTesting is not needed for me (but I did test with it just in case).

The only way I could make the consent to show is by calling consent.loadAndShowConsentForm() and I think this is missing from the library's ConsentPopup Composable.

val consent by rememberConsent()
    LaunchedEffect(Unit) {
        consent.requestConsentInfoUpdate(
            onCompletion = {
                consent.loadAndShowConsentForm() // The consent show ONLY if I call this
            }
        )
    }

    if (consent.canRequestAds) {
        BasicAds.Initialize()
    }

I do have the UMP dependencies for Android (4.0.0) and iOS (3.1.0).

Originally posted by @moisoni97 in #114

[robertjamison]

@moisoni97 I'm going to update the existing ConsentPopup to call loadAndShowConsentForm. I'm also updating the arguments to include callbacks for load and show -- not just failure.

[robertjamison]

Ignore my prior comment. I was posting on the wrong issue.

[moisoni97]

Hi @robertjamison ,

I think the ConsentPopup implementation is not quite there, because it needs some additional steps to successfully show the consent.

The desired implementation should be as simple as this:

val consent by rememberConsent()
ConsentPopup(consent)

After the v1.1.0-beta03, the ConsentPopup should work like this, as far as I understand, but this fails to show the consent:

// This does not work
val consent by rememberConsent()

consent.requestConsentInfoUpdate()
ConsentPopup(consent)

With v1.1.0-beta3, the consent is successfully shown only if we track the onCompletion :

// This works
val consent by rememberConsent()
var showConsent by remember { mutableStateOf(false) }

consent.requestConsentInfoUpdate(
    onCompletion = {
        showConsent = true
    }
)

if (showConsent) {
    ConsentPopup(consent)
}

I think the above, working implementation, defeats the whole purpose of ConsentPopup, because it would be much simpler to show the consent like this and never need the ConsentPopup composable...

// This works
val consent by rememberConsent()

LaunchedEffect(Unit) {
    consent.requestConsentInfoUpdate(
        onCompletion = {
            consent.loadAndShowConsentForm()
        }
    )
}

To achieve the "desired" implementation, I think the ConsentPopup composable should call both requestConsentInfoUpdate() and loadAndShowConsentForm(), in onCompletion...

Or maybe I failed to understand the correct implementation of the ConsentPopup... What are your thoughts?

[robertjamison]

I'll push one final update making your recommended change as of 1.1.0.
I've tested it, and I think it meets your intent.