Merge pull request #1953 from jepler/bump-gcc-std

Bump the C/C++ language standards version

Author: jepler

src/Makefile

@@ -244,18 +244,16 @@ INCLUDE += $(LIBTIRPC_CFLAGS)
 # Compilation options.	Perhaps some of these should come from Makefile.inc? (CXXFLAGS now does)
 INTEGER_OVERFLOW_FLAGS := -fwrapv
 OPT := -Os $(INTEGER_OVERFLOW_FLAGS)
-DEBUG := $(DEBUG) -g -Wall -Wno-stringop-truncation
-CFLAGS := $(INCLUDE) $(OPT) $(DEBUG) $(EXTRA_DEBUG) -DULAPI -std=gnu99 -fgnu89-inline -Werror=implicit-function-declaration $(CFLAGS) $(CPPFLAGS)
-CXXFLAGS := $(INCLUDE) $(EXTRA_DEBUG) -DULAPI $(DEBUG) $(OPT) -Woverloaded-virtual $(CXXFLAGS) $(CPPFLAGS)
-CXXFLAGS += $(call cxx-option, -Wno-psabi)
-CXXFLAGS += $(call cxx-option, -std=gnu++11, -std=gnu++0x)
+DEBUG := $(DEBUG) -g -Wall -Wno-stringop-truncation -D_FORTIFY_SOURCE=2
+CFLAGS := $(INCLUDE) $(OPT) $(DEBUG) $(EXTRA_DEBUG) -DULAPI -std=gnu11 -Werror=implicit-function-declaration $(CFLAGS) $(CPPFLAGS)
+CXXFLAGS := $(INCLUDE) $(EXTRA_DEBUG) -DULAPI $(DEBUG) $(OPT) -Werror=overloaded-virtual $(CXXFLAGS) $(CPPFLAGS)
+CXXFLAGS += -std=gnu++17
 # In Debian 11, any inclusion of <boost/python.hpp> leads to several
 # diagnostics from included headers about deprecated features. LinuxCNC does
 # not directly use these deprecated features, but it does use boost::python.
 # Silence the warnings just when they occur in files using boost/python.hpp by
 # adding SILENCE_BOOST_INTERNAL_DIAGNOSTICS_FLAGS to the object's EXTRAFLAGS
 SILENCE_BOOST_INTERNAL_DIAGNOSTICS_FLAGS = -DBOOST_ALLOW_DEPRECATED_HEADERS=1 -DBOOST_BIND_GLOBAL_PLACEHOLDERS=1
-
 CFLAGS   += $(TOOL_NML_FLAG)
 CXXFLAGS += $(TOOL_NML_FLAG)
 
@@ -878,7 +876,7 @@ EXTRA_CFLAGS := $(filter-out -ffast-math,$(RTFLAGS)) -D__MODULE__ -I$(BASEPWD)/.
 	-I$(BASEPWD)/emc/nml_intf -I$(BASEPWD)/emc/kinematics -I$(BASEPWD)/emc/tp -I$(BASEPWD)/emc/motion \
 	-DSEQUENTIAL_SUPPORT -DHAL_SUPPORT -DDYNAMIC_PLCSIZE -DRT_SUPPORT -DOLD_TIMERS_MONOS_SUPPORT -DMODBUS_IO_MASTER \
 	-fno-fast-math $(call cc-option,-mieee-fp) -fno-unsafe-math-optimizations \
-	-Wframe-larger-than=2560 -Wno-declaration-after-statement \
+	-Werror=frame-larger-than=2560 -Wno-declaration-after-statement \
 	$(INTEGER_OVERFLOW_FLAGS)
 ifneq ($(KERNELRELEASE),)
 ifeq ($(RTARCH):$(RTAI):$(filter $(RTFLAGS),-msse),x86_64:3:)

src/configure.ac

@@ -33,13 +33,15 @@ fi
 AC_PROG_CXX
 AC_PROG_INSTALL
 
-m4_include([m4/ax_cxx_compile_stdcxx_11.m4])
+m4_include([m4/ax_require_defined.m4])
+m4_include([m4/ax_cxx_compile_stdcxx.m4])
+m4_include([m4/ax_cxx_compile_stdcxx_17.m4])
 m4_include([m4/ax_python.m4])
 m4_include([m4/ax_python_devel.m4])
 m4_include([m4/ax_boost_base.m4])
 m4_include([m4/ax_boost_python.m4])
 # make this optional - it will likely only result in warnings
-AX_CXX_COMPILE_STDCXX_11(noext,optional)
+AX_CXX_COMPILE_STDCXX_17(ext,mandatory)
 
 AC_MSG_CHECKING(build toplevel)
 BUILD_TOPLEVEL="$(cd ..; pwd -P)"

src/hal/components/carousel.comp

@@ -188,7 +188,7 @@ FUNCTION(_){
     int mod_pocket = 0;
     int new_pos = 0;
     unsigned int mask;
-    int align_pin; // used for slow align move, input depends on mode for historical reasons
+    int align_pin = 0; // used for slow align move, input depends on mode for historical reasons
 
     switch inst_code{
     case 'G': // Gray Code

src/hal/user_comps/sendkeys.c

@@ -62,7 +62,7 @@ void emit(int fd, int type, int code, int val)
    ie.type = type;
    ie.code = code;
    ie.value = val;
-   write(fd, &ie, sizeof(ie));
+   if (write(fd, &ie, sizeof(ie)) != sizeof(ie)) { perror("write(input_event)"); }
 }
 
 static void exit_handler(int sig) {
@@ -219,7 +219,6 @@ int init(int argc, char* argv[]){
 }
 
 int main(int argc, char* argv[]) {
-    struct uinput_user_dev uidev;
     int i, j;
 
     signal(SIGINT, exit_handler);
@@ -246,24 +245,28 @@ int main(int argc, char* argv[]) {
             if (! *hal->init) continue;
             if (*hal->init && ! param->inited) {
                 param->fd = open("/dev/uinput", O_WRONLY | O_NONBLOCK);
-                if (param->fd < 0) rtapi_print_msg(RTAPI_MSG_ERR, 
-                    "Cannot open /dev/uinput. Suggest chmod 666 /dev/uinput\n");
+                if (param->fd < 0) {
+                    rtapi_print_msg(RTAPI_MSG_ERR,
+                        "Cannot open /dev/uinput. Suggest chmod 666 /dev/uinput\n");
+                    abort();
+                }
                 ioctl(param->fd, UI_SET_EVBIT, EV_KEY);
                 for (j = 0; j < param->num_events; j++){
                     if (hal->event[j] > 0 && hal->event[j] < KEY_MAX){
                         ioctl(param->fd, UI_SET_KEYBIT, hal->event[j]);
                         rtapi_print("SET_EVBIT %i\n", hal->event[j]);
                     }
                 }
+                struct uinput_user_dev uidev;
                 memset(&uidev, 0, sizeof(uidev));
                 strcpy(uidev.name, "linuxcnc-hal");
                 uidev.id.bustype = BUS_USB;
                 uidev.id.vendor  = 0x1;
                 uidev.id.product = 0x1;
                 uidev.id.version = 1;
 
-                write(param->fd, &uidev, sizeof(uidev));
-                ioctl(param->fd, UI_DEV_CREATE);
+                if (write(param->fd, &uidev, sizeof(uidev)) != sizeof(uidev)) { perror("write(uinput_user_dev)"); abort(); }
+                if (ioctl(param->fd, UI_DEV_CREATE) < 0) { perror("ioctl(UI_DEV_CREATE)"); abort(); }
                 param->inited = 1;
             }
             if (*hal->keycode != param->oldcode) {