From 6fb9f1d2b082c5078e149c481d67f7a0231b087c Mon Sep 17 00:00:00 2001 From: Bruno Logerfo Date: Thu, 13 Jun 2019 17:11:34 -0300 Subject: [PATCH 1/3] jest config for tests --- jest.config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jest.config.js b/jest.config.js index 3891d4d..0edf48c 100644 --- a/jest.config.js +++ b/jest.config.js @@ -1,5 +1,5 @@ module.exports = { - roots: ['/src/'], + roots: ['/src/', '/test/'], transform: { '^.+\\.tsx?$': 'ts-jest' }, From 897310e6a008006d3ba5af6b38e7463c24673bbe Mon Sep 17 00:00:00 2001 From: Bruno Logerfo Date: Thu, 13 Jun 2019 17:16:58 -0300 Subject: [PATCH 2/3] updating "contributing" for testing --- CONTRIBUTING.md | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 0210c35..9ef779c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -17,13 +17,17 @@ We'd also love PRs. If you're thinking of a large PR, we advise opening up an is ## Submitting a pull request 1. [Fork][fork] and clone the repository. -1. Configure and install the dependencies: `npm install`. -1. Create a new branch: `git checkout -b my-branch-name`. -1. Push to your fork and [submit a pull request][pr]. -1. Pat your self on the back and wait for your pull request to be reviewed and merged. +2. Configure and install the dependencies: `npm install`. +3. Make sure the tests pass on your machine: `npm test`, note: these tests also apply the linter, so there's no need to lint separately. +4. Create a new branch: `git checkout -b my-branch-name`. +5. Make your change, add tests, and make sure the tests still pass. +6. Push to your fork and [submit a pull request][pr]. +7. Pat your self on the back and wait for your pull request to be reviewed and merged. Here are a few things you can do that will increase the likelihood of your pull request being accepted: +- Any linting errors should be shown when running `npm test`. +- Write and update tests. - Keep your changes as focused as possible. If there are multiple changes you would like to make that are not dependent upon each other, consider submitting them as separate pull requests. - Write a [good commit message](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html). From 877b1e78be2f07a6bfa21c8d3a786b53eee6a78a Mon Sep 17 00:00:00 2001 From: Bruno Logerfo Date: Thu, 13 Jun 2019 17:17:06 -0300 Subject: [PATCH 3/3] travis running tests --- .travis.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 1b4a9fc..a14e7b7 100644 --- a/.travis.yml +++ b/.travis.yml @@ -7,7 +7,6 @@ install: cache: directories: - "node_modules" -script: 'true' notifications: email: recipients: