Skip to content

Commit 4ba8443

Browse files
authored
Merge pull request #317 from oxters168/stream-close-bug
ContentDownloader Stream Close Bug Fix
2 parents 56f4a41 + 329c7b1 commit 4ba8443

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

src/main/java/in/dragonbra/javasteam/steam/contentdownloader/ContentDownloader.kt

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -583,7 +583,7 @@ class ContentDownloader(val steamClient: SteamClient) {
583583

584584
if (fileStreamData.fileStream == null) {
585585
val fileFinalPath = Paths.get(depot.installDir, file.fileName).toString()
586-
val randomAccessFile = RandomAccessFile(fileFinalPath, "rw") // TODO this resource leaks. (see below)
586+
val randomAccessFile = RandomAccessFile(fileFinalPath, "rw")
587587
fileStreamData.fileStream = randomAccessFile.channel
588588
}
589589

@@ -594,12 +594,10 @@ class ContentDownloader(val steamClient: SteamClient) {
594594
}
595595

596596
val remainingChunks = synchronized(fileStreamData) {
597-
fileStreamData.chunksToDownload--
597+
--fileStreamData.chunksToDownload
598598
}
599-
if (remainingChunks == 0) {
600-
// TODO this condition is never called?
599+
if (remainingChunks <= 0) {
601600
fileStreamData.fileStream?.close()
602-
fileStreamData.fileLock.release()
603601
}
604602

605603
var sizeDownloaded: Long

0 commit comments

Comments
 (0)