Missing screenshot in log file when using Browser library from custom python library

[MarvKler]

Describe the bug
I've been using Browser library from python directly instead of using it through .robot / .resource files. I have activated & configured the highlight_on_failure andrun_on_failure library arguments and i would expect to see a screenshot in the robot log file when any keyword of the Browser library fails.

To Reproduce
Steps to reproduce the behavior:

1. Create your own python library for robot framework
2. Use Browser library keywords within your custom python keywords
3. For testing purposes, use any invalid locator or change something else to run into an error
4. Open the log file
5. Error is raised & shown in the log file but the screenshot is missing at all.

Expected behavior
The error gets logged into the log file and additionally the Browser library adds the screenshot which should get taken due to the run_on_failure configuration.

Screenshots

Desktop (please complete the following information):

• OS: WSL (Linux)
• Browser chrome
• Version [e.g. 22]

Additional context
Using browser library version 19.12.4

[aaltat]

What are are experiencing is true and correct. This is because run on failure functionality is based Robot Framework dynamic library API, more in https://robotframework.org/robotframework/latest/RobotFrameworkUserGuide.html#dynamic-library-api This means that when the library function is called trough the run_keyword API call, only then https://github.com/MarketSquare/robotframework-browser/blob/main/Browser/browser.py#L1256 run on keyword functionality is applied. Because this is by designing, we are not going to change the functionality. That being said, you are not the first one that stumbled into this feature and raises an issue about it. I think we do not have this feature explicitly mentioned anywhere in the documentation, would you have an idea where this could be explained?

Luckily this functionality is easy to do in your own library. If your library only has few keywords, then creating a decorator that does same thing can be a good choice. But if your library is large or has complex logic then looking at Python Lib Core direction might be good idea https://github.com/robotframework/PythonLibCore

[aaltat]

@allcontributors please add @MarvKler for bugs

[allcontributors]

@aaltat

@MarvKler already contributed before to bug

[MarvKler]

Thanks for the explanation.
I am planning to use the PythonLibCore, so i will check this out and try to do this in my library.

Regarding the documentation: as far as you can configure those parameters as library argument, i would mention it weither in the table where you describe the library arguments or you create a new section in the general library documentation. If there are more limitations or required information for using Browser within custom python libraries, it would be a good place to mention.