Skip to content

Should be trying variable numbers of layers? #53

@bannanc

Description

@bannanc

Right now, well in PR #48, SMIRKSifier automatically choses the number of layers, but it just increases the number of layers with each try. However, This doesn't completely make sense since the first SMIRKS in the list shouldn't need extra layers, and so on. However, there might be places where the clusters that are hard to distinguish aren't right next to each other in the list. This brute force check slows things down significantly.

Maybe there is something we could do to make a most similar based on the ClusterGraphs and then order and determine the number of layers based on that.

Metadata

Metadata

Assignees

No one assigned

    Labels

    long termCaitlin did not have time to addressquestionNeeds to be explored further

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions