'JSONException: No value for end' with rate my app campaigns

[SergiHernando]

I'm getting the following exception (output from logs):

D/Malcom  (  901): HTTP OPERATION: Read from server - return: {"campaigns":[{"id":934,"name":"Prueba Sergi","start":1381190400000,"createdOn":1381247000000,"type":"IN_APP_RATE_MY_APP","state":"ACTIVE","promotionFeature":{"promotionType":"SELF","promotionIdentifier":"NOT_CONFIGURED"},"clientLimitFeatures":[{"clientLimitType":"TIMES_BEFORE_REMINDING","limitValue":2},{"clientLimitType":"DAYS_UNTIL_PROMT","limitValue":3}],"enabled":true,"endOrNow":1381248657866}]}
D/MCMCampaign(  901): <<< getJSONfromURL result: {"campaigns":[{"id":934,"name":"Prueba Sergi","start":1381190400000,"createdOn":1381247000000,"type":"IN_APP_RATE_MY_APP","state":"ACTIVE","promotionFeature":{"promotionType":"SELF","promotionIdentifier":"NOT_CONFIGURED"},"clientLimitFeatures":[{"clientLimitType":"TIMES_BEFORE_REMINDING","limitValue":2},{"clientLimitType":"DAYS_UNTIL_PROMT","limitValue":3}],"enabled":true,"endOrNow":1381248657866}]}
D/Malcom  (  901): Received Campaigns JSON: {"campaigns":[{"createdOn":1381247000000,"id":934,"endOrNow":1381248657866,"enabled":true,"promotionFeature":{"promotionIdentifier":"NOT_CONFIGURED","promotionType":"SELF"},"start":1381190400000,"name":"Prueba Sergi","state":"ACTIVE","type":"IN_APP_RATE_MY_APP","clientLimitFeatures":[{"limitValue":2,"clientLimitType":"TIMES_BEFORE_REMINDING"},{"limitValue":3,"clientLimitType":"DAYS_UNTIL_PROMT"}]}]}
W/System.err(  901): org.json.JSONException: No value for end
W/System.err(  901):    at org.json.JSONObject.get(JSONObject.java:354)
W/System.err(  901):    at org.json.JSONObject.getString(JSONObject.java:510)
W/System.err(  901):    at com.malcom.library.android.module.campaign.MCMCampaignDTO.<init>(MCMCampaignDTO.java:66)
W/System.err(  901):    at com.malcom.library.android.module.campaign.MCMCampaignAsyncTasks$DownloadCampaignFile.doInBackground(MCMCampaignAsyncTasks.java:80)
W/System.err(  901):    at com.malcom.library.android.module.campaign.MCMCampaignAsyncTasks$DownloadCampaignFile.doInBackground(MCMCampaignAsyncTasks.java:44)
W/System.err(  901):    at android.os.AsyncTask$2.call(AsyncTask.java:287)
W/System.err(  901):    at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:305)
W/System.err(  901):    at java.util.concurrent.FutureTask.run(FutureTask.java:137)
W/System.err(  901):    at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:230)
W/System.err(  901):    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1076)
W/System.err(  901):    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:569)
W/System.err(  901):    at java.lang.Thread.run(Thread.java:856)

The call to moduleCampaignAddRateMyApp is done in the method onStart of the activity:

MCMCoreAdapter.getInstance().moduleCampaignAddRateMyApp(this, null);

[SergiHernando]

The bug is due to having a void end date for the campaign. Workaround: set an end date far in the future.

[mrmans0n]

Is this already solved? Any news?

/cc @willeeh @DDani

[willeeh]

Maybe @fmaylinch is your man. He's been involved in this module lately.

[fmaylinch]

@ajoman What version are you using? I think this was fixed already. I'll check it out anyway.

[fmaylinch]

@ajoman Now that line MCMCampaignDTO:66 is an if, so I suppose you are using an old version. Can you update?

        if (json.has(ATTR_END))             //Optional
            end = json.getString(ATTR_END);

[fmaylinch]

@ajoman : I can help you with the update; some things have changed. You can read the README.md but if you have problems don't hesitate to ask me. I'm the man (who wrote it). 😄

[SergiHernando]

@fmaylinch the bug was detected in version v1.0.4 while testing campaigns for Edenred. The Ticket Go app still runs with version 1.0.4 of the library, so the bug remains there.

You should test it with a campaign that doesn't have an end date.