From bc87acac8a8922992c5553c7800a8456b8999c28 Mon Sep 17 00:00:00 2001 From: Thomas Arcila <134677+tarcila@users.noreply.github.com> Date: Fri, 5 Jun 2026 18:41:11 -0400 Subject: [PATCH 1/3] tsd: fix macOS Retina UI using render scale instead of font scale --- tsd/src/tsd/ui/imgui/Application.cpp | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/tsd/src/tsd/ui/imgui/Application.cpp b/tsd/src/tsd/ui/imgui/Application.cpp index 6bffa32d4..edf2e8d1e 100644 --- a/tsd/src/tsd/ui/imgui/Application.cpp +++ b/tsd/src/tsd/ui/imgui/Application.cpp @@ -178,9 +178,8 @@ void Application::showImportObjectFileDialog( m_objectFileDialog->showImport(fileType, importRoot); } -void Application::showExportObjectFileDialog(TSDObjectFileType fileType, - anari::DataType objectType, - size_t objectIndex) +void Application::showExportObjectFileDialog( + TSDObjectFileType fileType, anari::DataType objectType, size_t objectIndex) { m_objectFileDialog->showExport(fileType, objectType, objectIndex); } @@ -374,7 +373,6 @@ WindowArray Application::setupWindows() auto *window = sdlWindow(); SDL_MaximizeWindow(window); - m_uiConfig.fontScale = SDL_GetWindowDisplayScale(window); setupImGuiStyle(); @@ -1207,8 +1205,8 @@ void Application::AppImpl::init(Uint32 windowFlags) SDL_ShowWindow(sdlWindow); - const float scale = SDL_GetWindowPixelDensity(sdlWindow); - SDL_SetRenderScale(sdlRenderer, scale, scale); + float pixelDensity = SDL_GetWindowPixelDensity(sdlWindow); + SDL_SetRenderScale(sdlRenderer, pixelDensity, pixelDensity); ImGui::CreateContext(); ImGui::StyleColorsDark(); @@ -1219,6 +1217,7 @@ void Application::AppImpl::init(Uint32 windowFlags) ImGuiIO &io = ImGui::GetIO(); io.ConfigFlags |= ImGuiConfigFlags_NavEnableKeyboard; io.ConfigFlags |= ImGuiConfigFlags_DockingEnable; + io.DisplayFramebufferScale = ImVec2(pixelDensity, pixelDensity); ImGuiStyle &style = ImGui::GetStyle(); if (io.ConfigFlags & ImGuiConfigFlags_ViewportsEnable) From 600a76b923e79abd4de63fad0f10614d6a8e5ff2 Mon Sep 17 00:00:00 2001 From: Thomas Arcila <134677+tarcila@users.noreply.github.com> Date: Fri, 5 Jun 2026 01:03:40 +0000 Subject: [PATCH 2/3] tsd: Fix missing include in ExtensionManager.h --- tsd/src/tsd/ui/imgui/ExtensionManager.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tsd/src/tsd/ui/imgui/ExtensionManager.h b/tsd/src/tsd/ui/imgui/ExtensionManager.h index 6e6cb6516..4426a30c4 100644 --- a/tsd/src/tsd/ui/imgui/ExtensionManager.h +++ b/tsd/src/tsd/ui/imgui/ExtensionManager.h @@ -3,6 +3,7 @@ #pragma once +#include #include #include #include From 77f00858cb6b0f5b7d543be6d51d3a9c846438b2 Mon Sep 17 00:00:00 2001 From: Thomas Arcila <134677+tarcila@users.noreply.github.com> Date: Fri, 5 Jun 2026 01:07:00 +0000 Subject: [PATCH 3/3] rtx: silence C++20-extension warning in MDL::syncParameters The find_if lambda captured the structured binding 'name' (from the enumerateArguments() decomposition), which is only standard in C++20 and warns under C++17 (-Wc++20-extensions). Use an init-capture (¶mName = name) so a fresh variable is captured instead of the binding. --- devices/rtx/device/material/MDL.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/devices/rtx/device/material/MDL.cpp b/devices/rtx/device/material/MDL.cpp index bb9ffc6de..f1838dbeb 100644 --- a/devices/rtx/device/material/MDL.cpp +++ b/devices/rtx/device/material/MDL.cpp @@ -345,9 +345,11 @@ void MDL::syncParameters() if (sampler) { // Find a valid slot for out sampler. // Check if this input if already bound and then release it - auto it = std::find_if(begin(m_samplers), end(m_samplers), [&name](const SamplerDesc &desc) { - return desc.name == name; - }); + auto it = std::find_if(begin(m_samplers), + end(m_samplers), + [¶mName = name](const SamplerDesc &desc) { + return desc.name == paramName; + }); if (it != end(m_samplers)) { // Found, release if (it->sampler) {