diff --git a/internal/edits/device.go b/internal/edits/device.go index 8ce05c00b..2b12e0492 100644 --- a/internal/edits/device.go +++ b/internal/edits/device.go @@ -130,9 +130,6 @@ func (d *device) getAdditionalGIDs(dn *specs.DeviceNode) []uint32 { if dn.FileMode == nil { return nil } - if dn.FileMode.Type()&os.ModeCharDevice == 0 { - return nil - } if permission := dn.FileMode.Perm(); isWorldReadable(permission) && isWorldWriteable(permission) { return nil } diff --git a/pkg/nvcdi/lib-csv_test.go b/pkg/nvcdi/lib-csv_test.go index 8a9e17f9d..3b8507362 100644 --- a/pkg/nvcdi/lib-csv_test.go +++ b/pkg/nvcdi/lib-csv_test.go @@ -182,6 +182,7 @@ func TestDeviceSpecGenerators(t *testing.T) { { Name: "0", ContainerEdits: specs.ContainerEdits{ + AdditionalGIDs: []uint32{44}, DeviceNodes: []*specs.DeviceNode{ {Path: "/dev/nvidia0", HostPath: "/dev/nvidia0"}, {Path: "/dev/nvidiactl", HostPath: "/dev/nvidiactl"}, @@ -193,6 +194,7 @@ func TestDeviceSpecGenerators(t *testing.T) { { Name: "1", ContainerEdits: specs.ContainerEdits{ + AdditionalGIDs: []uint32{44}, DeviceNodes: []*specs.DeviceNode{ {Path: "/dev/nvidia1", HostPath: "/dev/nvidia1"}, {Path: "/dev/nvidiactl", HostPath: "/dev/nvidiactl"},