Correctly connect buy_price to system level controllers that use it
Right now, the buy_price variable within a technology (e.g. grid) is not connected to the SLC controller's buy_price value.
If it's a scalar price, we use the config values from the tech.
However, if you're setting the buy_price via set_val (usually because it varies in time, e.g. is an array) then you have to set it in both the grid tech and the SLC because it's not currently connected.
Proposed solution
Connect the buy_price directly to the SLC.
I think I didn't do this before because there was some coupling introduced that negatively affected convergence, but that was a while ago and my memory is fuzzy.
I can't think of a legit reason that wouldn't work now.
Alternatives considered
Additional context
Correctly connect
buy_priceto system level controllers that use itRight now, the
buy_pricevariable within a technology (e.g. grid) is not connected to the SLC controller'sbuy_pricevalue.If it's a scalar price, we use the config values from the tech.
However, if you're setting the
buy_priceviaset_val(usually because it varies in time, e.g. is an array) then you have to set it in both the grid tech and the SLC because it's not currently connected.Proposed solution
Connect the
buy_pricedirectly to the SLC.I think I didn't do this before because there was some coupling introduced that negatively affected convergence, but that was a while ago and my memory is fuzzy.
I can't think of a legit reason that wouldn't work now.
Alternatives considered
Additional context