[BUG] Duplicate osipi_check_required_bvalues definition in OsipiBase #150
Description
Is there an existing issue for this?
- I have searched the existing issues
Describe the bug
A clear and concise description of what the bug is.
In [OsipiBase.py](the method [osipi_check_required_bvalues] is defined twice.
The second definition (near the end of the file) overrides the first implementation, which returned True.
As a result, calls to [osipi_check_required_bvalues()] now return None instead of a boolean, breaking requirement‑checking logic.
Screenshots [optional]
No response
Steps To Reproduce
- Open
[OsipiBase.py]in an editor. - Search for [
def osipi_check_required_bvalues] . - Observe two definitions; the latter is just a stub with pass.
Expected behavior
- Only one definition should exist (or the second should at least return a boolean).
[osipi_check_required_bvalues()]should reliably return True/False so that requirement checks work.
Additional context
This bug was uncovered during an automated code review when testing/fuzzing the library; it’s a simple copy‑paste mistake.
Fixing it will prevent silent failures when algorithms query [osipi_check_required_bvalues()]
Are you working on this?
Yes