Fix: Update architecture logic to support multi-arch via extra_arch

Author: deepakt7340

modules/enableit/common/manifests/repo.pp

@@ -62,6 +62,7 @@
   Enum['http', 'https']     $source_protocol = 'https',
   Boolean                   $local           = false,
   Optional[Stdlib::Fqdn]    $domain          = undef,
+  Optional[Array]           $extra_arch      = ['armhf'],
   Optional[Eit_types::Date] $snapshot        = undef,
 ) {
   File {
@@ -72,11 +73,17 @@
   }
 
   # Get the architecture
-  $architecture = $facts['os']['architecture'] ? {
+  $fact_arch = $facts['os']['architecture'] ? {
     'aarch64' => 'arm64',
     default   => 'amd64',
   }
 
+  # Final architecture list
+  $architecture = $extra_arch.empty ? {
+    true => [$fact_arch],
+    false => unique([$fact_arch] + $extra_arch),
+  }
+
   if $manage {
     class { 'eit_repos':
       purge           => $purge,
@@ -156,11 +163,15 @@
         }
       }
       'Debian': {
+        $arch = $facts['os']['architecture'] ? {
+          'aarch64' => 'arm64',
+          default   => 'amd64',
+        }
         $aptrepos.each |$key, $value| {
           apt::source { $key:
             ensure       => present,
             noop         => $noop_value,
-            architecture => $architecture,
+            architecture => $arch,
             release      => $_os_codename,
             comment      => "${key} repo server",
             location     => $value['url'].inline_epp({ snapshot => $snapshot, }),
@@ -272,6 +283,9 @@
             $apt_repo = $_os_type
           }
 
+          $arch_join = $architecture.join(',')
+          notify{"The value for archetcture is ${arch_join}":}
+
           $feature_repo = $_os_type ? {
             'ubuntu' => ['backports', 'security', 'updates'],
             'debian' => ['backports', 'updates'],
@@ -281,7 +295,7 @@
             apt::source { "local_apt_repo_${_os_codename}-${repo}":
               ensure       => present,
               noop         => $noop_value,
-              architecture => $architecture,
+              architecture => $architecture.join(','),
               release      => "${_os_codename}-${repo}",
               comment      => "local apt ${_os_codename}-${repo} server",
               location     => "https://${domain}/${_snapshot_uri_fragment}apt/${apt_repo}",
@@ -296,7 +310,7 @@
           apt::source { "local_apt_repo_${_os_codename}":
             ensure       => present,
             noop         => $noop_value,
-            architecture => $architecture,
+            architecture => $architecture.join(','),
             release      => $_os_codename,
             comment      => 'local apt repo server',
             location     => "https://${domain}/${_snapshot_uri_fragment}apt/${apt_repo}",

modules/enableit/eit_files/manifests/file.pp

@@ -18,7 +18,6 @@
   Optional[Stdlib::Unixpath]       $target       = undef,
   Optional[Stdlib::AbsolutePath]   $ensure_mount = undef,
   Eit_types::Noop_Value            $noop_value   = undef,
-  Optional[Boolean]                $recurse      = true,
 ) {
 
   if $source and $content {
@@ -38,7 +37,6 @@
     content => $content,
     target  => $target,
     noop    => $noop_value,
-    recurse => $recurse,
   }
 
   $_obmondo_file = if $source {