Added tests

And some TODOS

Author: tersmitten

.travis.yml

@@ -4,18 +4,19 @@ php:
   - 5.3
   - 5.4
   - 5.5
+  - 5.6
 
 env:
   global:
     - REPO_NAME=cakephp-redis
     - PLUGIN_NAME=Redis
     - REQUIRE=""
-    - DB=mysql CAKE_VERSION=master
+    - DB=redis CAKE_VERSION=master
 
   matrix:
-    - DB=mysql CAKE_VERSION=2.3
-    - DB=mysql CAKE_VERSION=2.4
-    - DB=mysql CAKE_VERSION=2.5
+    - DB=redis CAKE_VERSION=2.3
+    - DB=redis CAKE_VERSION=2.4
+    - DB=redis CAKE_VERSION=2.5
 
 matrix:
   include:

Model/Datasource/RedisSource.php

@@ -51,6 +51,13 @@ class RedisSource extends DataSource {
  */
 	public $connected = false;
 
+/**
+ * Whether or not source data like available tables and schema descriptions should be cached.
+ *
+ * @var bool
+ */
+	public $cacheSources = false;
+
 /**
 	* Constructor.
 	*
@@ -64,6 +71,8 @@ public function __construct($config = array()) {
 			return false;
 		}
 
+		$this->_connection = new Redis();
+
 		return $this->connect();
 	}
 
@@ -73,6 +82,7 @@ public function __construct($config = array()) {
  *  Closes the connection to the host (if needed).
  *
  * @return void
+ * @todo Write test
  */
 	public function __destruct() {
 		if (!$this->config['persistent']) {
@@ -86,8 +96,13 @@ public function __destruct() {
  * @param string $name The name of the method being called
  * @param array $arguments An enumerated array containing the parameters passed to the method
  * @return mixed Method return value
+ * @todo Throw exception(s)
  */
 	public function __call($name, $arguments) {
+		if (!method_exists($this->_connection, $name)) {
+			return false;
+		}
+
 		return call_user_func_array(array($this->_connection, $name), $arguments);
 	}
 
@@ -115,7 +130,7 @@ public function connect() {
 		$this->connected = $this->_connect();
 		$this->connected = $this->connected && $this->_authenticate();
 		$this->connected = $this->connected && $this->_select();
-		$this->connected = $this->connected && !$this->_setPrefix();
+		$this->connected = $this->connected && $this->_setPrefix();
 
 		return $this->connected;
 	}
@@ -126,9 +141,8 @@ public function connect() {
  * @return bool True if connecting to the DataSource succeeds, else false
  */
 	protected function _connect() {
+		// TODO: Remove useless try / catch?
 		try {
-			$this->_connection = new Redis();
-
 			if ($this->config['unix_socket']) {
 				return $this->_connection->connect($this->config['unix_socket']);
 			} elseif (!$this->config['persistent']) {
@@ -192,6 +206,7 @@ protected function _setPrefix() {
  * @return bool Always true
  */
 	public function close() {
+		// TODO: Remove useless condition
 		if ($this->isConnected()) {
 			$this->_connection->close();
 		}
@@ -216,19 +231,21 @@ public function isConnected() {
  *
  * @param mixed $data List of tables
  * @return array Array of sources available in this datasource
+ * @todo: Remove useless method?
  */
 	public function listSources($data = null) {
-		return null;
+		return parent::listSources($data);
 	}
 
 /**
  * Returns a Model description (metadata) or null if none found.
  *
  * @param Model|string $model Name of database table to inspect or model instance
  * @return array Array of Metadata for the $model
+ * @todo: Remove useless method?
  */
 	public function describe($model) {
-		return null;
+		return parent::describe($model);
 	}
 
 /**
@@ -238,6 +255,7 @@ public function describe($model) {
  * @param string $func Lowercase name of SQL function, i.e. 'count' or 'max'
  * @param array $params Function parameters (any values must be quoted manually)
  * @return string An SQL calculation function
+ * @todo Remove useless method?
  */
 	public function calculate(Model $Model, $func, $params = array()) {
 		return array('count' => true);