[Autofill] Add password generation support

- Add `GeneratePassword` request type to autofill flows
- Integrate `GeneratePasswordModalBottomSheet` into `AutofillActivity`
- Implement password generation logic in `AutofillViewModel` to fill fields and optionally copy to clipboard
- Update `MenuDatasetBuilder` and `InlineDatasetBuilder` to include password generation options
- Add "Use KeyGo Autofill" string and sparkle icon for the new generation action
- Update unit tests and dependencies in `feature/autofill`

Author: OffRange

feature/autofill/build.gradle.kts

@@ -79,4 +79,8 @@ dependencies {
     implementation(project.dependencies.platform(libs.koin.bom))
     implementation(libs.koin.androidx.compose)
     implementation(libs.koin.annotations)
+
+    testImplementation(libs.kotlin.test)
+    testImplementation(libs.kotlinx.coroutines.test)
+    testImplementation(libs.io.mockk)
 }

feature/autofill/src/main/kotlin/de/davis/keygo/feature/autofill/presentation/activity/AutofillActivity.kt

@@ -1,13 +1,20 @@
 package de.davis.keygo.feature.autofill.presentation.activity
 
+import android.content.ClipData
+import android.content.ClipDescription
 import android.content.Context
 import android.content.Intent
+import android.os.Build
 import android.os.Bundle
+import android.os.PersistableBundle
 import android.service.autofill.Dataset
 import android.view.autofill.AutofillManager
 import androidx.activity.compose.setContent
+import androidx.compose.material3.ExperimentalMaterial3Api
 import androidx.compose.runtime.LaunchedEffect
 import androidx.compose.runtime.getValue
+import androidx.compose.ui.platform.LocalClipboard
+import androidx.compose.ui.platform.toClipEntry
 import androidx.fragment.app.FragmentActivity
 import androidx.lifecycle.compose.collectAsStateWithLifecycle
 import androidx.navigation.compose.rememberNavController
@@ -28,6 +35,7 @@ import de.davis.keygo.feature.autofill.presentation.activity.model.AutofillUiEve
 import de.davis.keygo.feature.autofill.presentation.activity.model.SuspicionDialogVisibility
 import de.davis.keygo.feature.autofill.presentation.model.Request
 import de.davis.keygo.feature.autofill.presentation.model.RequestData
+import de.davis.keygo.feature.item.create.presentation.password.GeneratePasswordModalBottomSheet
 import org.koin.androidx.compose.koinViewModel
 
 
@@ -41,6 +49,7 @@ import org.koin.androidx.compose.koinViewModel
  */
 internal class AutofillActivity : FragmentActivity() {
 
+    @OptIn(ExperimentalMaterial3Api::class)
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
 
@@ -57,10 +66,25 @@ internal class AutofillActivity : FragmentActivity() {
                 val biometricCryptoController = rememberBiometricCryptoController()
                 val biometricUnlockAdapter = rememberBiometricUnlockAdapter()
 
-                ObserveAsEvents(viewModel.events) {
-                    when (it) {
+                val clipboard = LocalClipboard.current
+
+                ObserveAsEvents(viewModel.events) { event ->
+                    when (event) {
                         AutofillEvent.Abort -> cancel()
-                        is AutofillEvent.Fill -> finishWithResult(it.dataset)
+                        is AutofillEvent.Fill -> {
+                            event.copyToClipboard?.let {
+                                val clipData = ClipData.newPlainText(it, it).apply {
+                                    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU)
+                                        description.extras = PersistableBundle().apply {
+                                            putBoolean(ClipDescription.EXTRA_IS_SENSITIVE, true)
+                                        }
+                                }
+
+                                clipboard.setClipEntry(clipData.toClipEntry())
+                            }
+
+                            finishWithResult(event.dataset)
+                        }
                     }
                 }
 
@@ -123,6 +147,13 @@ internal class AutofillActivity : FragmentActivity() {
                         appPackageName = suspicionDialogVisibility.appPackageName,
                         website = suspicionDialogVisibility.website
                     )
+
+
+                if (uiState.showGeneratePassword)
+                    GeneratePasswordModalBottomSheet(
+                        onGenerated = { viewModel.onEvent(AutofillUiEvent.OnGeneratedPassword(it)) },
+                        onDismiss = { viewModel.onEvent(AutofillUiEvent.OnDismissGeneratePassword) }
+                    )
             }
         }
     }

feature/autofill/src/main/kotlin/de/davis/keygo/feature/autofill/presentation/activity/AutofillViewModel.kt

@@ -125,6 +125,10 @@ internal class AutofillViewModel(
                 is FillRequestData.Pinned,
                 is FillRequestData.App -> _uiState.update { it.copy(request = Request.SelectItem) }
 
+                is FillRequestData.GeneratePassword -> _uiState.update {
+                    it.copy(showGeneratePassword = true)
+                }
+
                 is FillRequestData.Suggestion -> handleSuggestionRequest(requestData)
             }
         }
@@ -206,6 +210,14 @@ internal class AutofillViewModel(
             AutofillUiEvent.OnAbortInSuspicion -> viewModelScope.launch {
                 eventChannel.send(AutofillEvent.Abort)
             }
+
+            AutofillUiEvent.OnDismissGeneratePassword -> viewModelScope.launch {
+                eventChannel.send(AutofillEvent.Abort)
+            }
+
+            is AutofillUiEvent.OnGeneratedPassword -> viewModelScope.launch {
+                sendGeneratedPasswordFillEvent(event.password)
+            }
         }
     }
 
@@ -332,6 +344,29 @@ internal class AutofillViewModel(
         eventChannel.send(AutofillEvent.Fill(autofillDatasetProvider.getFillingDataset(values)))
     }
 
+    private suspend fun sendGeneratedPasswordFillEvent(password: String) {
+        val values = requestData.form.fields
+            .filter { it.type is FieldType.Credentials.Password }
+            .map {
+                AutofillValue(
+                    autofillId = it.autofillId,
+                    value = password
+                )
+            }
+
+        if (values.isEmpty()) {
+            eventChannel.send(AutofillEvent.Abort)
+            return
+        }
+
+        eventChannel.send(
+            AutofillEvent.Fill(
+                autofillDatasetProvider.getFillingDataset(values),
+                copyToClipboard = password
+            )
+        )
+    }
+
     companion object {
         const val KEY_AUTOFILL_INFORMATION = "extraction"
     }

feature/autofill/src/main/kotlin/de/davis/keygo/feature/autofill/presentation/activity/model/AutofillEvent.kt

@@ -6,5 +6,5 @@ internal sealed interface AutofillEvent {
 
     data object Abort : AutofillEvent
 
-    data class Fill(val dataset: Dataset) : AutofillEvent
+    data class Fill(val dataset: Dataset, val copyToClipboard: String? = null) : AutofillEvent
 }

feature/autofill/src/main/kotlin/de/davis/keygo/feature/autofill/presentation/activity/model/AutofillUiEvent.kt

@@ -10,4 +10,7 @@ internal sealed interface AutofillUiEvent {
 
     data object OnContinueInSuspicion : AutofillUiEvent
     data object OnAbortInSuspicion : AutofillUiEvent
+
+    data object OnDismissGeneratePassword : AutofillUiEvent
+    data class OnGeneratedPassword(val password: String) : AutofillUiEvent
 }

feature/autofill/src/main/kotlin/de/davis/keygo/feature/autofill/presentation/dataset/inline/InlineDatasetBuilder.kt

@@ -9,19 +9,23 @@ import android.service.autofill.InlinePresentation
 import android.widget.inline.InlinePresentationSpec
 import androidx.annotation.RequiresApi
 import de.davis.keygo.core.item.domain.model.lite.LiteVaultItem
+import de.davis.keygo.feature.autofill.R
 import de.davis.keygo.feature.autofill.presentation.dataset.DatasetBuilder
 import de.davis.keygo.feature.autofill.presentation.dataset.SuggestionFinder
 import de.davis.keygo.feature.autofill.presentation.getOnLongClickPendingIntent
 import de.davis.keygo.feature.autofill.presentation.getSelectionPendingIntent
+import de.davis.keygo.feature.autofill.presentation.model.FieldType
 import de.davis.keygo.feature.autofill.presentation.model.FillRequestData
 import de.davis.keygo.feature.autofill.presentation.model.Form
 import de.davis.keygo.feature.autofill.presentation.model.FormType
 import de.davis.keygo.feature.autofill.presentation.model.appRequestData
+import de.davis.keygo.feature.autofill.presentation.model.generatePasswordRequestData
 import de.davis.keygo.feature.autofill.presentation.model.pinnedRequestData
 import de.davis.keygo.feature.autofill.presentation.model.suggestionRequestData
 import de.davis.keygo.feature.autofill.presentation.subtitle
 import org.koin.core.annotation.Single
 import de.davis.keygo.core.ui.R as CoreUiR
+import de.davis.keygo.feature.item.create.R as FeatureItemCreateR
 
 @Single
 internal class InlineDatasetBuilder(
@@ -31,8 +35,6 @@ internal class InlineDatasetBuilder(
     private val context: Context,
 ) {
 
-    // TODO: include a option to generate a secure password -> make the generate UI a standalone
-    //  composable like a TextField
     @RequiresApi(Build.VERSION_CODES.R)
     suspend fun buildInlineDatasets(
         specs: List<InlinePresentationSpec>,
@@ -71,8 +73,20 @@ internal class InlineDatasetBuilder(
         0 -> emptyList()
         1 -> listOf(buildPinnedInlineSuggestionDataset(specs.first(), form))
         else -> {
-            val suggestions =
-                suggestionFinder.findVaultSuggestions(form, count = specs.size - 2)
+            // Reserve 1 spec for "Pinned" (always last). Suggestions get remaining specs.
+            val suggestions = suggestionFinder.findVaultSuggestions(
+                form = form,
+                count = specs.size - 1
+            )
+
+            val hasNoSuggestions = suggestions.isEmpty()
+            var remaining = specs.size - 1 - suggestions.size
+
+            val showOpenApp = hasNoSuggestions && remaining > 0
+            if (showOpenApp) remaining--
+
+            val showGeneratePassword = remaining > 0 &&
+                    form.fields.any { it.type is FieldType.Credentials.Password }
 
             buildList {
                 addAll(
@@ -86,19 +100,19 @@ internal class InlineDatasetBuilder(
                     }
                 )
 
-                add(
-                    buildAppInlineSuggestionDataset(
-                        spec = specs[specs.size - 2], // second to last spec
-                        form = form,
+                var specIndex = suggestions.size
+                if (showGeneratePassword)
+                    add(
+                        buildGeneratePasswordInlineSuggestionDataset(
+                            spec = specs[specIndex++],
+                            form = form
+                        )
                     )
-                )
 
-                add(
-                    buildPinnedInlineSuggestionDataset(
-                        spec = specs.last(),
-                        form = form
-                    )
-                )
+                if (showOpenApp)
+                    add(buildAppInlineSuggestionDataset(spec = specs[specIndex], form = form))
+
+                add(buildPinnedInlineSuggestionDataset(spec = specs.last(), form = form))
             }
         }
     }
@@ -126,12 +140,27 @@ internal class InlineDatasetBuilder(
             spec = spec,
             pendingIntent = context.getOnLongClickPendingIntent(),
             icon = appIcon(),
-            title = context.getString(CoreUiR.string.app_name)
+            title = context.getString(R.string.open_app)
         )
 
         return presentation.buildDataset(appRequestData(form))
     }
 
+    @RequiresApi(Build.VERSION_CODES.R)
+    private fun buildGeneratePasswordInlineSuggestionDataset(
+        spec: InlinePresentationSpec,
+        form: Form
+    ): Dataset {
+        val presentation = inlineSuggestionFactory.buildPresentation(
+            spec = spec,
+            pendingIntent = context.getOnLongClickPendingIntent(),
+            icon = Icon.createWithResource(context, R.drawable.baseline_auto_awesome_24),
+            title = context.getString(FeatureItemCreateR.string.generate_password)
+        )
+
+        return presentation.buildDataset(generatePasswordRequestData(form))
+    }
+
     @RequiresApi(Build.VERSION_CODES.R)
     private fun buildInlineSuggestionDataset(
         spec: InlinePresentationSpec,
@@ -168,4 +197,4 @@ internal class InlineDatasetBuilder(
                 setTintBlendMode(BlendMode.DST)
             }
         else null
-}
+}

feature/autofill/src/main/kotlin/de/davis/keygo/feature/autofill/presentation/dataset/menu/MenuDatasetBuilder.kt

@@ -9,9 +9,11 @@ import de.davis.keygo.feature.autofill.R
 import de.davis.keygo.feature.autofill.presentation.dataset.DatasetBuilder
 import de.davis.keygo.feature.autofill.presentation.dataset.SuggestionFinder
 import de.davis.keygo.feature.autofill.presentation.getSelectionPendingIntent
+import de.davis.keygo.feature.autofill.presentation.model.FieldType
 import de.davis.keygo.feature.autofill.presentation.model.Form
 import de.davis.keygo.feature.autofill.presentation.model.FormType
 import de.davis.keygo.feature.autofill.presentation.model.appRequestData
+import de.davis.keygo.feature.autofill.presentation.model.generatePasswordRequestData
 import de.davis.keygo.feature.autofill.presentation.model.suggestionRequestData
 import de.davis.keygo.feature.autofill.presentation.subtitle
 import org.koin.core.annotation.Single
@@ -43,13 +45,29 @@ internal class MenuDatasetBuilder(
 
             suggestions.mapIndexed { index, suggestion ->
                 buildSuggestionDataset(index, form, suggestion)
-            } + listOf(buildAppDataset(form))
+            } + listOfNotNull(buildGeneratePasswordDataset(form), buildAppDataset(form))
         }
     }
 
+    private fun buildGeneratePasswordDataset(form: Form): Dataset? {
+        if (form.fields.none { it.type is FieldType.Credentials.Password }) return null
+
+        val remoteViews = menuDatasetBuilder.buildMenuSuggestion(
+            title = context.getString(de.davis.keygo.feature.item.create.R.string.generate_password),
+            icon = R.drawable.baseline_auto_awesome_24
+        )
+
+        val requestData = generatePasswordRequestData(form)
+        return datasetBuilder.buildDataset(
+            remoteViews = remoteViews,
+            intentSender = context.getSelectionPendingIntent(requestData).intentSender,
+            form = requestData.form,
+        )
+    }
+
     private fun buildAppDataset(form: Form): Dataset {
         val remoteViews = menuDatasetBuilder.buildMenuSuggestion(
-            title = context.getString(CoreUiR.string.app_name),
+            title = context.getString(R.string.open_app),
             subtitle = context.getString(R.string.autofill_service),
             icon = CoreUiR.mipmap.ic_launcher_round
         )

feature/autofill/src/main/kotlin/de/davis/keygo/feature/autofill/presentation/model/AutofillUiState.kt

@@ -9,5 +9,6 @@ internal data class AutofillUiState(
     val request: Request<*> = Request.None,
     val associationDialogVisibility: AssociationDialogVisibility = AssociationDialogVisibility.Hidden,
     val suspicionDialogVisibility: SuspicionDialogVisibility = SuspicionDialogVisibility.Hidden,
+    val showGeneratePassword: Boolean = false,
     val vaultId: ItemId = ItemIdNone
 )

feature/autofill/src/main/kotlin/de/davis/keygo/feature/autofill/presentation/model/RequestData.kt

@@ -32,11 +32,18 @@ internal sealed interface FillRequestData : RequestData {
         // the pending intent would be overridden by the last one created, causing only that one to
         // be received.
         @IgnoredOnParcel
-        override val requestId: Int = 1003 + index
+        override val requestId: Int = 1010 + index
     }
 
     data class App(
         override val form: Form,
+    ) : FillRequestData {
+        @IgnoredOnParcel
+        override val requestId: Int = 1003
+    }
+
+    data class GeneratePassword(
+        override val form: Form,
     ) : FillRequestData {
         @IgnoredOnParcel
         override val requestId: Int = 1002
@@ -54,6 +61,12 @@ internal fun pinnedRequestData(formInformation: Form) =
     FillRequestData.Pinned(form = formInformation)
 
 internal fun appRequestData(formInformation: Form) = FillRequestData.App(form = formInformation)
+internal fun generatePasswordRequestData(formInformation: Form) =
+    FillRequestData.GeneratePassword(
+        form = formInformation.copy(
+            fields = formInformation.fields.filter { it.type is FieldType.Credentials.Password }
+        )
+    )
 
 internal fun suggestionRequestData(formInformation: Form, vaultId: ItemId, index: Int) =
     FillRequestData.Suggestion(

feature/autofill/src/main/res/drawable/baseline_auto_awesome_24.xml

@@ -0,0 +1,12 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android"
+    android:width="24dp"
+    android:height="24dp"
+    android:tint="#000000"
+    android:viewportWidth="24"
+    android:viewportHeight="24">
+
+    <path
+        android:fillColor="@android:color/white"
+        android:pathData="M19,9l1.25,-2.75L23,5l-2.75,-1.25L19,1l-1.25,2.75L15,5l2.75,1.25L19,9zM11.5,9.5L9,4 6.5,9.5 1,12l5.5,2.5L9,20l2.5,-5.5L17,12l-5.5,-2.5zM19,15l-1.25,2.75L15,19l2.75,1.25L19,23l1.25,-2.75L23,19l-2.75,-1.25L19,15z" />
+
+</vector>