fix: start crash handler sooner

We need to start it sooner to catch crashes in things like
other IStartableService's.

Author: jkasten2

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/CoreModule.kt

@@ -102,7 +102,7 @@ internal class CoreModule : IModule {
         builder.register<OneSignalOpenTelemetryCrashLocal>().provides<IOneSignalOpenTelemetryCrash>()
         builder.register<OneSignalCrashConfigProvider>().provides<IOneSignalCrashConfigProvider>()
 
-        builder.register<OneSignalCrashHandler>().provides<IStartableService>()
+        builder.register<OneSignalCrashHandler>().provides<OneSignalCrashHandler>()
         builder.register<OneSignalCrashUploader>().provides<IStartableService>()
 
         builder.register<OneSignalOtelFieldsTopLevel>().provides<OneSignalOtelFieldsTopLevel>()

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/debug/internal/crash/OneSignalCrashHandler.kt

@@ -1,6 +1,5 @@
 package com.onesignal.debug.internal.crash
 
-import com.onesignal.core.internal.startup.IStartableService
 import kotlinx.coroutines.runBlocking
 
 /**
@@ -10,12 +9,11 @@ import kotlinx.coroutines.runBlocking
  */
 internal class OneSignalCrashHandler(
     private val _crashReporter: IOneSignalCrashReporter,
-) : IStartableService,
-    Thread.UncaughtExceptionHandler {
+) : Thread.UncaughtExceptionHandler {
     private var existingHandler: Thread.UncaughtExceptionHandler? = null
     private val seenThrowables: MutableList<Throwable> = mutableListOf()
 
-    override fun start() {
+    init {
         existingHandler = Thread.getDefaultUncaughtExceptionHandler()
         Thread.setDefaultUncaughtExceptionHandler(this)
     }

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/internal/OneSignalImp.kt

@@ -23,6 +23,7 @@ import com.onesignal.core.internal.startup.StartupService
 import com.onesignal.debug.IDebugManager
 import com.onesignal.debug.LogLevel
 import com.onesignal.debug.internal.DebugManager
+import com.onesignal.debug.internal.crash.OneSignalCrashHandler
 import com.onesignal.debug.internal.logging.Logging
 import com.onesignal.inAppMessages.IInAppMessagesManager
 import com.onesignal.location.ILocationManager
@@ -214,6 +215,11 @@ internal class OneSignalImp(
 
         // Give the logging singleton access to the application service to support visual logging.
         Logging.applicationService = applicationService
+
+        // Crash handler needs to be one of the first things we setup,
+        // otherwise we'll not report some crashes, resulting in a false sense
+        // of stability.
+        services.getService<OneSignalCrashHandler>()
     }
 
     private fun updateConfig() {