Revert "Add mutex protection to checkAndTriggerSubscriptionChanged"

This reverts commit 9620ffc.

A simpler fix without side-effects was done in commit
11d6b0b.

Author: jkasten2

src/helpers/EventHelper.ts

@@ -11,52 +11,34 @@ import LocalStorage from '../utils/LocalStorage';
 import { CustomLinkManager } from '../managers/CustomLinkManager';
 
 export default class EventHelper {
-  static _mutexPromise: Promise<void> = Promise.resolve();
-  static _mutexLocked = false;
-
-  static async onNotificationPermissionChange() {
-    await EventHelper.checkAndTriggerSubscriptionChanged();
+  static onNotificationPermissionChange() {
+    EventHelper.checkAndTriggerSubscriptionChanged();
   }
 
   static async onInternalSubscriptionSet(optedOut: boolean) {
     LimitStore.put('subscription.optedOut', optedOut);
   }
 
   static async checkAndTriggerSubscriptionChanged() {
-    if (EventHelper._mutexLocked) {
-      await EventHelper._mutexPromise;
-    }
-
-    EventHelper._mutexLocked = true;
-    // eslint-disable-next-line no-async-promise-executor
-    EventHelper._mutexPromise = new Promise(async (resolve, reject) => {
-      try {
-        OneSignalUtils.logMethodCall('checkAndTriggerSubscriptionChanged');
-        const context: ContextSWInterface = OneSignal.context;
-        const subscriptionState = await context.subscriptionManager.getSubscriptionState();
-        const isPushEnabled = await OneSignal.privateIsPushNotificationsEnabled();
-        const appState = await Database.getAppState();
-        const { lastKnownPushEnabled } = appState;
-        const didStateChange = (
-          lastKnownPushEnabled === null ||
-          isPushEnabled !== lastKnownPushEnabled
-        );
-        if (!didStateChange) return;
-        Log.info(
-          `The user's subscription state changed from ` +
-            `${lastKnownPushEnabled === null ? '(not stored)' : lastKnownPushEnabled} ⟶ ${subscriptionState.subscribed}`
-        );
-        LocalStorage.setIsPushNotificationsEnabled(isPushEnabled);
-        appState.lastKnownPushEnabled = isPushEnabled;
-        await Database.setAppState(appState);
-        EventHelper.triggerSubscriptionChanged(isPushEnabled);
-        EventHelper._mutexLocked = false;
-        resolve();
-      } catch (e) {
-        EventHelper._mutexLocked = false;
-        reject(`checkAndTriggerSubscriptionChanged error: ${e}`);
-      }
-    });
+    OneSignalUtils.logMethodCall('checkAndTriggerSubscriptionChanged');
+    const context: ContextSWInterface = OneSignal.context;
+    const subscriptionState = await context.subscriptionManager.getSubscriptionState();
+    const isPushEnabled = await OneSignal.privateIsPushNotificationsEnabled();
+    const appState = await Database.getAppState();
+    const { lastKnownPushEnabled } = appState;
+    const didStateChange = (
+      lastKnownPushEnabled === null ||
+      isPushEnabled !== lastKnownPushEnabled
+    );
+    if (!didStateChange) return;
+    Log.info(
+      `The user's subscription state changed from ` +
+        `${lastKnownPushEnabled === null ? '(not stored)' : lastKnownPushEnabled} ⟶ ${subscriptionState.subscribed}`
+    );
+    LocalStorage.setIsPushNotificationsEnabled(isPushEnabled);
+    appState.lastKnownPushEnabled = isPushEnabled;
+    await Database.setAppState(appState);
+    EventHelper.triggerSubscriptionChanged(isPushEnabled);
   }
 
   static async _onSubscriptionChanged(newSubscriptionState: boolean | undefined) {

test/unit/public-sdk-apis/onSession.ts

@@ -18,7 +18,6 @@ import {
 import { createSubscription } from "../../support/tester/utils";
 import EventsTestHelper from '../../support/tester/EventsTestHelper';
 import { DelayedPromptType } from '../../../src/models/Prompts';
-import EventHelper from "../../../src/helpers/EventHelper";
 
 
 const sinonSandbox: SinonSandbox = sinon.sandbox.create();
@@ -31,8 +30,6 @@ test.afterEach(function (_t: ExecutionContext) {
   OneSignal._initCalled = false;
   OneSignal.__initAlreadyCalled = false;
   OneSignal._sessionInitAlreadyRunning = false;
-  EventHelper._mutexPromise = Promise.resolve();
-  EventHelper._mutexLocked = false;
 });
 
 /**