Merge pull request #1392 from OneSignal/fg/fix-release

fix create release on github permissions

Author: fadi-george

.github/workflows/cd.yml

@@ -11,22 +11,22 @@ on:
 jobs:
   check_release:
     runs-on: ubuntu-22.04
+    outputs:
+      should_run: ${{ steps.check.outputs.should_run }}
     steps:
       - name: Check if release merge or workflow dispatch
-        id: check_release
+        id: check
         uses: actions/github-script@v8
         with:
           script: |
-            // Allow workflow_dispatch and release PR merges
-            if (context.eventName !== 'push') return;
-
-            // For push events, check if it's a release merge
-            const isReleaseMerge = /Release \d{6}/.test(context.payload.head_commit.message);
-            if (!isReleaseMerge) core.setFailed('Not a release merge - skipping workflow');
+            const shouldRun = context.eventName === 'workflow_dispatch' ||
+                             /Release \d{6}/.test(context.payload.head_commit.message);
+            core.setOutput('should_run', shouldRun);
 
   test_build_deploy:
     runs-on: ubuntu-22.04
     needs: check_release
+    if: needs.check_release.outputs.should_run == 'true'
     steps:
       - uses: actions/checkout@v5
       - name: Use Node.js

.github/workflows/create-release-on-github.yml

@@ -7,9 +7,6 @@ jobs:
   create-release-notes:
     runs-on: ubuntu-latest
 
-    env:
-      GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-
     steps:
       - uses: actions/checkout@v5
         with:
@@ -59,17 +56,23 @@ jobs:
               return;
             }
 
-            core.setOutput('notes', releasePr.body);
+            const releaseNotes = releasePr.body.split('<!--')[0].trim();
+            core.setOutput('notes', releaseNotes);
+
       - name: Create GitHub Release
         uses: actions/github-script@v8
+        env:
+          RELEASE_NOTES: ${{ steps.release_notes.outputs.notes }}
         with:
           script: |
+            const notes = process.env.RELEASE_NOTES;
+
             await github.rest.repos.createRelease({
               owner: context.repo.owner,
               repo: context.repo.repo,
               tag_name: '${{ steps.get_version.outputs.version }}',
               name: 'Release ${{ steps.get_version.outputs.version }}',
-              body: '${{ steps.release_notes.outputs.notes }}',
+              body: notes,
               draft: false,
               prerelease: false
             });

.github/workflows/create-release-pr.yml

@@ -103,7 +103,11 @@ jobs:
         uses: actions/github-script@v8
         with:
           script: |
-            const prs = JSON.parse('${{ steps.get_prs.outputs.prs }}');
+            // Trim whitespace from PR titles
+            const prs = JSON.parse('${{ steps.get_prs.outputs.prs }}').map(pr => ({
+              ...pr,
+              title: pr.title.trim()
+            }));
 
             // Categorize PRs
             const features = prs.filter(pr => /^feat/i.test(pr.title));