Skip to content

Commit fd0ea96

Browse files
committed
disable base url change
Disabling this by default as it doesn't work with the manifest.json. Only commenting it out as this is still a test case we want to support and went to continue making it easy to test.
1 parent 0d42c87 commit fd0ea96

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

express_webpack/index.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55

66
<!-- Some sites use this HTML base tag to change the origin for all relative links.
77
Ensure OneSignal SDK correctly handles this. -->
8-
<base href="https://www.example.com/">
8+
<!-- NOTE: This does not work with the relative pathed manifest.json above. -->
9+
<!--<base href="https://www.example.com/"> -->
910
<script src="sdks/Dev-OneSignalSDK.js" defer=""></script>
1011
<script>
1112
// NOTE: Uncomment and open site in Safari on macOS 13+ to simulate

0 commit comments

Comments
 (0)