fix: review findings -- style_analyzer bugs, type annotations, duplicate test

style_analyzer.py:
1. Boolean precedence bug in _check_type_hints: 'type ' alone returned
   True without ': ' due to and/or precedence. Added parentheses.
2. Cache key mismatch: save_to_cache read 'languages' but
   analyze_repository_style returns 'language_distribution'. Caching
   was silently broken (iterated empty dict). Fixed key + load shape.
3. load_from_cache return type: was -> Dict, returns None. Fixed to
   -> Optional[Dict], added Optional to imports.
4. save_to_cache: added -> None return annotation.

test_multi_tenancy.py:
5. Removed duplicate assertion block in
   test_verify_repo_access_raises_404_for_wrong_user (exact same
   verify_repo_access call repeated, dead code).

284 tests pass.

Author: DevanshuNEU

backend/services/style_analyzer.py

@@ -3,7 +3,7 @@
 Analyzes team coding patterns, naming conventions, and best practices
 """
 from pathlib import Path
-from typing import Dict, List, Set
+from typing import Dict, List, Optional, Set
 from collections import defaultdict, Counter
 import re
 
@@ -137,7 +137,7 @@ def _check_type_hints(self, source_code: str, language: str) -> bool:
         if language == 'python':
             return '->' in source_code or ': ' in source_code
         else:
-            return ': ' in source_code and 'interface' in source_code or 'type ' in source_code
+            return ': ' in source_code and ('interface' in source_code or 'type ' in source_code)
 
     def analyze_repository_style(self, repo_path: str) -> Dict:
         """Analyze coding style patterns across repository"""
@@ -264,14 +264,14 @@ def analyze_repository_style(self, repo_path: str) -> Dict:
 
 
     # SUPABASE CACHING
-    def save_to_cache(self, repo_id: str, style_data: Dict):
+    def save_to_cache(self, repo_id: str, style_data: Dict) -> None:
         """Save style analysis to Supabase for caching"""
         from services.supabase_service import get_supabase_service
 
         db = get_supabase_service()
 
-        # Group by language
-        for language, data in style_data.get("languages", {}).items():
+        # analyze_repository_style returns "language_distribution" not "languages"
+        for language, data in style_data.get("language_distribution", {}).items():
             analysis = {
                 "naming_convention": data.get("naming_conventions"),
                 "async_usage": data.get("async_usage"),
@@ -284,7 +284,7 @@ def save_to_cache(self, repo_id: str, style_data: Dict):
 
         logger.debug("Cached code style analysis in Supabase", repo_id=repo_id)
 
-    def load_from_cache(self, repo_id: str) -> Dict:
+    def load_from_cache(self, repo_id: str) -> Optional[Dict]:
         """Load style analysis from Supabase cache"""
         from services.supabase_service import get_supabase_service
 
@@ -318,7 +318,7 @@ def load_from_cache(self, repo_id: str) -> Dict:
         logger.debug("Loaded cached code style from Supabase", repo_id=repo_id)
 
         return {
-            "languages": languages,
+            "language_distribution": languages,
             "top_imports": common_imports,
             "patterns": patterns
         }

backend/tests/test_multi_tenancy.py

@@ -196,11 +196,6 @@ def test_verify_repo_access_raises_404_for_wrong_user(self):
 
             assert exc_info.value.status_code == 404
 
-            with pytest.raises(HTTPException) as exc_info:
-                verify_repo_access("repo-user2-a", "user-1")
-
-            assert exc_info.value.status_code == 404
-
 
 # DEV API KEY TESTS
 class TestDevApiKeySecurity: