Merge pull request #262 from DevanshuNEU/chore/ci-quality-gates

DevanshuNEU · web-flow · commit 1de8893c4a68 · 2026-02-24T22:59:50.000-05:00
chore: enforce CI quality gates -- flake8 blocks, ESLint added, security blocks (OPE-55)
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -34,23 +34,28 @@ jobs:
     needs: changes
     if: ${{ needs.changes.outputs.backend == 'true' }}
     runs-on: ubuntu-latest
-    
+
     steps:
     - uses: actions/checkout@v4
-    
+
     - name: Set up Python
       uses: actions/setup-python@v5
       with:
         python-version: '3.11'
         cache: 'pip'
-    
+
     - name: Install dependencies
       working-directory: ./backend
       run: |
         python -m pip install --upgrade pip
-        pip install pytest pytest-cov httpx
+        pip install pytest pytest-cov httpx flake8
         pip install -r requirements.txt
-    
+
+    - name: Lint (flake8)
+      working-directory: ./backend
+      run: |
+        flake8 services/ routes/ middleware/ config/ dependencies.py main.py
+
     - name: Run tests
       working-directory: ./backend
       env:
@@ -64,64 +69,63 @@ jobs:
         PINECONE_INDEX_NAME: "codeintel-test"
       run: |
         pytest tests/ -v --cov=services --cov-report=term-missing
-    
-    - name: Check code quality
-      working-directory: ./backend
-      run: |
-        pip install flake8
-        flake8 services/ --max-line-length=120 --ignore=E501,W503 || true
 
   test-frontend:
     name: Frontend Tests
     needs: changes
     if: ${{ needs.changes.outputs.frontend == 'true' }}
     runs-on: ubuntu-latest
-    
+
     steps:
     - uses: actions/checkout@v4
-    
+
     - name: Set up Bun
       uses: oven-sh/setup-bun@v2
       with:
         bun-version: latest
-    
+
     - name: Install dependencies
       working-directory: ./frontend
       run: bun install
-    
+
+    - name: Lint (ESLint)
+      working-directory: ./frontend
+      run: bun run lint
+
+    - name: Check TypeScript
+      working-directory: ./frontend
+      run: bun run tsc --noEmit
+
     - name: Build frontend
       working-directory: ./frontend
       run: bun run build
-    
+
     - name: Run tests
       working-directory: ./frontend
       run: bun run test
-    
-    - name: Check TypeScript
-      working-directory: ./frontend
-      run: bun run tsc --noEmit
 
   security-scan:
     name: Security Scan
+    needs: changes
+    if: ${{ needs.changes.outputs.backend == 'true' || needs.changes.outputs.frontend == 'true' }}
     runs-on: ubuntu-latest
-    continue-on-error: true
-    
+
     steps:
     - uses: actions/checkout@v4
       with:
         fetch-depth: 0
-    
+
     - name: Run Trivy vulnerability scanner
       uses: aquasecurity/trivy-action@master
       with:
         scan-type: 'fs'
         scan-ref: '.'
         format: 'table'
-        exit-code: '0'
-    
+        severity: 'CRITICAL,HIGH'
+        exit-code: '1'
+
     - name: Check for secrets
       uses: trufflesecurity/trufflehog@main
-      continue-on-error: true
       with:
         path: ./
         base: main
diff --git a/backend/.flake8 b/backend/.flake8
@@ -0,0 +1,26 @@
+[flake8]
+max-line-length = 120
+
+# Only check for real bugs, not style.
+# F = pyflakes (unused imports, undefined names, shadowed vars)
+# E9 = runtime errors (syntax errors, indentation)
+# W6 = deprecated features
+# Style codes (E1/E2/E3/E5/W1/W2/W3/W5) are intentionally excluded.
+select = E9,F,W6
+
+# Directories to skip
+exclude =
+    .git,
+    __pycache__,
+    .venv,
+    venv,
+    repos,
+    scripts,
+    migrations
+
+# Per-file ignores
+per-file-ignores =
+    # main.py loads dotenv before imports (intentional)
+    main.py:E402
+    # __init__.py often has unused imports for re-export
+    __init__.py:F401
diff --git a/backend/dependencies.py b/backend/dependencies.py
@@ -3,7 +3,7 @@
 All route modules import from here to avoid circular imports.
 """
 from typing import Optional
-from fastapi import HTTPException, Depends
+from fastapi import HTTPException
 
 from services.indexer_optimized import OptimizedCodeIndexer
 from services.repo_manager import RepositoryManager
@@ -13,10 +13,10 @@
 from services.dna_extractor import DNAExtractor
 from services.rate_limiter import RateLimiter, APIKeyManager
 from services.supabase_service import get_supabase_service
-from services.input_validator import InputValidator, CostController
-from services.user_limits import init_user_limits_service, get_user_limits_service
+from services.input_validator import CostController
+from services.user_limits import init_user_limits_service
 from services.repo_validator import get_repo_validator
-from services.observability import metrics
+from services.observability import metrics  # noqa: F401 -- re-exported for routes
 
 # Service instances (singleton pattern)
 indexer = OptimizedCodeIndexer()
diff --git a/backend/main.py b/backend/main.py
@@ -19,7 +19,7 @@
 init_sentry()
 
 # Import API config (single source of truth for versioning)
-from config.api import API_PREFIX, API_VERSION
+from config.api import API_PREFIX
 from config.startup_checks import validate_environment
 
 # Import routers
diff --git a/backend/routes/auth.py b/backend/routes/auth.py
@@ -2,7 +2,7 @@
 Authentication Routes
 Handles user signup, login, and session management
 """
-from fastapi import APIRouter, HTTPException, Depends, status
+from fastapi import APIRouter, HTTPException, Depends
 from pydantic import BaseModel, EmailStr
 from typing import Optional, Dict, Any
 from services.auth import get_auth_service
diff --git a/backend/routes/github.py b/backend/routes/github.py
@@ -10,7 +10,6 @@
 import secrets
 import httpx
 from fastapi import APIRouter, HTTPException, Depends, Query
-from fastapi.responses import RedirectResponse
 from typing import Optional
 from pydantic import BaseModel
 from urllib.parse import urlencode
diff --git a/backend/routes/repos.py b/backend/routes/repos.py
@@ -159,8 +159,8 @@ async def delete_repository(
     if not user_id:
         raise HTTPException(status_code=401, detail="User ID required")
     
-    # Verify ownership
-    repo = get_repo_or_404(repo_id, user_id)
+    # Verify ownership (raises 404 if not found)
+    get_repo_or_404(repo_id, user_id)
     
     try:
         success = repo_manager.delete_repo(repo_id)
diff --git a/backend/routes/search.py b/backend/routes/search.py
@@ -135,7 +135,7 @@ async def explain_code(
     add_breadcrumb("Explain request received", category="explain", file_path=request.file_path)
     
     try:
-        repo = get_repo_or_404(request.repo_id, auth.user_id)
+        get_repo_or_404(request.repo_id, auth.user_id)
         
         logger.info(
             "Generating code explanation",
diff --git a/backend/routes/ws_playground.py b/backend/routes/ws_playground.py
@@ -9,7 +9,6 @@
 """
 import json
 import asyncio
-from typing import Optional
 
 from fastapi import WebSocket, WebSocketDisconnect
 
diff --git a/backend/services/auth.py b/backend/services/auth.py
@@ -6,7 +6,6 @@
 from typing import Optional, Dict, Any
 import os
 import jwt as pyjwt
-from datetime import datetime
 from supabase import create_client, Client
 
 from services.observability import logger
diff --git a/backend/services/dependency_analyzer.py b/backend/services/dependency_analyzer.py
@@ -11,7 +11,7 @@
 import tree_sitter_javascript as tsjavascript
 from tree_sitter import Language, Parser
 
-from services.observability import logger, capture_exception, track_time, metrics
+from services.observability import logger, metrics
 
 
 class DependencyAnalyzer:
diff --git a/backend/services/dna_extractor.py b/backend/services/dna_extractor.py
@@ -4,11 +4,10 @@
 Generates a DNA document that helps AI understand how to write consistent code.
 """
 from pathlib import Path
-from typing import Dict, List, Set, Optional, Any
-from collections import defaultdict, Counter
+from typing import Dict, List, Optional
+from collections import Counter
 from dataclasses import dataclass, field, asdict
 import re
-import json
 
 import tree_sitter_python as tspython
 import tree_sitter_javascript as tsjavascript
@@ -122,7 +121,7 @@ def to_dict(self) -> Dict:
     
     def to_markdown(self) -> str:
         """Generate markdown DNA document for AI consumption"""
-        md = f"# Codebase DNA\n\n"
+        md = "# Codebase DNA\n\n"
         
         # Framework detection
         if self.detected_framework:
@@ -823,9 +822,6 @@ def _extract_test_patterns(self, files: List[Path], repo_path: Path) -> TestPatt
         conftest_files = list(repo_path.rglob('conftest.py'))
         pattern.has_conftest = len(conftest_files) > 0
         
-        # Check for test directory structure
-        test_dirs = [d for d in ['tests', 'test'] if (repo_path / d).exists()]
-        
         for file_path in files:
             try:
                 content = file_path.read_text(encoding='utf-8', errors='ignore')
diff --git a/backend/services/exceptions.py b/backend/services/exceptions.py
@@ -8,17 +8,14 @@
 
 class AuthenticationError(Exception):
     """Base auth error. All auth exceptions inherit from this."""
-    pass
 
 
 class TokenExpiredError(AuthenticationError):
     """JWT token has expired."""
-    pass
 
 
 class InvalidTokenError(AuthenticationError):
     """JWT token is malformed, wrong signature, or invalid audience."""
-    pass
 
 
 class TokenMissingClaimError(AuthenticationError):
@@ -31,19 +28,15 @@ def __init__(self, claim: str = "sub"):
 
 class InvalidCredentialsError(AuthenticationError):
     """Login failed due to wrong email/password."""
-    pass
 
 
 class SignupError(AuthenticationError):
     """User registration failed."""
-    pass
 
 
 class SessionError(AuthenticationError):
     """Token refresh or logout failed."""
-    pass
 
 
 class UserIdRequiredError(AuthenticationError):
     """Operation requires a user_id but auth context has None (e.g., API key without user)."""
-    pass
diff --git a/backend/services/indexer_optimized.py b/backend/services/indexer_optimized.py
@@ -10,11 +10,10 @@
 """
 import os
 from pathlib import Path
-from typing import List, Dict, Optional, Tuple
+from typing import List, Dict, Optional
 import asyncio
-from collections import defaultdict
 
-from utils.test_detection import is_test_file, filter_test_files
+from utils.test_detection import filter_test_files
 
 # Tree-sitter for parsing
 import tree_sitter_python as tspython
@@ -36,7 +35,7 @@
 from services.search_v2 import TreeSitterExtractor, FunctionFilter, ExtractedFunction
 
 # Observability
-from services.observability import logger, trace_operation, track_time, capture_exception, add_breadcrumb, metrics
+from services.observability import logger, track_time, capture_exception, add_breadcrumb, metrics
 
 # Configuration
 # Note: If using existing Pinecone index, match the dimension (1536 for small, 3072 for large)
diff --git a/backend/services/indexing_events.py b/backend/services/indexing_events.py
@@ -8,7 +8,7 @@
 Entity can be job_id (playground) or repo_id (dashboard).
 """
 import json
-from typing import Optional, Any
+from typing import Optional
 from enum import Enum
 from dataclasses import dataclass, asdict
 
diff --git a/backend/services/input_validator.py b/backend/services/input_validator.py
@@ -4,7 +4,6 @@
 """
 from typing import Optional, Set
 from urllib.parse import urlparse
-from pathlib import Path, PurePosixPath
 import re
 import os
 import ipaddress
diff --git a/backend/services/rate_limiter.py b/backend/services/rate_limiter.py
@@ -4,7 +4,7 @@
 """
 import time
 from typing import Optional, Dict, Callable
-from datetime import datetime, timedelta
+from datetime import datetime
 from functools import wraps
 import hashlib
 import secrets
diff --git a/backend/services/repo_manager.py b/backend/services/repo_manager.py
@@ -3,12 +3,11 @@
 Handles repository CRUD operations with PostgreSQL via Supabase
 """
 import uuid
-from typing import Dict, List, Optional
-import os
+from typing import List, Optional
 import git
 from pathlib import Path
 from services.supabase_service import get_supabase_service
-from services.observability import logger, capture_exception, metrics
+from services.observability import logger, metrics
 
 
 class RepositoryManager:
diff --git a/backend/services/search_enhancer.py b/backend/services/search_enhancer.py
@@ -4,7 +4,7 @@
 rich embeddings, and hybrid search techniques.
 """
 import re
-from typing import List, Dict, Optional
+from typing import List, Dict
 from openai import AsyncOpenAI
 import os
 
diff --git a/backend/services/search_v2/summary_generator.py b/backend/services/search_v2/summary_generator.py
@@ -1,6 +1,5 @@
 """Generate concise summaries for functions using GPT-4o-mini."""
-import asyncio
-from typing import List, Optional
+from typing import List
 from openai import AsyncOpenAI
 
 from services.search_v2.types import ExtractedFunction
diff --git a/backend/services/search_v3/code_graph_ranker.py b/backend/services/search_v3/code_graph_ranker.py
diff --git a/backend/services/search_v3/embedding_provider.py b/backend/services/search_v3/embedding_provider.py
diff --git a/backend/services/search_v3/query_understanding.py b/backend/services/search_v3/query_understanding.py
diff --git a/backend/services/search_v3/search_engine.py b/backend/services/search_v3/search_engine.py
diff --git a/backend/services/style_analyzer.py b/backend/services/style_analyzer.py
diff --git a/backend/services/supabase_service.py b/backend/services/supabase_service.py
diff --git a/backend/services/user_limits.py b/backend/services/user_limits.py
diff --git a/frontend/bun.lock b/frontend/bun.lock
diff --git a/frontend/eslint.config.js b/frontend/eslint.config.js
diff --git a/frontend/package.json b/frontend/package.json
