fix: address CodeRabbit review feedback

Backend (indexing_events.py):
- Add explicit guard for files_total <= 0 (division by zero)
- Remove channel truncation in logs for better debugging

Backend (repos.py):
- Add TODO comment for Redis Streams alternative

Frontend (IndexingProgressModal.tsx):
- Use composite key for recentFiles list (file + index)
- Add aria-label to close button
- Add Escape key handler to close modal

Author: DevanshuNEU

backend/routes/repos.py

@@ -257,6 +257,7 @@ async def _run_async_indexing(
     try:
         # Wait for WebSocket client to connect and subscribe
         # Redis pub/sub doesn't buffer - events sent before subscription are lost
+        # TODO: Consider Redis Streams or initial state fetch to avoid timing dependency
         await asyncio.sleep(1.5)
 
         repo_manager.update_status(repo_id, "indexing")

backend/services/indexing_events.py

@@ -36,13 +36,18 @@ class IndexingProgress:
     functions_total: int = 0  # Total functions to embed (set during embedding phase)
 
     def __post_init__(self):
+        # Guard against division by zero
+        if self.files_total <= 0:
+            self.percent = 0
+            return
+            
         # If we have functions_total, we're in embedding phase (slow) - weight it 80%
         # File extraction is fast, weight it 20%
-        if self.functions_total > 0 and self.files_total > 0:
+        if self.functions_total > 0:
             file_progress = (self.files_processed / self.files_total) * 20  # 0-20%
             embed_progress = (self.functions_found / self.functions_total) * 80  # 0-80%
             self.percent = int(file_progress + embed_progress)
-        elif self.files_total > 0:
+        else:
             # Still in file extraction phase (0-20%)
             self.percent = int((self.files_processed / self.files_total) * 20)
 
@@ -85,7 +90,7 @@ def _publish(self, entity_id: str, event: dict) -> bool:
             result = self.redis.publish(channel, json.dumps(event))
             logger.info(
                 "Published event to Redis",
-                channel=channel[:40],
+                channel=channel,
                 event_type=event.get("type"),
                 subscribers=result
             )

frontend/src/components/IndexingProgressModal.tsx

@@ -82,6 +82,25 @@ export function IndexingProgressModal({
     }
   }, [isOpen])
 
+  // Handle Escape key to close modal
+  useEffect(() => {
+    if (!isOpen) return
+    
+    const handleKeyDown = (e: KeyboardEvent) => {
+      if (e.key === 'Escape') {
+        if (closeTimeoutRef.current) {
+          clearTimeout(closeTimeoutRef.current)
+          closeTimeoutRef.current = null
+        }
+        reset()
+        onClose()
+      }
+    }
+    
+    document.addEventListener('keydown', handleKeyDown)
+    return () => document.removeEventListener('keydown', handleKeyDown)
+  }, [isOpen, onClose, reset])
+
   const handleClose = () => {
     if (closeTimeoutRef.current) {
       clearTimeout(closeTimeoutRef.current)
@@ -128,6 +147,7 @@ export function IndexingProgressModal({
             </h3>
             <button
               onClick={handleClose}
+              aria-label="Close dialog"
               className="p-1 text-zinc-400 hover:text-white transition-colors rounded-lg hover:bg-zinc-800"
             >
               <X className="w-5 h-5" />
@@ -171,7 +191,7 @@ export function IndexingProgressModal({
                 <div className="space-y-1 max-h-32 overflow-y-auto">
                   {recentFiles.slice(0, 5).map((file, i) => (
                     <motion.div
-                      key={file}
+                      key={`${file}-${i}`}
                       initial={{ opacity: 0, x: -10 }}
                       animate={{ opacity: 1 - i * 0.15, x: 0 }}
                       className="flex items-center gap-2 text-sm"