Commit 3a5236d
committed
fix: address PR review -- a11y, tier limit, backdrop guard
5 findings verified and fixed:
1. AddRepoForm close button: add aria-label='Close' for screen readers
2. AddRepoForm backdrop: use isBusy (loading || analyzing) guard instead
of just loading -- prevents dismissal during analyze API call
3. DirectoryPicker close button: add aria-label='Close'
4. DirectoryPicker props: add functionLimit to interface (was destructured
but missing from type definition)
5. DashboardHome: derive userTier from session metadata with 'free' fallback
instead of hardcoded TIER_FUNCTION_LIMITS.free
Skipped: TierName move to types.ts -- type derives from TIER_FUNCTION_LIMITS
via keyof typeof, colocating with the constant is cleaner than re-exporting.
Build passes.1 parent 0748123 commit 3a5236d
3 files changed
Lines changed: 10 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
94 | | - | |
| 94 | + | |
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
| |||
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
| 116 | + | |
116 | 117 | | |
117 | 118 | | |
118 | 119 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
24 | 25 | | |
25 | 26 | | |
26 | 27 | | |
| |||
187 | 188 | | |
188 | 189 | | |
189 | 190 | | |
| 191 | + | |
190 | 192 | | |
191 | 193 | | |
192 | 194 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
28 | 31 | | |
29 | 32 | | |
30 | 33 | | |
| |||
256 | 259 | | |
257 | 260 | | |
258 | 261 | | |
259 | | - | |
| 262 | + | |
| 263 | + | |
260 | 264 | | |
261 | 265 | | |
262 | 266 | | |
| |||
0 commit comments