fix: address CodeRabbit review feedback

Backend:
- Use repo-relative paths for SKIP_DIRS check (fixes false skip when
  repo is stored in folder named 'repos', 'dist', etc.)

Frontend:
- Add type guards to extractErrorMessage() - check typeof before using
- Add showUpgradeToast() helper - DRYs 4 duplicate toast blocks
- Add JSON.stringify fallback for object error details

Author: DevanshuNEU

backend/services/repo_validator.py

@@ -246,8 +246,10 @@ def _find_code_files(self, repo_path: str) -> tuple[list[Path], Optional[str]]:
                 if file_path.is_symlink():
                     continue
 
-                # Skip files in excluded directories
-                if any(skip_dir in file_path.parts for skip_dir in self.SKIP_DIRS):
+                # Skip files in excluded directories (use repo-relative path to avoid
+                # false positives when repo is stored in a folder named 'repos', etc.)
+                rel_parts = file_path.relative_to(repo_root).parts
+                if any(skip_dir in rel_parts for skip_dir in self.SKIP_DIRS):
                     continue
 
                 # Check extension

frontend/src/components/dashboard/DashboardHome.tsx

@@ -36,8 +36,12 @@ const MAX_FREE_REPOS = 3
 // Extract error message from API response (handles nested detail objects)
 function extractErrorMessage(err: any, fallback: string): string {
   if (typeof err?.detail === 'string') return err.detail
-  if (err?.detail?.message) return err.detail.message
-  if (err?.message) return err.message
+  if (typeof err?.detail?.message === 'string') return err.detail.message
+  if (typeof err?.message === 'string') return err.message
+  // Last resort: try to stringify if it's an object
+  if (err?.detail && typeof err.detail === 'object') {
+    return JSON.stringify(err.detail)
+  }
   return fallback
 }
 
@@ -47,6 +51,14 @@ function isUpgradeError(err: any): boolean {
   return ['REPO_TOO_LARGE', 'REPO_LIMIT_REACHED'].includes(code)
 }
 
+// Show upgrade toast with waitlist CTA (DRY helper for 4 call sites)
+function showUpgradeToast(err: any, fallback: string, onJoin: () => void) {
+  toast.error(extractErrorMessage(err, fallback), {
+    description: 'Join the Pro waitlist for higher limits',
+    action: { label: 'Join Waitlist', onClick: onJoin }
+  })
+}
+
 type RepoTab = 'overview' | 'search' | 'dependencies' | 'insights' | 'impact'
 
 export function DashboardHome() {
@@ -115,10 +127,7 @@ export function DashboardHome() {
       if (!response.ok) {
         const err = await response.json().catch(() => ({}))
         if (isUpgradeError(err)) {
-          toast.error(extractErrorMessage(err, 'Repository too large'), {
-            description: 'Join the Pro waitlist for higher limits',
-            action: { label: 'Join Waitlist', onClick: () => setShowUpgradeModal(true) }
-          })
+          showUpgradeToast(err, 'Repository too large', () => setShowUpgradeModal(true))
           return
         }
         throw new Error(extractErrorMessage(err, 'Failed to add repository'))
@@ -136,10 +145,7 @@ export function DashboardHome() {
       if (!indexResponse.ok) {
         const err = await indexResponse.json().catch(() => ({}))
         if (isUpgradeError(err)) {
-          toast.error(extractErrorMessage(err, 'Repository too large'), {
-            description: 'Join the Pro waitlist for higher limits',
-            action: { label: 'Join Waitlist', onClick: () => setShowUpgradeModal(true) }
-          })
+          showUpgradeToast(err, 'Repository too large', () => setShowUpgradeModal(true))
           return
         }
         throw new Error(extractErrorMessage(err, 'Failed to start indexing'))
@@ -183,10 +189,7 @@ export function DashboardHome() {
         if (!response.ok) {
           const err = await response.json().catch(() => ({}))
           if (isUpgradeError(err)) {
-            toast.error(extractErrorMessage(err, `${repo.name} too large`), {
-              description: 'Join the Pro waitlist for higher limits',
-              action: { label: 'Join Waitlist', onClick: () => setShowUpgradeModal(true) }
-            })
+            showUpgradeToast(err, `${repo.name} too large`, () => setShowUpgradeModal(true))
             continue
           }
           throw new Error(extractErrorMessage(err, `Failed to add ${repo.name}`))
@@ -204,10 +207,7 @@ export function DashboardHome() {
         if (!indexResponse.ok) {
           const err = await indexResponse.json().catch(() => ({}))
           if (isUpgradeError(err)) {
-            toast.error(extractErrorMessage(err, `${repo.name} too large`), {
-              description: 'Join the Pro waitlist for higher limits',
-              action: { label: 'Join Waitlist', onClick: () => setShowUpgradeModal(true) }
-            })
+            showUpgradeToast(err, `${repo.name} too large`, () => setShowUpgradeModal(true))
             continue
           }
           const errMsg = extractErrorMessage(err, 'Indexing failed to start')