Skip to content

Commit 6c042bb

Browse files
committed
fix: review findings -- hoist inline imports, log silent exception
1. Hoisted 4 identical inline 'from services.supabase_service import get_supabase_service' to module-level. No circular import issue. 2. update_last_used: silent 'except: pass' now logs at debug level so timestamp update failures are visible. Skipped: singleton class (stateless module, zero instance state), async conversion (5th+ time, sync Supabase client). 289 tests pass.
1 parent 47ce43a commit 6c042bb

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

backend/services/github_connections.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@
88
from datetime import datetime, timezone
99

1010
from services.observability import logger
11+
from services.supabase_service import get_supabase_service
1112

1213

1314
def get_connection(user_id: str) -> Optional[dict]:
1415
"""Get user's GitHub connection from database."""
1516
try:
16-
from services.supabase_service import get_supabase_service
1717
db = get_supabase_service().client
1818
result = db.table("github_connections").select("*").eq("user_id", user_id).execute()
1919
return result.data[0] if result.data else None
@@ -32,7 +32,6 @@ def save_connection(
3232
) -> bool:
3333
"""Save or update GitHub connection in database."""
3434
try:
35-
from services.supabase_service import get_supabase_service
3635
db = get_supabase_service().client
3736

3837
data = {
@@ -54,7 +53,6 @@ def save_connection(
5453
def delete_connection(user_id: str) -> bool:
5554
"""Remove GitHub connection."""
5655
try:
57-
from services.supabase_service import get_supabase_service
5856
db = get_supabase_service().client
5957
db.table("github_connections").delete().eq("user_id", user_id).execute()
6058
return True
@@ -66,10 +64,9 @@ def delete_connection(user_id: str) -> bool:
6664
def update_last_used(user_id: str) -> None:
6765
"""Update last_used_at timestamp."""
6866
try:
69-
from services.supabase_service import get_supabase_service
7067
db = get_supabase_service().client
7168
db.table("github_connections").update(
7269
{"last_used_at": datetime.now(timezone.utc).isoformat()}
7370
).eq("user_id", user_id).execute()
74-
except Exception:
75-
pass
71+
except Exception as e:
72+
logger.debug("Failed to update last_used_at", user_id=user_id, error=str(e))

0 commit comments

Comments
 (0)