Skip to content

Commit cb05f2e

Browse files
committed
fix: review findings (MD037 underscores, bun.lock consistency)
- PR template line 47: wrap latency placeholders in backticks so MD037 does not parse `___` as emphasis. - frontend/CLAUDE.md off-limits section: change `bun.lockb` to `bun.lock` to match the actual lockfile on disk and the rest of this file. Reviewer suggested the reverse, but verification against the working tree shows the text-format `bun.lock` is what Bun is using here. Skipped review finding: convert bold labels under "What changed" to ATX headings. Those labels are inline bold text, not Setext headings, so MD003 does not apply. Adding `###` headers per stack would add visual weight that contradicts the "lighter, less generic" direction this template was built for. Note: the root CLAUDE.md also has a `bun.lockb` reference inconsistency (off-limits section). Leaving that for a separate follow-up since it is not part of this PR.
1 parent 49afb64 commit cb05f2e

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444

4545
- [ ] Data model matches ADR
4646
- [ ] Consistency guarantee matches ADR (strong / read-after-write / eventual)
47-
- [ ] Latency target honored, measured: p50 ___ ms / p95 ___ ms (ADR target: ___)
47+
- [ ] Latency target honored, measured: p50 `<value>` ms / p95 `<value>` ms (ADR target: `<value>`)
4848
- [ ] Blast radius is what the ADR predicted
4949
- [ ] All ADR acceptance criteria pass
5050

frontend/CLAUDE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,6 @@ Most files stay under 200 lines. These are approved larger due to logical cohesi
7878

7979
## Off-limits files in frontend/
8080

81-
- `bun.lockb`
81+
- `bun.lock`
8282

8383
Never delete or hand-edit. Let Bun manage it.

0 commit comments

Comments
 (0)