Skip to content

Commit b9e3e27

Browse files
FlorisFokkingaFlorisFokkinga
committed
Reverted change in log and test
1 parent 6615256 commit b9e3e27

34 files changed

+80
-80
lines changed

‎src/OpenConext/EngineBlockBundle/EventListener/RedirectToFeedbackPageExceptionListener.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ public function onKernelException(GetResponseForExceptionEvent $event)
156156
$message = 'Unable to verify message';
157157
$redirectToRoute = 'authentication_feedback_verification_failed';
158158
} elseif ($exception instanceof EngineBlock_Exception_UnknownServiceProvider) {
159-
$message = 'Unknown application Provider';
159+
$message = 'Unknown Service Provider';
160160
$redirectToRoute = 'authentication_feedback_unknown_service_provider';
161161

162162
$redirectParams = [

‎src/OpenConext/EngineBlockFunctionalTestingBundle/Features/AcsTinkering.feature‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ Feature:
88
And no registered SPs
99
And no registered Idps
1010
And an Identity Provider named "AlwaysAuth"
11-
And an application named "Malicious SP"
12-
And an application named "Malconfigured SP"
11+
And a Service Provider named "Malicious SP"
12+
And a Service Provider named "Malconfigured SP"
1313
And SP "Malicious SP" is set with acs location "javascript:alert('Hello world')"
1414
And SP "Malconfigured SP" is set with acs location "sp.example.com"
1515

‎src/OpenConext/EngineBlockFunctionalTestingBundle/Features/AttributeAggregation.feature‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Feature:
88
And no registered SPs
99
And no registered Idps
1010
And an Identity Provider named "IDP-AA"
11-
And an application named "SP-AA"
11+
And a Service Provider named "SP-AA"
1212
And SP "SP-AA" requires attribute aggregation
1313
And feature "eb.run_all_manipulations_prior_to_consent" is disabled
1414

‎src/OpenConext/EngineBlockFunctionalTestingBundle/Features/AttributeManipulation.feature‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ Feature:
99
And no registered Idps
1010
And an Identity Provider named "Dummy-IdP"
1111
And an Identity Provider named "IdP-with-Attribute-Manipulations"
12-
And an application named "Dummy-SP"
13-
And an application named "SP-with-Attribute-Manipulations"
14-
And an application named "Stepup Gateway"
15-
And an application named "Stepup SelfService"
12+
And a Service Provider named "Dummy-SP"
13+
And a Service Provider named "SP-with-Attribute-Manipulations"
14+
And a Service Provider named "Stepup Gateway"
15+
And a Service Provider named "Stepup SelfService"
1616
And feature "eb.run_all_manipulations_prior_to_consent" is disabled
1717

1818
Scenario: The application can have an attribute added

‎src/OpenConext/EngineBlockFunctionalTestingBundle/Features/AttributeManipulationException.feature‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ Feature:
99
And no registered Idps
1010
And an Identity Provider named "Dummy-IdP"
1111
And an Identity Provider named "IdP-with-Attribute-Manipulations"
12-
And an application named "Dummy-SP"
13-
And an application named "SP-with-Attribute-Manipulations"
12+
And a Service Provider named "Dummy-SP"
13+
And a Service Provider named "SP-with-Attribute-Manipulations"
1414

1515
Scenario: The application can have an attribute added
1616
Given SP "SP-with-Attribute-Manipulations" has the following Attribute Manipulation:

‎src/OpenConext/EngineBlockFunctionalTestingBundle/Features/AttributeManipulationWithAllManipulationsBeforeConsent.feature‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ Feature:
99
And no registered Idps
1010
And an Identity Provider named "Dummy-IdP"
1111
And an Identity Provider named "IdP-with-Attribute-Manipulations"
12-
And an application named "Dummy-SP"
13-
And an application named "SP-with-Attribute-Manipulations"
12+
And a Service Provider named "Dummy-SP"
13+
And a Service Provider named "SP-with-Attribute-Manipulations"
1414
And feature "eb.run_all_manipulations_prior_to_consent" is enabled
1515

1616
Scenario: The application can have an attribute added

‎src/OpenConext/EngineBlockFunctionalTestingBundle/Features/AttributeReleasePolicy.feature‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8,19 +8,19 @@ Feature:
88
And no registered SPs
99
And no registered Idps
1010
And an Identity Provider named "TestIdp"
11-
And an application named "No ARP"
12-
And an application named "Empty ARP"
13-
And an application named "Wildcard ARP"
14-
And an application named "Wrong Value ARP"
15-
And an application named "Right Value ARP"
16-
And an application named "Specific Value ARP"
17-
And an application named "Two value ARP"
18-
And an application named "Trusted Proxy"
19-
And an application named "Stepup Gateway"
20-
And an application named "Stepup SelfService"
21-
And an application named "Release As"
22-
And an application named "Use as NameID"
23-
And an application named "Use as NameID and Release As"
11+
And a Service Provider named "No ARP"
12+
And a Service Provider named "Empty ARP"
13+
And a Service Provider named "Wildcard ARP"
14+
And a Service Provider named "Wrong Value ARP"
15+
And a Service Provider named "Right Value ARP"
16+
And a Service Provider named "Specific Value ARP"
17+
And a Service Provider named "Two value ARP"
18+
And a Service Provider named "Trusted Proxy"
19+
And a Service Provider named "Stepup Gateway"
20+
And a Service Provider named "Stepup SelfService"
21+
And a Service Provider named "Release As"
22+
And a Service Provider named "Use as NameID"
23+
And a Service Provider named "Use as NameID and Release As"
2424
And SP "Empty ARP" allows no attributes
2525
And SP "Wildcard ARP" allows an attribute named "urn:mace:dir:attribute-def:uid"
2626
And SP "Wrong Value ARP" allows an attribute named "urn:mace:terena.org:attribute-def:schacHomeOrganization" with value "example.edu"

‎src/OpenConext/EngineBlockFunctionalTestingBundle/Features/AttributeReleasePolicyWithAllManipulationsBeforeConsent.feature‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ Feature:
88
And no registered SPs
99
And no registered Idps
1010
And an Identity Provider named "TestIdp"
11-
And an application named "No ARP"
12-
And an application named "Empty ARP"
13-
And an application named "Wildcard ARP"
14-
And an application named "Wrong Value ARP"
15-
And an application named "Right Value ARP"
16-
And an application named "Two value ARP"
11+
And a Service Provider named "No ARP"
12+
And a Service Provider named "Empty ARP"
13+
And a Service Provider named "Wildcard ARP"
14+
And a Service Provider named "Wrong Value ARP"
15+
And a Service Provider named "Right Value ARP"
16+
And a Service Provider named "Two value ARP"
1717
And SP "Empty ARP" allows no attributes
1818
And SP "Wildcard ARP" allows an attribute named "urn:mace:dir:attribute-def:uid"
1919
And SP "Wrong Value ARP" allows an attribute named "urn:mace:terena.org:attribute-def:schacHomeOrganization" with value "example.edu"

‎src/OpenConext/EngineBlockFunctionalTestingBundle/Features/AuthenticationLoop.feature‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ Feature:
99
And no registered SPs
1010
And no registered Idps
1111
And an Identity Provider named "Dummy Idp"
12-
And an application named "Dummy SP"
12+
And a Service Provider named "Dummy SP"
1313

1414
Scenario: an authentication loop is detected
1515
When I log in at "Dummy SP"

‎src/OpenConext/EngineBlockFunctionalTestingBundle/Features/Bindings.feature‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Feature:
88
And no registered SPs
99
And no registered Idps
1010
And an Identity Provider named "Dummy Idp"
11-
And an application named "Dummy SP"
11+
And a Service Provider named "Dummy SP"
1212

1313
Scenario: EngineBlock accepts AuthnRequests using HTTP-POST binding
1414
Given the SP uses the HTTP POST Binding

0 commit comments

Comments
 (0)