Count of wrong matches #27
Description
Desktop Browsers have often a lot of additional 'trash' inside userAgent.
openDDR detection is often wrong detecting a device (false positive), because of finding some tokens inside this additional trash.
Most often there seam to be MD-MD2 vendor=ZTE Model=MOMO Design MD2 false positive detected. Detection is done by TwoStepDeviceBuilder, but it seams only substring 'md' is sufficient to detect wrong. There are really a lot wrong detection with this device. Here is one example userAgent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; GTB7.4; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.04506.30; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; MDDR; InfoPath.1; .NET4.0C; OfficeLiveConnector.1.5; OfficeLivePatch.1.3).
One correct UserAgent from this device is 'MD-MD2/1.0 ACS-NF/3.2 Qtv/4.3' So a match on combined 'MD-MD2' would be already very much better.
There are a lot of other false detections:
Examples:
1.)
Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; BTRS123118; .NET4.0C; .NET4.0E; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729)
detected as SIE-3118
2.)
Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; GTB7.4; SIMBAR={4ADE03E1-A233-11DF-9EA1-001E101F8A85}; .NET CLR 2.0.50727; .NET CLR 1.1.4322; InfoPath.2; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; OfficeLiveConnector.1.3; OfficeLivePatch.
detected as NEC-e101
3.)
Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; SIMBAR={01202C51-3F35-4CB7-877A-334A31C32F72}; GTB7.4; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; OfficeLiveConnector.1.5; OfficeLivePatch.1.3)
detected as SIE-A31C
In case of ZTE 'MD-MD2' there should surely done a better search-string. But the question is also, why this trash is interpreted. Desktop-Browser detection should have high confidence for this cases. But as I debugged through code, all desktop browser detections have confidence=0, only used as fallback.