Skip to content

Commit d7da87c

Browse files
fix display bugs
1 parent f355462 commit d7da87c

2 files changed

Lines changed: 36 additions & 6 deletions

File tree

src/configure.qml

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ Rectangle {
4141
property bool useSettings: true
4242
property string qopenhdConfPath: ""
4343
property bool qopenhdConfPresent: false
44+
property bool returnHomeAfterPopupClose: false
4445

4546
Component.onCompleted: {
4647
qopenhdConfPath = normalizeLocalFilePath(imageWriter.getValue("qopenhdConfPath"))
@@ -59,6 +60,7 @@ Rectangle {
5960
anchors.right: parent.right
6061
anchors.topMargin: 8
6162
anchors.rightMargin: 8
63+
z: 10
6264
width: 28
6365
height: 28
6466
padding: 4
@@ -133,7 +135,7 @@ ImButton {
133135

134136
ColumnLayout {
135137
anchors.fill: parent
136-
anchors.topMargin: -100
138+
anchors.topMargin: driveSelected ? 16 : -100
137139
anchors.leftMargin: 50
138140
anchors.rightMargin: 50
139141
spacing: 12
@@ -633,6 +635,12 @@ ImButton {
633635

634636
MsgPopup {
635637
id: msgpopup
638+
onClosed: {
639+
if (returnHomeAfterPopupClose) {
640+
returnHomeAfterPopupClose = false
641+
navigateBack()
642+
}
643+
}
636644
}
637645

638646
FileDialog {
@@ -699,6 +707,7 @@ ImButton {
699707
}
700708

701709
function onError(msg) {
710+
returnHomeAfterPopupClose = false
702711
msgpopup.title = qsTr("Error")
703712
msgpopup.text = msg
704713
msgpopup.openPopup()
@@ -947,5 +956,16 @@ ImButton {
947956
imageWriter.setSetting("qopenhdConfPath", qopenhdConfPath)
948957

949958
console.log("[Configure] Settings written: bootType", bootType, "sbc", sbc, "camera", camera)
959+
msgpopup.title = qsTr("Settings written")
960+
msgpopup.text = qsTr("Settings were written to <b>%1</b>.").arg(selectedDevice)
961+
msgpopup.continueButton = true
962+
msgpopup.detailsButton = false
963+
msgpopup.configureButton = false
964+
msgpopup.closeButton = false
965+
msgpopup.quitButton = false
966+
msgpopup.yesButton = false
967+
msgpopup.noButton = false
968+
returnHomeAfterPopupClose = true
969+
msgpopup.openPopup()
950970
}
951971
}

src/update.qml

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ Rectangle {
3131
property double writeSpeedMB: 0
3232
property double lastWriteBytes: 0
3333
property double lastWriteTimestamp: 0
34+
property bool returnHomeAfterPopupClose: false
3435

3536
function navigateBack() {
3637
if (progressBar.visible) {
@@ -783,6 +784,7 @@ Rectangle {
783784

784785
Item {
785786
width: window.width-100
787+
height: contentLayout.implicitHeight + 24
786788
Accessible.name: name+".\n"+description
787789

788790
MouseArea {
@@ -1117,6 +1119,12 @@ Rectangle {
11171119
}
11181120
window.close()
11191121
}
1122+
onClosed: {
1123+
if (returnHomeAfterPopupClose) {
1124+
returnHomeAfterPopupClose = false
1125+
navigateBack()
1126+
}
1127+
}
11201128
}
11211129
MsgPopup {
11221130
id: quitpopup
@@ -1371,6 +1379,7 @@ Rectangle {
13711379
}
13721380

13731381
function onError(msg) {
1382+
returnHomeAfterPopupClose = false
13741383
msgpopup.title = qsTr("Error")
13751384
msgpopup.configureButton = false
13761385
msgpopup.closeButton = false
@@ -1410,13 +1419,14 @@ Rectangle {
14101419
}
14111420

14121421
function onUpdateUploadSuccess() {
1413-
msgpopup.title = qsTr("Update ready")
1414-
msgpopup.text = qsTr("<b>%1</b> was copied to <b>%2</b>.<br>You can now safely remove the card or continue configuring it.").arg(osbutton.text).arg(dstbutton.text)
1415-
msgpopup.continueButton = false
1422+
msgpopup.title = qsTr("Update written")
1423+
msgpopup.text = qsTr("<b>%1</b> was written to <b>%2</b>.<br>You can now safely remove the card.").arg(osbutton.text).arg(dstbutton.text)
1424+
msgpopup.continueButton = true
14161425
msgpopup.detailsButton = false
1417-
msgpopup.configureButton = true
1418-
msgpopup.closeButton = true
1426+
msgpopup.configureButton = false
1427+
msgpopup.closeButton = false
14191428
msgpopup.quitButton = false
1429+
returnHomeAfterPopupClose = true
14201430
msgpopup.openPopup()
14211431
resetWriteButton()
14221432
customizebutton.visible = true

0 commit comments

Comments
 (0)