Remove redundant 'Apply workflow_dispatch overrides' step from build workflows

[simonrosenberg]

Problem

Several build workflows have a redundant pattern: an env: block with hardcoded defaults, followed by an "Apply workflow_dispatch overrides" step that copies inputs.* values into GITHUB_ENV. This override step is effectively a no-op because:

1. For workflow_dispatch: inputs always have defaults that match the env block
2. For pull_request_target: the step is skipped entirely (gated by if: workflow_dispatch)

The duplication is error-prone — if someone updates the input default without updating the env default (or vice versa), they silently diverge.

Fix

Replace hardcoded env defaults with ${{ inputs.X || 'default' }} expressions. For pull_request_target, inputs are empty so the || fallback applies. For workflow_dispatch, the input value is used directly. This eliminates the need for the separate override step.

This was already done for build-swtbench-images.yml in PR #555. The same cleanup should be applied to:

• .github/workflows/build-swebench-images.yml
• Any other workflows using this pattern

Example

Before:

env:
  DATASET: 'princeton-nlp/SWE-bench_Verified'
# ...
steps:
  - name: Apply workflow_dispatch overrides (if any)
    if: ${{ github.event_name == 'workflow_dispatch' }}
    run: |
      if [ -n "${{ inputs.dataset }}" ]; then echo "DATASET=${{ inputs.dataset }}" >> "$GITHUB_ENV"; fi

After:

env:
  DATASET: ${{ inputs.dataset || 'princeton-nlp/SWE-bench_Verified' }}

[simonrosenberg]

Note: build-swebench-images.yml also has stale env vars that should be cleaned up:

• BUILD_BATCH_SIZE — defined and overridden but never referenced in any step
• BUILDKIT_PRUNE_KEEP_GB — defined but never referenced
• BUILDKIT_PRUNE_THRESHOLD_PCT — defined but never referenced

The build-batch-size input should also be removed (same as was done for swtbench in PR #555).

[openhands-ai]

I'm on it! simonrosenberg can track my progress at all-hands.dev

[openhands-ai]

Summary of Work Completed

I've successfully fixed issue #565 by removing the redundant "Apply workflow_dispatch overrides" step from all build workflows.

Checklist - Requirements Addressed

✅ Replace hardcoded env defaults with ${{ inputs.X || 'default' }} expressions - Applied to all 6 workflows

✅ Remove "Apply workflow_dispatch overrides" step - Removed from all workflows that had it

✅ Fix .github/workflows/build-swebench-images.yml - As explicitly requested in the issue

✅ Fix any other workflows using this pattern - Fixed 5 additional workflows:

• build-commit0-images.yml
• build-multiswebench-images.yml
• build-swebenchmultimodal-images.yml
• build-swegym-images.yml
• build-swesmith-images.yml

✅ Remove stale env vars (from issue comment) - Removed BUILD_BATCH_SIZE, BUILDKIT_PRUNE_KEEP_GB, BUILDKIT_PRUNE_THRESHOLD_PCT from workflows where they were defined but never used

✅ Create PR with proper description - PR #660 created with "Fixes #565"

✅ Follow contribution guidelines - Used Co-authored-by trailer, ran pre-commit

Conciseness Check

✅ Changes are minimal and focused - only the 6 workflow files were modified (56 insertions, 123 deletions)

✅ Removed an accidental uv.lock update from the commit before final push

PR Link

#660