transform_t and template_t tests fail on armhf

[gaudenz]

On the Debian build servers the transform_t and template_t tests fail on the armhf architecture. These tests pass on the other architectures built so far. As armhf is a Debian release architecture it would be nice to get the tests to pass for Mapper to be able to be included in the next release.

test 25
      Start 25: template_t

25: Test command: /usr/bin/cmake "-P" "template_t-RUN.cmake"
25: Working Directory: /build/reproducible-path/openorienteering-mapper-0.9.6/obj-arm-linux-gnueabihf/test
25: Test timeout computed to be: 1500
25: ********* Start testing of TemplateTest *********
25: Config: Using QtTest library 5.15.17, Qt 5.15.17 (arm-little_endian-ilp32-eabi-hardfloat shared (dynamic) release build; by GCC 15.2.0), debian unknown
25: PASS   : TemplateTest::initTestCase()
25: PASS   : TemplateTest::gdalUtilTest()
25: PASS   : TemplateTest::worldFilePathTest()
25: FAIL!  : TemplateTest::worldFileUnitTest() Compared values are not the same
25:    Actual   (transform.map(QPointF(0.5, 0.5))): QPointF(5,3)
25:    Expected (QPointF(5, 6))                   : QPointF(5,6)
25:    Loc: [/build/reproducible-path/openorienteering-mapper-0.9.6/test/template_t.cpp(195)]
25: PASS   : TemplateTest::worldFileTemplateTest()
25: PASS   : TemplateTest::templatePathTest()
25: PASS   : TemplateTest::templateImageDrawableTest()
25: ERROR 4: гео.tiff: No such file or directory
25: PASS   : TemplateTest::geoTiffTemplateTest()
25: PASS   : TemplateTest::geoTiffSRSTest()
25: PASS   : TemplateTest::templateTrackTest(TemplateTrack georef)
25: PASS   : TemplateTest::templateTrackTest(TemplateTrack non-georef)
25: PASS   : TemplateTest::templateTrackTest(TemplateTrack OGR georef)
25: PASS   : TemplateTest::templateTrackTest(TemplateTrack OGR non-georef)
25: PASS   : TemplateTest::templateTrackTest(TemplateTrack NAD83)
25: PASS   : TemplateTest::templateTrackTest(OgrTemplate NAD83)
25: XFAIL  : TemplateTest::templateTrackTest(TemplateTrack from v0.8.4) Unsupported WGS 84 -> NAD 83 transformation
25:    Loc: [/build/reproducible-path/openorienteering-mapper-0.9.6/test/template_t.cpp(456)]
25: PASS   : TemplateTest::templateTrackTest(TemplateTrack from v0.8.4)
25: PASS   : TemplateTest::templateTrackTest(TemplateTrack from v0.9.3)
25: Warning 1: +init=epsg:XXXX syntax is deprecated. It might return a CRS with a non-EPSG compliant axis order. Further messages of this type will be suppressed.
25: PASS   : TemplateTest::ogrTemplateTest(TemplateTrack georef)
25: PASS   : TemplateTest::ogrTemplateTest(TemplateTrack non-georef)
25: PASS   : TemplateTest::ogrTemplateTest(TemplateTrack OGR georef)
25: PASS   : TemplateTest::ogrTemplateTest(TemplateTrack OGR non-georef)
25: PASS   : TemplateTest::ogrTemplateTest(OgrTemplate basic)
25: PASS   : TemplateTest::ogrTemplateTest(OgrTemplate compatibility)
25: XFAIL  : TemplateTest::ogrTemplateTest(TemplateTrack NAD83) Unsupported WGS 84 -> NAD 83 transformation
25:    Loc: [/build/reproducible-path/openorienteering-mapper-0.9.6/test/template_t.cpp(501)]
25: PASS   : TemplateTest::ogrTemplateTest(TemplateTrack NAD83)
25: XFAIL  : TemplateTest::ogrTemplateTest(OgrTemplate NAD83) Unsupported WGS 84 -> NAD 83 transformation
25:    Loc: [/build/reproducible-path/openorienteering-mapper-0.9.6/test/template_t.cpp(501)]
25: PASS   : TemplateTest::ogrTemplateTest(OgrTemplate NAD83)
25: ERROR 4: template-track-NA-2019.gpx: No such file or directory
25: PASS   : TemplateTest::ogrTemplateTest(TemplateTrack from v0.8.4)
25: PASS   : TemplateTest::ogrTemplateTest(OGRTemplate from v0.9.3)
25: PASS   : TemplateTest::ogrTemplateGeoreferencingTest()
25: PASS   : TemplateTest::templateTypesConsistentTest(TemplateTrack georef)
25: PASS   : TemplateTest::templateTypesConsistentTest(OgrTemplate georef)
25: XFAIL  : TemplateTest::templateTypesConsistentTest(TemplateTrack NAD83) Unsupported WGS 84 -> NAD 83 transformation
25:    Loc: [/build/reproducible-path/openorienteering-mapper-0.9.6/test/template_t.cpp(575)]
25: PASS   : TemplateTest::templateTypesConsistentTest(TemplateTrack NAD83)
25: XFAIL  : TemplateTest::templateTypesConsistentTest(OgrTemplate NAD83) Unsupported WGS 84 -> NAD 83 transformation
25:    Loc: [/build/reproducible-path/openorienteering-mapper-0.9.6/test/template_t.cpp(575)]
25: PASS   : TemplateTest::templateTypesConsistentTest(OgrTemplate NAD83)
25: PASS   : TemplateTest::templateRotationTest(TemplateImage world file)
25: PASS   : TemplateTest::templateRotationTest(TemplateTrack georef)
25: PASS   : TemplateTest::templateRotationTest(TemplateTrack non-georef)
25: ERROR 4: гео.tiff: No such file or directory
25: PASS   : TemplateTest::templateRotationTest(GdalImage geotiff)
25: PASS   : TemplateTest::templateRotationTest(OgrTemplate basic)
25: PASS   : TemplateTest::templateRotationTest(OgrTemplate compatibility)
25: PASS   : TemplateTest::asyncLoadingTest(TemplateImage)
25: PASS   : TemplateTest::asyncLoadingTest(TemplateTrack georef)
25: PASS   : TemplateTest::asyncLoadingTest(TemplateTrack non-georef)
25: PASS   : TemplateTest::asyncLoadingTest(OgrTemplate basic)
25: PASS   : TemplateTest::asyncLoadingTest(OgrTemplate compatibility)
25: PASS   : TemplateTest::templateTableModelTest()
25: PASS   : TemplateTest::cleanupTestCase()
25: Totals: 44 passed, 1 failed, 0 skipped, 0 blacklisted, 4261ms
25: ********* Finished testing of TemplateTest *********
25: CMake Error at template_t-RUN.cmake:35 (message):
25:   Test template_t failed: 1
25: 
25: 
25/30 Test #25: template_t .........................***Failed    4.43 sec

test 28
      Start 28: transform_t

28: Test command: /usr/bin/cmake "-P" "transform_t-RUN.cmake"
28: Working Directory: /build/reproducible-path/openorienteering-mapper-0.9.6/obj-arm-linux-gnueabihf/test
28: Test timeout computed to be: 1500
28: ********* Start testing of TransformTest *********
28: Config: Using QtTest library 5.15.17, Qt 5.15.17 (arm-little_endian-ilp32-eabi-hardfloat shared (dynamic) release build; by GCC 15.2.0), debian unknown
28: PASS   : TransformTest::initTestCase()
28: PASS   : TransformTest::testTransformBasics()
28: PASS   : TransformTest::testTransformIdentity()
28: PASS   : TransformTest::testTransformTranslate()
28: PASS   : TransformTest::testTransformProject()
28: PASS   : TransformTest::testTransformRotate(No rotation)
28: PASS   : TransformTest::testTransformRotate(90 deg)
28: PASS   : TransformTest::testTransformRotate(180 deg)
28: PASS   : TransformTest::testTransformRotate(200 deg)
28: PASS   : TransformTest::testTransformRotate(270 deg)
28: PASS   : TransformTest::testTransformCombined(No rotation)
28: PASS   : TransformTest::testTransformCombined(90 deg)
28: PASS   : TransformTest::testTransformCombined(180 deg)
28: PASS   : TransformTest::testTransformCombined(200 deg)
28: PASS   : TransformTest::testTransformCombined(270 deg)
28: PASS   : TransformTest::testTransformRoundTrip(No rotation)
28: PASS   : TransformTest::testTransformRoundTrip(90 deg)
28: PASS   : TransformTest::testTransformRoundTrip(180 deg)
28: PASS   : TransformTest::testTransformRoundTrip(-160 deg)
28: PASS   : TransformTest::testTransformRoundTrip(-90 deg)
28: FAIL!  : TransformTest::testEstimateNonIsometric() Compared values are not the same
28:    Actual   (qt.map(passpoints[0].src_coords))  : QPointF(64,0)
28:    Expected (QPointF{passpoints[0].dest_coords}): QPointF(64,64)
28:    Loc: [/build/reproducible-path/openorienteering-mapper-0.9.6/test/transform_t.cpp(286)]
28: PASS   : TransformTest::testEstimateSimilarityTransformation()
28: PASS   : TransformTest::cleanupTestCase()
28: Totals: 22 passed, 1 failed, 0 skipped, 0 blacklisted, 7ms
28: ********* Finished testing of TransformTest *********
28: CMake Error at transform_t-RUN.cmake:35 (message):
28:   Test transform_t failed: 1
28: 
28: 
28/30 Test #28: transform_t ........................***Failed    0.19 sec

Full build log: https://buildd.debian.org/status/fetch.php?pkg=openorienteering-mapper&arch=armhf&ver=0.9.6-2&stamp=1770801502&raw=0

[pkturner]

I don't know how to use Debian servers to debug a problem with a specific architecture, but I am familiar with Mapper's transform code.

It looks as if the failure is due to a data value not getting copied to where it's needed, so that 0 is used instead. Perhaps an aggressive compiler optimization is causing a step to be omitted. These transformations rely heavily on Qt.

[dg0yt]

Enabled Debian Testing armv7l on build.opensuse.org which should be what Debian calls armhf.
Fails as reported.
https://build.opensuse.org/project/monitor/home:dg0yt?arch_armv7l=1&defaults=0&repo_Debian_Testing=1

[dg0yt]

I reversed testing of transformation results and testing of the properties of the transformation in
https://github.com/dg0yt/mapper/commits/tests/
https://build.opensuse.org/package/live_build_log/home:dg0yt:branches:home:dg0yt/openorienteering-mapper-master/Debian_Testing/armv7l

This reports:

[  465s] FAIL!  : TransformTest::testEstimateNonIsometric() Compared values are not the same
[  465s]    Actual   (t.template_y)             : 0
[  465s]    Expected (MapCoord(32,64).nativeY()): 64000

armv7l is 32 bit. What type is qreal on this platform? That's the type behind QPointF and QTransform used in the tested function. (How does it do floating-point math? Do we hit a real limitation or a bug?)

[pkturner]

Wouldn't the assertion in map_coord.cpp

#ifndef MAPPER_NO_QREAL_CHECK
static_assert(std::is_same<qreal, double>::value, ...

assure that qreal is double? I don't find anywhere that defines MAPPER_NO_QREAL_CHECK.

At the same time, my reading suggests that qreal on armv7l would be 32-bit, and I see no problem with the way double and qreal are mixed in estimateNonIsometricSimilarityTransform.

[pkturner]

In Matrix::multiply(const Matrix&, Matrix&), the inner loop

  		for (int k = 0; k < m; ++k)
  			out.set(i, j, out.get(i,j) + get(i, k) * b.get(k, j));

strikes me as a candidate for over-aggressive compiler optimization. The compiler might find a justification for assuming that out.get(i,j) returns the same value for every k.

I don't have evidence that this is how the error arises.

[dg0yt]

Rewriting the k loop to eliminate the out.get() doesn't help.
baa7a57

[dg0yt]

strikes me as a candidate for over-aggressive compiler optimization. The compiler might find a justification for assuming that out.get(i,j) returns the same value for every k.

Building Mapper with -O0 (via DEB_BUILD_OPTIONS=noopt) makes no difference.
However, I didn't change the flags for Qt5 (QTransform).