feat: add action_by and environment to privilege escalation email (#89)

Signed-off-by: romanetar <roman_ag@hotmail.com>

Author: romanetar

app/Mail/MonitoredSecurityGroupNotificationEmail.php

@@ -34,6 +34,11 @@ final class MonitoredSecurityGroupNotificationEmail extends Mailable
      */
     public $action;
 
+    /**
+     * @var string
+     */
+    public $action_by;
+
     /**
      * @var int
      */
@@ -76,9 +81,17 @@ final class MonitoredSecurityGroupNotificationEmail extends Mailable
      */
     public $subject;
 
+    /**
+     * @var string
+     */
+    public $env;
+
+    public $action_by_phrase;
+
     /**
      * @param string $email
      * @param string $action
+     * @param string $action_by
      * @param int $user_id
      * @param string $user_email
      * @param string $user_name
@@ -90,6 +103,7 @@ public function __construct
     (
         string $email,
         string $action,
+        string $action_by,
         int $user_id,
         string $user_email,
         string $user_name,
@@ -100,20 +114,23 @@ public function __construct
     {
         $this->email = $email;
         $this->action = $action;
+        $this->action_by = $action_by;
         $this->user_id = $user_id;
         $this->user_email = $user_email;
         $this->user_name = $user_name;
         $this->group_id = $group_id;
         $this->group_name = $group_name;
         $this->group_slug = $group_slug;
-
+        $this->env = Config::get('app.env');
+        $this->action_by_phrase = $this->action_by ? " by $this->action_by" : "";
         Log::debug
         (
             sprintf
             (
-                "MonitoredSecurityGroupNotificationEmail::constructor email %s action %s user_id %s user_email %s user_name %s group_id %s group_name %s group_slug %s",
+                "MonitoredSecurityGroupNotificationEmail::constructor email %s action %s action_by %s user_id %s user_email %s user_name %s group_id %s group_name %s group_slug %s",
                 $email,
                 $action,
+                $action_by,
                 $user_id,
                 $user_email,
                 $user_name,
@@ -126,15 +143,19 @@ public function __construct
 
     public function build()
     {
+
+
         $this->subject = sprintf
         (
-            "[%s] Monitored Security Groups - User %s (%s) has been %s - Group %s (%s)"
+            "[%s] Monitored Security Groups - User %s (%s) has been %s%s - Group %s (%s) - Environment: %s"
             ,Config::get('app.app_name')
             ,$this->user_name
             ,$this->user_email
             ,$this->action
+            ,$this->action_by_phrase
             ,$this->group_name
             ,$this->group_id
+            ,$this->env
         );
         Log::debug(sprintf("MonitoredSecurityGroupNotificationEmail::build to %s", $this->email));
         return $this->from(Config::get("mail.from"))

app/Services/OpenId/UserService.php

@@ -37,7 +37,6 @@
 use Illuminate\Support\Facades\Storage;
 use models\exceptions\EntityNotFoundException;
 use models\exceptions\ValidationException;
-use Models\OAuth2\Client;
 use models\utils\IEntity;
 use OAuth2\IResourceServerContext;
 use OAuth2\Models\IClient;
@@ -483,6 +482,13 @@ public function notifyMonitoredSecurityGroupActivity(string $action, int $user_i
             return;
         }
 
+        $action_by = '';
+        $current_user = Auth::user();
+
+        if($current_user instanceof User){
+            $action_by = sprintf("%s ( %s )", $current_user->getFullName(), $current_user->getEmail());
+        }
+
         $notified_users = [];
         foreach ($watcher_groups as $watcher_group_slug) {
             Log::debug(sprintf("UserService::notifyMonitoredSecurityGroupActivity processing %s", $watcher_group_slug));
@@ -497,13 +503,15 @@ public function notifyMonitoredSecurityGroupActivity(string $action, int $user_i
                     continue;
                 }
                 $notified_users[] = $user->getId();
+
                 Log::debug(sprintf("UserService::notifyMonitoredSecurityGroupActivity processing user %s", $user->getId()));
                 Mail::queue
                 (
                     new MonitoredSecurityGroupNotificationEmail
                     (
                         $user->getEmail(),
                         $action,
+                        $action_by,
                         $user_id,
                         $user_email,
                         $user_name,
@@ -514,6 +522,5 @@ public function notifyMonitoredSecurityGroupActivity(string $action, int $user_i
                 );
             }
         }
-
     }
 }

resources/views/emails/audit/monitored_security_group_notification.blade.php

@@ -15,14 +15,17 @@
             <td align="center" style="font-size:0px;padding:10px 25px;word-break:break-word;">
                 <div style="font-family:open Sans Helvetica, Arial, sans-serif;font-size:16px;line-height:1;text-align:center;color:#000000;">
                     <p>
-                        User {!! $user_name !!} (Email: {!! $user_email !!}) has been  <b>{!! $action !!}</b>
+                        User {!! $user_name !!} (Email: {!! $user_email !!}) has been  <b>{!! $action !!}</b> {!! $action_by_phrase !!} }
                     </p>
                 </div>
             </td>
         </tr>
         <tr>
             <td align="center" style="font-size:0px;padding:10px 25px;padding-right:25px;padding-left:25px;word-break:break-word;">
                 <div style="font-family:open Sans Helvetica, Arial, sans-serif;font-size:16px;line-height:1;text-align:center;color:#000000;">Thanks! <br/><br/>{{Config::get('app.tenant_name')}} Support Team</div>
+                <div style="font-family:open Sans Helvetica, Arial, sans-serif;font-size:16px;line-height:1;text-align:center;color:#000000;">
+                    <b>{!! $env !!} ENVIRONMENT</b>
+                </div>
             </td>
         </tr>
         </tbody>